René's URL Explorer Experiment


Title: Separately send large mDNS responses to comply with RFC 6762 by gjbadros · Pull Request #248 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Separately send large mDNS responses to comply with RFC 6762 by gjbadros · Pull Request #248 · python-zeroconf/python-zeroconf

X Title: Separately send large mDNS responses to comply with RFC 6762 by gjbadros · Pull Request #248 · python-zeroconf/python-zeroconf

Description: This fixes issue #245 Split up large multi-response packets into separate packets instead of relying on IP Fragmentation. IP Fragmentation of mDNS packets causes ChromeCast Audios to crash their mDNS responder processes and RFC 6762 (https://tools.ietf.org/html/rfc6762) section 17 states some requirements for Multicast DNS Message Size, and the fourth paragraph reads: "A Multicast DNS packet larger than the interface MTU, which is sent using fragments, MUST NOT contain more than one resource record." This change makes this implementation conform with this MUST NOT clause.

Open Graph Description: This fixes issue #245 Split up large multi-response packets into separate packets instead of relying on IP Fragmentation. IP Fragmentation of mDNS packets causes ChromeCast Audios to crash their m...

X Description: This fixes issue #245 Split up large multi-response packets into separate packets instead of relying on IP Fragmentation. IP Fragmentation of mDNS packets causes ChromeCast Audios to crash their m...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/248

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d2ca5f7c-4776-04b7-8285-8e1b18bc50e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3CE:102B0F:554DE:77265:6B00A44A
html-safe-noncea2b09544ac45871d46d0378a30c2775e702dd78a1fda9455590adb835894f302
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0NFOjEwMkIwRjo1NTRERTo3NzI2NTo2QjAwQTQ0QSIsInZpc2l0b3JfaWQiOiIyOTc5NDY5MzIzODQ1ODA1MTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac04a613559760819fbf9e7d1bf7057c9683ddbf302179246b6baa1a4caebd76f9
hovercard-subject-tagpull_request:417544249
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/248/files
twitter:imagehttps://avatars.githubusercontent.com/u/1500109?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1500109?s=400&v=4
og:image:altThis fixes issue #245 Split up large multi-response packets into separate packets instead of relying on IP Fragmentation. IP Fragmentation of mDNS packets causes ChromeCast Audios to crash their m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None455b493e3402a3a3a06beac5d20bb7db3da060808b220aa48d6a7eca7c59863a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2f575159976167242d488c0b062eb355c4e198b7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/248/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F248%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F248%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
gjbadros:masterhttps://github.com/gjbadros/python-zeroconf/tree/master
Conversation 17 https://github.com/python-zeroconf/python-zeroconf/pull/248
Commits 14 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/248/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/248/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
Separately send large mDNS responses to comply with RFC 6762 https://github.com/python-zeroconf/python-zeroconf/pull/248/files#top
Show all changes 14 commits https://github.com/python-zeroconf/python-zeroconf/pull/248/files
e3268d2 Send multiple packets in a DNSOutgoing response when multiple smaller… gjbadros May 9, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e3268d212ab1897c685d3eb44efa26b7ec0976d9
6a7ae11 Fixed a type declaration, and made new log messages debug (not warnin… gjbadros May 9, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/6a7ae11ce40267cc7a1958620d2fa848d000530e
311da47 Add back packet() for backward compatability. gjbadros May 21, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/311da47e9d4c4494abe52bb690360a99f4b9de26
0524706 Protect against empty packets() gjbadros May 21, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/052470674bddbefc8901db84b38a5aa5fedfc459
0231086 Fixed one bug in the implementation (make sure we at least write out … gjbadros May 23, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/023108643ad6c2fcf4acd5f15b45592823bd6bf7
e2b02e3 Merge branch 'master' into master gjbadros May 23, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e2b02e3e18c1df064cb69ad63966739efba129b9
19e88f7 Change formatting to make flake8 happy gjbadros May 23, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/19e88f7794fc480f2e29453225e2f77773e79b07
e322d29 :xMerge branch 'master' of https://github.com/gjbadros/python-zeroconf gjbadros May 23, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e322d29ff9dae112f216017618582a12d5177e42
f737898 Fix test.py to comply with flake8 warnings gjbadros May 23, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/f7378981a6f913091ccd86ac00ff95cc3dee9de0
fc1ac81 Fix test.py to comply with flake8 warnings gjbadros May 23, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/fc1ac81d503d26429c2f6cdc04b551224ec23ab0
08101fb Added a new test to call log_warning_once since that wasn't used any … gjbadros May 23, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/08101fb9bb2fc0a9c611c1cbc0d8005543f58341
3db6a1d Warn about extra-large packet upon creation, too, in order to properl… gjbadros May 23, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/3db6a1de7af45c2c9ad402dd66e4d6396dcd8e57
a444619 Made changes that are responsive to Jakub's review, including a littl… gjbadros May 24, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/a444619fde67cbdd302f479ead3958c7a72e4930
6d2a7a1 Merge branch 'master' into master gjbadros May 24, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/6d2a7a17f2ea554ea7ee3f9d9df81729d3aafa80
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/248/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
__init__.py https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
test.py https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
zeroconf/__init__.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
View file https://github.com/gjbadros/python-zeroconf/blob/6d2a7a17f2ea554ea7ee3f9d9df81729d3aafa80/zeroconf/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/248/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
jstasiakhttps://github.com/jstasiak
May 24, 2020https://github.com/python-zeroconf/python-zeroconf/pull/248/files#r429672500
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
gjbadroshttps://github.com/gjbadros
May 24, 2020https://github.com/python-zeroconf/python-zeroconf/pull/248/files#r429684821
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
zeroconf/test.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
View file https://github.com/gjbadros/python-zeroconf/blob/6d2a7a17f2ea554ea7ee3f9d9df81729d3aafa80/zeroconf/test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/248/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/248/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.