René's URL Explorer Experiment


Title: Separately send large mDNS responses to comply with RFC 6762 by gjbadros · Pull Request #248 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Separately send large mDNS responses to comply with RFC 6762 by gjbadros · Pull Request #248 · python-zeroconf/python-zeroconf

X Title: Separately send large mDNS responses to comply with RFC 6762 by gjbadros · Pull Request #248 · python-zeroconf/python-zeroconf

Description: A pure python implementation of multicast DNS service discovery - Separately send large mDNS responses to comply with RFC 6762 by gjbadros · Pull Request #248 · python-zeroconf/python-zeroconf

Open Graph Description: This fixes issue #245 Split up large multi-response packets into separate packets instead of relying on IP Fragmentation. IP Fragmentation of mDNS packets causes ChromeCast Audios to crash their m...

X Description: This fixes issue #245 Split up large multi-response packets into separate packets instead of relying on IP Fragmentation. IP Fragmentation of mDNS packets causes ChromeCast Audios to crash their m...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/248

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:3fbea2df-229f-6906-2d28-f5382555e440
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC81C:3DE251:5D36C:7FD9E:6B00A483
html-safe-nonce934611f90202c2efede3f6ad81ed02b29513d2934ac62fe0f0835878aae72b28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODFDOjNERTI1MTo1RDM2Qzo3RkQ5RTo2QjAwQTQ4MyIsInZpc2l0b3JfaWQiOiI2Mjk1OTYzOTg2NTg0MTgzOTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace3f396e473fd2241db9c88b5eac8d095d60e29a49c5c12690d1f55798bc9dba7
hovercard-subject-tagpull_request:417544249
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/248/commits
twitter:imagehttps://opengraph.githubassets.com/3e81c9ea1d8193caa5ffaf329483d539be95e1c9ad70d7426dbb5bb290ce26c8/python-zeroconf/python-zeroconf/pull/248
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3e81c9ea1d8193caa5ffaf329483d539be95e1c9ad70d7426dbb5bb290ce26c8/python-zeroconf/python-zeroconf/pull/248
og:image:altThis fixes issue #245 Split up large multi-response packets into separate packets instead of relying on IP Fragmentation. IP Fragmentation of mDNS packets causes ChromeCast Audios to crash their m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegjbadros
hostnamegithub.com
expected-hostnamegithub.com
None455b493e3402a3a3a06beac5d20bb7db3da060808b220aa48d6a7eca7c59863a
turbo-cache-controlno-cache
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2f575159976167242d488c0b062eb355c4e198b7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F248%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F248%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
https://github.com/python-zeroconf/python-zeroconf
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
gjbadros:masterhttps://github.com/gjbadros/python-zeroconf/tree/master
Conversationhttps://github.com/python-zeroconf/python-zeroconf/pull/248
Commits14 (14)https://github.com/python-zeroconf/python-zeroconf/pull/248/commits
Checkshttps://github.com/python-zeroconf/python-zeroconf/pull/248/checks
Files changedhttps://github.com/python-zeroconf/python-zeroconf/pull/248/files
Separately send large mDNS responses to comply with RFC 6762https://github.com/python-zeroconf/python-zeroconf/pull/248/commits#top
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
gjbadros:masterhttps://github.com/gjbadros/python-zeroconf/tree/master
Send multiple packets in a DNSOutgoing response when multiple smaller responses won't fit. This is required by section 17 of RFC6762. Make packet() into packets() and have it return a list of the …https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e3268d212ab1897c685d3eb44efa26b7ec0976d9
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
e3268d2https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e3268d212ab1897c685d3eb44efa26b7ec0976d9
https://github.com/python-zeroconf/python-zeroconf/tree/e3268d212ab1897c685d3eb44efa26b7ec0976d9
Fixed a type declaration, and made new log messages debug (not warning) messages.https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/6a7ae11ce40267cc7a1958620d2fa848d000530e
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
6a7ae11https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/6a7ae11ce40267cc7a1958620d2fa848d000530e
https://github.com/python-zeroconf/python-zeroconf/tree/6a7ae11ce40267cc7a1958620d2fa848d000530e
Add back packet() for backward compatability.https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/311da47e9d4c4494abe52bb690360a99f4b9de26
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
311da47https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/311da47e9d4c4494abe52bb690360a99f4b9de26
https://github.com/python-zeroconf/python-zeroconf/tree/311da47e9d4c4494abe52bb690360a99f4b9de26
Protect against empty packets()https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/052470674bddbefc8901db84b38a5aa5fedfc459
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
0524706https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/052470674bddbefc8901db84b38a5aa5fedfc459
https://github.com/python-zeroconf/python-zeroconf/tree/052470674bddbefc8901db84b38a5aa5fedfc459
Fixed one bug in the implementation (make sure we at least write out the question in the initial packet) and fixed the tests. In particular, the lots_of_names test's behaviour is explicitly suppose…https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/023108643ad6c2fcf4acd5f15b45592823bd6bf7
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
0231086https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/023108643ad6c2fcf4acd5f15b45592823bd6bf7
https://github.com/python-zeroconf/python-zeroconf/tree/023108643ad6c2fcf4acd5f15b45592823bd6bf7
Merge branch 'master' into masterhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e2b02e3e18c1df064cb69ad63966739efba129b9
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
e2b02e3https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e2b02e3e18c1df064cb69ad63966739efba129b9
https://github.com/python-zeroconf/python-zeroconf/tree/e2b02e3e18c1df064cb69ad63966739efba129b9
Change formatting to make flake8 happyhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits/19e88f7794fc480f2e29453225e2f77773e79b07
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
19e88f7https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/19e88f7794fc480f2e29453225e2f77773e79b07
https://github.com/python-zeroconf/python-zeroconf/tree/19e88f7794fc480f2e29453225e2f77773e79b07
:xMerge branch 'master' of https://github.com/gjbadros/python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e322d29ff9dae112f216017618582a12d5177e42
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
e322d29https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/e322d29ff9dae112f216017618582a12d5177e42
https://github.com/python-zeroconf/python-zeroconf/tree/e322d29ff9dae112f216017618582a12d5177e42
Fix test.py to comply with flake8 warningshttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits/f7378981a6f913091ccd86ac00ff95cc3dee9de0
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
f737898https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/f7378981a6f913091ccd86ac00ff95cc3dee9de0
https://github.com/python-zeroconf/python-zeroconf/tree/f7378981a6f913091ccd86ac00ff95cc3dee9de0
Fix test.py to comply with flake8 warningshttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits/fc1ac81d503d26429c2f6cdc04b551224ec23ab0
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
fc1ac81https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/fc1ac81d503d26429c2f6cdc04b551224ec23ab0
https://github.com/python-zeroconf/python-zeroconf/tree/fc1ac81d503d26429c2f6cdc04b551224ec23ab0
Added a new test to call log_warning_once since that wasn't used any more and test coverage went down.https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/08101fb9bb2fc0a9c611c1cbc0d8005543f58341
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
08101fbhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits/08101fb9bb2fc0a9c611c1cbc0d8005543f58341
https://github.com/python-zeroconf/python-zeroconf/tree/08101fb9bb2fc0a9c611c1cbc0d8005543f58341
Warn about extra-large packet upon creation, too, in order to properly test log_warning_once from test sutie.https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/3db6a1de7af45c2c9ad402dd66e4d6396dcd8e57
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
3db6a1dhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits/3db6a1de7af45c2c9ad402dd66e4d6396dcd8e57
https://github.com/python-zeroconf/python-zeroconf/tree/3db6a1de7af45c2c9ad402dd66e4d6396dcd8e57
Made changes that are responsive to Jakub's review, including a little bit more documentation, a variable rename, and a better explanation of a test.https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/a444619fde67cbdd302f479ead3958c7a72e4930
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
a444619https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/a444619fde67cbdd302f479ead3958c7a72e4930
https://github.com/python-zeroconf/python-zeroconf/tree/a444619fde67cbdd302f479ead3958c7a72e4930
Merge branch 'master' into masterhttps://github.com/python-zeroconf/python-zeroconf/pull/248/commits/6d2a7a17f2ea554ea7ee3f9d9df81729d3aafa80
https://github.com/gjbadros
gjbadroshttps://github.com/python-zeroconf/python-zeroconf/commits?author=gjbadros
6d2a7a1https://github.com/python-zeroconf/python-zeroconf/pull/248/commits/6d2a7a17f2ea554ea7ee3f9d9df81729d3aafa80
https://github.com/python-zeroconf/python-zeroconf/tree/6d2a7a17f2ea554ea7ee3f9d9df81729d3aafa80
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.