René's URL Explorer Experiment


Title: Class Unique fix by mattsaxon · Pull Request #217 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Class Unique fix by mattsaxon · Pull Request #217 · python-zeroconf/python-zeroconf

X Title: Class Unique fix by mattsaxon · Pull Request #217 · python-zeroconf/python-zeroconf

Description: Fixes issues with shared records being used where they shouldn't be. PTR records should be shared, but SRV, TXT and A/AAAA records should be unique. Whilst mDNS and DNS-SD in theory support shared records for these types of record, they are not implemented in python-zeroconf at the moment. See zeroconf.check_service() method which verifies the service is unique on the network before registering.

Open Graph Description: Fixes issues with shared records being used where they shouldn't be. PTR records should be shared, but SRV, TXT and A/AAAA records should be unique. Whilst mDNS and DNS-SD in theory support sha...

X Description: Fixes issues with shared records being used where they shouldn't be. PTR records should be shared, but SRV, TXT and A/AAAA records should be unique. Whilst mDNS and DNS-SD in theory support...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/217

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2c56179d-ae98-1756-2d8a-68c0162d3b63
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE62:3FF2FE:3FD354:586BCC:6B008E50
html-safe-nonceb6f3d346ea11dd210ca5b50bc96be0513a0c036fbf14e2714b1df8c43964ee07
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTYyOjNGRjJGRTozRkQzNTQ6NTg2QkNDOjZCMDA4RTUwIiwidmlzaXRvcl9pZCI6IjI1OTkyNTU0MDI2NDIxODE3MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8999bb3976ba87226c8ca8ff58e9178f1d735079f3618e3e3c016b711e24030f
hovercard-subject-tagpull_request:364969506
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/217/files
twitter:imagehttps://avatars.githubusercontent.com/u/11351127?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11351127?s=400&v=4
og:image:altFixes issues with shared records being used where they shouldn't be. PTR records should be shared, but SRV, TXT and A/AAAA records should be unique. Whilst mDNS and DNS-SD in theory support sha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec710a5cb5c47be60abfe6e8410436d409906979dbed614ef09f29c60f5535b08
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebe616a2a6ec1c609d6e002896dff5352d5c5f28b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/217/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F217%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F217%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
Conversation 20 https://github.com/python-zeroconf/python-zeroconf/pull/217
Commits 6 https://github.com/python-zeroconf/python-zeroconf/pull/217/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/217/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/217/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
Class Unique fix https://github.com/python-zeroconf/python-zeroconf/pull/217/files#top
Show all changes 6 commits https://github.com/python-zeroconf/python-zeroconf/pull/217/files
b9a5a45 Ensure all TXT, SRV, A records are unique mattsaxon Jan 19, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/b9a5a4573585ddc3df748ee6f7fa628c9ca575a1
d725c4e Add tests for uniqueness mattsaxon Jan 19, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d725c4e69e7f87089e4fd513b3a5eded22219fc7
ec16abb linting mattsaxon Jan 19, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/ec16abb8f4b450161e6b3149dd63ab7454faf1a5
d21314e Update test.py mattsaxon Jan 20, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d21314e9b4568e3ab75728e5ab3c39f787c63e2c
2751e70 fix a couple of unit tests to be consistent with spec mattsaxon Feb 1, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/2751e70d364b367a366269daf3bf6f699a83e01b
c6472e2 Remove unwanted unittest block jstasiak Feb 2, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/c6472e2476c36d9fc9e30b10a607c99b2e7e9494
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/217/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
__init__.py https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
test.py https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
zeroconf/__init__.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
View file https://github.com/python-zeroconf/python-zeroconf/blob/c6472e2476c36d9fc9e30b10a607c99b2e7e9494/zeroconf/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/217/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
jstasiakhttps://github.com/jstasiak
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217/files#r373868813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
mattsaxonhttps://github.com/mattsaxon
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217/files#r373869322
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
jstasiakhttps://github.com/jstasiak
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217/files#r373869383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
jstasiakhttps://github.com/jstasiak
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217/files#r373872692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
mattsaxonhttps://github.com/mattsaxon
Feb 3, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217/files#r374320216
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#225https://github.com/python-zeroconf/python-zeroconf/pull/225
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
zeroconf/test.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
View file https://github.com/python-zeroconf/python-zeroconf/blob/c6472e2476c36d9fc9e30b10a607c99b2e7e9494/zeroconf/test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/217/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com/python-zeroconf/python-zeroconf/pull/217/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.