René's URL Explorer Experiment


Title: Class Unique fix by mattsaxon · Pull Request #217 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Class Unique fix by mattsaxon · Pull Request #217 · python-zeroconf/python-zeroconf

X Title: Class Unique fix by mattsaxon · Pull Request #217 · python-zeroconf/python-zeroconf

Description: A pure python implementation of multicast DNS service discovery - Class Unique fix by mattsaxon · Pull Request #217 · python-zeroconf/python-zeroconf

Open Graph Description: Fixes issues with shared records being used where they shouldn't be. PTR records should be shared, but SRV, TXT and A/AAAA records should be unique. Whilst mDNS and DNS-SD in theory support sha...

X Description: Fixes issues with shared records being used where they shouldn't be. PTR records should be shared, but SRV, TXT and A/AAAA records should be unique. Whilst mDNS and DNS-SD in theory support...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/217

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9f2f0f6a-e874-f209-1559-8ab0ed8f29de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1F8:4EE5B:39713F:4F0B0C:6B008B71
html-safe-noncecb2dcf1d08616897b1032cd7decb79f3f4daa3b296dac340a98ecd5977693ac8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUY4OjRFRTVCOjM5NzEzRjo0RjBCMEM6NkIwMDhCNzEiLCJ2aXNpdG9yX2lkIjoiMTQyMzM1MDc2NzgyNTIyNjYwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5f48914feaba9289e22f6cb206f1757a48b4245ef1ca2f0652ce4db2f9964748
hovercard-subject-tagpull_request:364969506
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-zeroconf/python-zeroconf/217/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c83f6a8ee1d529eeb67804127b1ee22e12c5d95749a915ea97ed033a885dc819/python-zeroconf/python-zeroconf/pull/217
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c83f6a8ee1d529eeb67804127b1ee22e12c5d95749a915ea97ed033a885dc819/python-zeroconf/python-zeroconf/pull/217
og:image:altFixes issues with shared records being used where they shouldn't be. PTR records should be shared, but SRV, TXT and A/AAAA records should be unique. Whilst mDNS and DNS-SD in theory support sha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemattsaxon
hostnamegithub.com
expected-hostnamegithub.com
Nonec710a5cb5c47be60abfe6e8410436d409906979dbed614ef09f29c60f5535b08
turbo-cache-controlno-cache
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebe616a2a6ec1c609d6e002896dff5352d5c5f28b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/217#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F217
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F217
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/217
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/217
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/217
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
https://github.com/python-zeroconf/python-zeroconf
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
Conversationhttps://github.com/python-zeroconf/python-zeroconf/pull/217
Commits6 (6)https://github.com/python-zeroconf/python-zeroconf/pull/217/commits
Checkshttps://github.com/python-zeroconf/python-zeroconf/pull/217/checks
Files changedhttps://github.com/python-zeroconf/python-zeroconf/pull/217/files
Class Unique fixhttps://github.com/python-zeroconf/python-zeroconf/pull/217#top
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 20, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issue-552467554
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
mattsaxonhttps://github.com/mattsaxon
January 19, 2020 14:37https://github.com/python-zeroconf/python-zeroconf/pull/217#commits-pushed-b9a5a45
https://github.com/mattsaxon
Ensure all TXT, SRV, A records are uniquehttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/b9a5a4573585ddc3df748ee6f7fa628c9ca575a1
b9a5a45https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/b9a5a4573585ddc3df748ee6f7fa628c9ca575a1
https://github.com/mattsaxon
Add tests for uniquenesshttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d725c4e69e7f87089e4fd513b3a5eded22219fc7
d725c4ehttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d725c4e69e7f87089e4fd513b3a5eded22219fc7
https://github.com/mattsaxon
lintinghttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/ec16abb8f4b450161e6b3149dd63ab7454faf1a5
ec16abbhttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/ec16abb8f4b450161e6b3149dd63ab7454faf1a5
https://github.com/mattsaxon
Update test.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d21314e9b4568e3ab75728e5ab3c39f787c63e2c
d21314ehttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d21314e9b4568e3ab75728e5ab3c39f787c63e2c
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 20, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217#ref-issue-548435315
Subsequent calls to update do not trigger MyListener #215 https://github.com/python-zeroconf/python-zeroconf/issues/215
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 20, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576402938
@jstasiakhttps://github.com/jstasiak
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 20, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#event-2964149281
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
Jan 20, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576444450
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 21, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576558698
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
Jan 21, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576633556
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 21, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576680035
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 21, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#event-2966183551
https://github.com/dtantsur
dtantsurhttps://github.com/dtantsur
Jan 22, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-577104137
@mattsaxonhttps://github.com/mattsaxon
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 22, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-577159460
https://tools.ietf.org/html/rfc6762#section-10.2https://tools.ietf.org/html/rfc6762#section-10.2
https://tools.ietf.org/html/rfc6762#section-2https://tools.ietf.org/html/rfc6762#section-2
@dtantsurhttps://github.com/dtantsur
https://tools.ietf.org/html/rfc6763https://tools.ietf.org/html/rfc6763
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/dtantsur
dtantsurhttps://github.com/dtantsur
Jan 22, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-577202220
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Jan 27, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-578950612
#163https://github.com/python-zeroconf/python-zeroconf/issues/163
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
fix a couple of unit tests to be consistent with spechttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/2751e70d364b367a366269daf3bf6f699a83e01b
2751e70https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/2751e70d364b367a366269daf3bf6f699a83e01b
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Feb 1, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-581071002
@jstasiakhttps://github.com/jstasiak
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-581082488
https://tools.ietf.org/html/rfc6762#section-8.3https://tools.ietf.org/html/rfc6762#section-8.3
https://tools.ietf.org/html/rfc6762#section-6https://tools.ietf.org/html/rfc6762#section-6
https://tools.ietf.org/html/rfc6762#section-8.1https://tools.ietf.org/html/rfc6762#section-8.1
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
Feb 2, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217#pullrequestreview-351961728
View reviewed changes https://github.com/python-zeroconf/python-zeroconf/pull/217/files/2751e70d364b367a366269daf3bf6f699a83e01b
jstasiakhttps://github.com/jstasiak
https://github.com/python-zeroconf/python-zeroconf/pull/217#pullrequestreview-351961728
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jstasiakhttps://github.com/jstasiak
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
zeroconf/__init__.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/217/files/2751e70d364b367a366269daf3bf6f699a83e01b#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
jstasiakhttps://github.com/jstasiak
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373868813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
mattsaxonhttps://github.com/mattsaxon
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373869322
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
jstasiakhttps://github.com/jstasiak
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373869383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
jstasiakhttps://github.com/jstasiak
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373872692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
mattsaxonhttps://github.com/mattsaxon
Feb 3, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r374320216
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#225https://github.com/python-zeroconf/python-zeroconf/pull/225
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
zeroconf/test.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/217/files/2751e70d364b367a366269daf3bf6f699a83e01b#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
jstasiakhttps://github.com/jstasiak
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373868865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
mattsaxonhttps://github.com/mattsaxon
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373869247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-581168526
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/jstasiak
Remove unwanted unittest blockhttps://github.com/python-zeroconf/python-zeroconf/pull/217/commits/c6472e2476c36d9fc9e30b10a607c99b2e7e9494
c6472e2https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/c6472e2476c36d9fc9e30b10a607c99b2e7e9494
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
bef8f59https://github.com/python-zeroconf/python-zeroconf/commit/bef8f593ae820eb8465934de91eb27468edf6444
Feb 2, 2020https://github.com/python-zeroconf/python-zeroconf/pull/217#event-3000279421
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
February 3, 2020 19:39https://github.com/python-zeroconf/python-zeroconf/pull/217#event-3003524995
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
Feb 3, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217#ref-pullrequest-559310902
Refactor out unique assertion #225 https://github.com/python-zeroconf/python-zeroconf/pull/225
https://github.com/Jc2k
Jc2khttps://github.com/Jc2k
Mar 31, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/217#ref-issue-591462396
Regression in unique/shared handling for service browser in 0.24.5? #236 https://github.com/python-zeroconf/python-zeroconf/issues/236
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F217
https://github.com/jstasiak
jstasiak https://github.com/jstasiak
https://github.com/python-zeroconf/python-zeroconf/pull/217/files/c6472e2476c36d9fc9e30b10a607c99b2e7e9494
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/217
https://github.com/mattsaxon
https://github.com/jstasiak
https://github.com/dtantsur
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.