| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9f2f0f6a-e874-f209-1559-8ab0ed8f29de |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B1F8:4EE5B:39713F:4F0B0C:6B008B71 |
| html-safe-nonce | cb2dcf1d08616897b1032cd7decb79f3f4daa3b296dac340a98ecd5977693ac8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUY4OjRFRTVCOjM5NzEzRjo0RjBCMEM6NkIwMDhCNzEiLCJ2aXNpdG9yX2lkIjoiMTQyMzM1MDc2NzgyNTIyNjYwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5f48914feaba9289e22f6cb206f1757a48b4245ef1ca2f0652ce4db2f9964748 |
| hovercard-subject-tag | pull_request:364969506 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-zeroconf/python-zeroconf/217/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c83f6a8ee1d529eeb67804127b1ee22e12c5d95749a915ea97ed033a885dc819/python-zeroconf/python-zeroconf/pull/217 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c83f6a8ee1d529eeb67804127b1ee22e12c5d95749a915ea97ed033a885dc819/python-zeroconf/python-zeroconf/pull/217 |
| og:image:alt | Fixes issues with shared records being used where they shouldn't be.
PTR records should be shared, but SRV, TXT and A/AAAA records should be unique.
Whilst mDNS and DNS-SD in theory support sha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mattsaxon |
| hostname | github.com |
| expected-hostname | github.com |
| None | c710a5cb5c47be60abfe6e8410436d409906979dbed614ef09f29c60f5535b08 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git |
| octolytics-dimension-user_id | 120192235 |
| octolytics-dimension-user_login | python-zeroconf |
| octolytics-dimension-repository_id | 21548731 |
| octolytics-dimension-repository_nwo | python-zeroconf/python-zeroconf |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21548731 |
| octolytics-dimension-repository_network_root_nwo | python-zeroconf/python-zeroconf |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | be616a2a6ec1c609d6e002896dff5352d5c5f28b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python-zeroconf/python-zeroconf/pull/217#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F217 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F217 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf |
| Reload | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| Reload | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| Reload | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| python-zeroconf | https://github.com/python-zeroconf |
| python-zeroconf | https://github.com/python-zeroconf/python-zeroconf |
| Code | https://github.com/python-zeroconf/python-zeroconf |
| Issues50 (50) | https://github.com/python-zeroconf/python-zeroconf/issues |
| Pull requests16 (16) | https://github.com/python-zeroconf/python-zeroconf/pulls |
| Discussions | https://github.com/python-zeroconf/python-zeroconf/discussions |
| Actions | https://github.com/python-zeroconf/python-zeroconf/actions |
| Projects | https://github.com/python-zeroconf/python-zeroconf/projects |
| Wiki | https://github.com/python-zeroconf/python-zeroconf/wiki |
| Security and quality5 (5) | https://github.com/python-zeroconf/python-zeroconf/security |
| Insights | https://github.com/python-zeroconf/python-zeroconf/insights |
| https://github.com/python-zeroconf/python-zeroconf |
| jstasiak | https://github.com/jstasiak |
| python-zeroconf:master | https://github.com/python-zeroconf/python-zeroconf/tree/master |
| Conversation | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| Commits6 (6) | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits |
| Checks | https://github.com/python-zeroconf/python-zeroconf/pull/217/checks |
| Files changed | https://github.com/python-zeroconf/python-zeroconf/pull/217/files |
| Class Unique fix | https://github.com/python-zeroconf/python-zeroconf/pull/217#top |
| jstasiak | https://github.com/jstasiak |
| python-zeroconf:master | https://github.com/python-zeroconf/python-zeroconf/tree/master |
|
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Jan 20, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issue-552467554 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| mattsaxon | https://github.com/mattsaxon |
| January 19, 2020 14:37 | https://github.com/python-zeroconf/python-zeroconf/pull/217#commits-pushed-b9a5a45 |
|
| https://github.com/mattsaxon |
| Ensure all TXT, SRV, A records are unique | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/b9a5a4573585ddc3df748ee6f7fa628c9ca575a1 |
| b9a5a45 | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/b9a5a4573585ddc3df748ee6f7fa628c9ca575a1 |
|
| https://github.com/mattsaxon |
| Add tests for uniqueness | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d725c4e69e7f87089e4fd513b3a5eded22219fc7 |
| d725c4e | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d725c4e69e7f87089e4fd513b3a5eded22219fc7 |
|
| https://github.com/mattsaxon |
| linting | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/ec16abb8f4b450161e6b3149dd63ab7454faf1a5 |
| ec16abb | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/ec16abb8f4b450161e6b3149dd63ab7454faf1a5 |
|
| https://github.com/mattsaxon |
| Update test.py | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d21314e9b4568e3ab75728e5ab3c39f787c63e2c |
| d21314e | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/d21314e9b4568e3ab75728e5ab3c39f787c63e2c |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
|
Jan 20, 2020
| https://github.com/python-zeroconf/python-zeroconf/pull/217#ref-issue-548435315 |
|
Subsequent calls to update do not trigger MyListener
#215
| https://github.com/python-zeroconf/python-zeroconf/issues/215 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Jan 20, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576402938 |
| @jstasiak | https://github.com/jstasiak |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Jan 20, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#event-2964149281 |
| https://github.com/jstasiak |
| jstasiak | https://github.com/jstasiak |
| Jan 20, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576444450 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Jan 21, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576558698 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/jstasiak |
| jstasiak | https://github.com/jstasiak |
| Jan 21, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576633556 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Jan 21, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-576680035 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Jan 21, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#event-2966183551 |
| https://github.com/dtantsur |
| dtantsur | https://github.com/dtantsur |
| Jan 22, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-577104137 |
| @mattsaxon | https://github.com/mattsaxon |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Jan 22, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-577159460 |
| https://tools.ietf.org/html/rfc6762#section-10.2 | https://tools.ietf.org/html/rfc6762#section-10.2 |
| https://tools.ietf.org/html/rfc6762#section-2 | https://tools.ietf.org/html/rfc6762#section-2 |
| @dtantsur | https://github.com/dtantsur |
| https://tools.ietf.org/html/rfc6763 | https://tools.ietf.org/html/rfc6763 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/dtantsur |
| dtantsur | https://github.com/dtantsur |
| Jan 22, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-577202220 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Jan 27, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-578950612 |
| #163 | https://github.com/python-zeroconf/python-zeroconf/issues/163 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
|
| https://github.com/mattsaxon |
| fix a couple of unit tests to be consistent with spec | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/2751e70d364b367a366269daf3bf6f699a83e01b |
| 2751e70 | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/2751e70d364b367a366269daf3bf6f699a83e01b |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Feb 1, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-581071002 |
| @jstasiak | https://github.com/jstasiak |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-581082488 |
| https://tools.ietf.org/html/rfc6762#section-8.3 | https://tools.ietf.org/html/rfc6762#section-8.3 |
| https://tools.ietf.org/html/rfc6762#section-6 | https://tools.ietf.org/html/rfc6762#section-6 |
| https://tools.ietf.org/html/rfc6762#section-8.1 | https://tools.ietf.org/html/rfc6762#section-8.1 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/jstasiak |
| jstasiak | https://github.com/jstasiak |
|
Feb 2, 2020
| https://github.com/python-zeroconf/python-zeroconf/pull/217#pullrequestreview-351961728 |
|
View reviewed changes
| https://github.com/python-zeroconf/python-zeroconf/pull/217/files/2751e70d364b367a366269daf3bf6f699a83e01b |
| jstasiak | https://github.com/jstasiak |
| https://github.com/python-zeroconf/python-zeroconf/pull/217#pullrequestreview-351961728 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jstasiak | https://github.com/jstasiak |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| zeroconf/__init__.py | https://github.com/python-zeroconf/python-zeroconf/pull/217/files/2751e70d364b367a366269daf3bf6f699a83e01b#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e |
| jstasiak | https://github.com/jstasiak |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373868813 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| mattsaxon | https://github.com/mattsaxon |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373869322 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| jstasiak | https://github.com/jstasiak |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373869383 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| jstasiak | https://github.com/jstasiak |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373872692 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| mattsaxon | https://github.com/mattsaxon |
| Feb 3, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r374320216 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #225 | https://github.com/python-zeroconf/python-zeroconf/pull/225 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| zeroconf/test.py | https://github.com/python-zeroconf/python-zeroconf/pull/217/files/2751e70d364b367a366269daf3bf6f699a83e01b#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7 |
| jstasiak | https://github.com/jstasiak |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373868865 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| mattsaxon | https://github.com/mattsaxon |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#discussion_r373869247 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| https://github.com/jstasiak |
| jstasiak | https://github.com/jstasiak |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#issuecomment-581168526 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
|
| https://github.com/jstasiak |
| Remove unwanted unittest block | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/c6472e2476c36d9fc9e30b10a607c99b2e7e9494 |
| c6472e2 | https://github.com/python-zeroconf/python-zeroconf/pull/217/commits/c6472e2476c36d9fc9e30b10a607c99b2e7e9494 |
| https://github.com/jstasiak |
| jstasiak | https://github.com/jstasiak |
| bef8f59 | https://github.com/python-zeroconf/python-zeroconf/commit/bef8f593ae820eb8465934de91eb27468edf6444 |
| Feb 2, 2020 | https://github.com/python-zeroconf/python-zeroconf/pull/217#event-3000279421 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
| February 3, 2020 19:39 | https://github.com/python-zeroconf/python-zeroconf/pull/217#event-3003524995 |
| https://github.com/mattsaxon |
| mattsaxon | https://github.com/mattsaxon |
|
Feb 3, 2020
| https://github.com/python-zeroconf/python-zeroconf/pull/217#ref-pullrequest-559310902 |
|
Refactor out unique assertion
#225
| https://github.com/python-zeroconf/python-zeroconf/pull/225 |
| https://github.com/Jc2k |
| Jc2k | https://github.com/Jc2k |
|
Mar 31, 2020
| https://github.com/python-zeroconf/python-zeroconf/pull/217#ref-issue-591462396 |
|
Regression in unique/shared handling for service browser in 0.24.5?
#236
| https://github.com/python-zeroconf/python-zeroconf/issues/236 |
| https://github.co/hiddenchars |
| https://github.com/python-zeroconf/python-zeroconf/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F217 |
|
| https://github.com/jstasiak |
|
jstasiak
| https://github.com/jstasiak |
|
| https://github.com/python-zeroconf/python-zeroconf/pull/217/files/c6472e2476c36d9fc9e30b10a607c99b2e7e9494 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
| Please reload this page | https://github.com/python-zeroconf/python-zeroconf/pull/217 |
|
| https://github.com/mattsaxon |
|
| https://github.com/jstasiak |
|
| https://github.com/dtantsur |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |