René's URL Explorer Experiment


Title: fix: shorten the duplicate packet window to 800 ms by bdraco · Pull Request #1930 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: fix: shorten the duplicate packet window to 800 ms by bdraco · Pull Request #1930 · python-zeroconf/python-zeroconf

X Title: fix: shorten the duplicate packet window to 800 ms by bdraco · Pull Request #1930 · python-zeroconf/python-zeroconf

Description: Summary Lowers the duplicate packet window from 1000 ms to 800 ms so the second copy of a repeated announcement is no longer thrown away when it lands just under a second after the first. RFC 6762 §8.3 has responders repeat announcements about a second apart. lwIP's responder (used by the LibreTiny boards ESPHome supports) jitters that to 926 to 1028 ms on receipt, so roughly a quarter of the time the second announcement was dropped as a duplicate before any listener saw it. Details _DUPLICATE_QUESTION_INTERVAL stays at 999 ms. The two constants were never actually linked. The question interval started as _BROWSER_TIME - 1 in #770, when the browser's first requery was 1000 ms. The packet window became 1000 ms in #841 to match the RFC 6762 §6 rule that a responder must not multicast a record more than once a second. When #1335 raised _BROWSER_TIME to 10 s, 999 became a literal and picked up the "1ms less" comment, but nothing depends on it. The question interval also spaces our own QM requeries, which RFC 6762 wants at least a second apart, so it should stay where it is. Our own answers still follow the once a second rule, since QueryHandler checks that separately and sends recently multicast records through out_delay_queue. Real duplicates (the same packet on several interfaces, or v4 and v6) arrive within a few ms, so they are still dropped. Test plan New test in tests/test_listener.py: a repeat 5 ms later is dropped, a repeat 926 ms later is processed. Bench run against BK7238 and CB3S boards, 10 reboots each with the window patched to 1000, 900 and 800 ms. At 800 ms every reboot that could see both announcements did (7 of 7, gaps down to 945 ms), against 0 of 5 for gaps under a second at 1000 ms.

Open Graph Description: Summary Lowers the duplicate packet window from 1000 ms to 800 ms so the second copy of a repeated announcement is no longer thrown away when it lands just under a second after the first. RFC 6762 ...

X Description: Summary Lowers the duplicate packet window from 1000 ms to 800 ms so the second copy of a repeated announcement is no longer thrown away when it lands just under a second after the first. RFC 6762 ...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1930

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1ea95bc3-853a-d6fe-9c28-72041e96f05f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD016:52510:695B94:8D123C:6B00AD66
html-safe-nonce11475e25c2e2828f89d55ff76d6b2203e51314c9af1470b8daba0f23e58d54bd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDE2OjUyNTEwOjY5NUI5NDo4RDEyM0M6NkIwMEFENjYiLCJ2aXNpdG9yX2lkIjoiMTE5ODU5NTc3Nzc2NTYxNjk5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac282ac330ca14ff4a7613ea5b6140087a52f44cf6c195d61c58ff31056d598ad0
hovercard-subject-tagpull_request:5094359715
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1930/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altSummary Lowers the duplicate packet window from 1000 ms to 800 ms so the second copy of a repeated announcement is no longer thrown away when it lands just under a second after the first. RFC 6762 ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release729d8cda69b3d267995675dfbf89ff27ccf61bf6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1930%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1930%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
shorter_duplicate_windowhttps://github.com/python-zeroconf/python-zeroconf/tree/shorter_duplicate_window
Conversation 6 https://github.com/python-zeroconf/python-zeroconf/pull/1930
Commits 3 https://github.com/python-zeroconf/python-zeroconf/pull/1930/commits
Checks 37 https://github.com/python-zeroconf/python-zeroconf/pull/1930/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1930/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files
fix: shorten the duplicate packet window to 800 ms https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#top
Show all changes 3 commits https://github.com/python-zeroconf/python-zeroconf/pull/1930/files
047dbc4 Shorten the duplicate packet window to 800 ms bdraco Oct 31, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1930/commits/047dbc4d5c123c4786e583f79483d996569320cf
16c4f08 Merge branch 'master' into shorter_duplicate_window bdraco Oct 31, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1930/commits/16c4f081cf5b8421a0bf1b442f90a32d00cb46c0
f267a03 chore: drop stale ~1s wording from duplicate window comments bdraco Oct 31, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1930/commits/f267a03e0e6039aae5afdd842e1cca13bd50c606
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1930/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files
_listener.py https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-482d92e649d0a9dfb6f7434c0ec1854490aeda07f86f21ac36e348a9ad1ab4d2
const.py https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-2925fab357e035f1e0cb51ebce6d44e682392bccd5b6b5809dc1f5ea78d6d9b4
test_listener.py https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-19b2f8112118f7597bd34eb1327f706bd5c20bd7b300a1dd787a3e3cfc64dd7c
src/zeroconf/_listener.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-482d92e649d0a9dfb6f7434c0ec1854490aeda07f86f21ac36e348a9ad1ab4d2
View file https://github.com/python-zeroconf/python-zeroconf/blob/f267a03e0e6039aae5afdd842e1cca13bd50c606/src/zeroconf/_listener.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1930/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-482d92e649d0a9dfb6f7434c0ec1854490aeda07f86f21ac36e348a9ad1ab4d2
https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-482d92e649d0a9dfb6f7434c0ec1854490aeda07f86f21ac36e348a9ad1ab4d2
src/zeroconf/const.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-2925fab357e035f1e0cb51ebce6d44e682392bccd5b6b5809dc1f5ea78d6d9b4
View file https://github.com/python-zeroconf/python-zeroconf/blob/f267a03e0e6039aae5afdd842e1cca13bd50c606/src/zeroconf/const.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1930/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-2925fab357e035f1e0cb51ebce6d44e682392bccd5b6b5809dc1f5ea78d6d9b4
https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-2925fab357e035f1e0cb51ebce6d44e682392bccd5b6b5809dc1f5ea78d6d9b4
tests/test_listener.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-19b2f8112118f7597bd34eb1327f706bd5c20bd7b300a1dd787a3e3cfc64dd7c
View file https://github.com/python-zeroconf/python-zeroconf/blob/f267a03e0e6039aae5afdd842e1cca13bd50c606/tests/test_listener.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1930/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-19b2f8112118f7597bd34eb1327f706bd5c20bd7b300a1dd787a3e3cfc64dd7c
https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-19b2f8112118f7597bd34eb1327f706bd5c20bd7b300a1dd787a3e3cfc64dd7c
https://github.com/python-zeroconf/python-zeroconf/pull/1930/files#diff-19b2f8112118f7597bd34eb1327f706bd5c20bd7b300a1dd787a3e3cfc64dd7c
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1930/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.