René's URL Explorer Experiment


Title: refactor: compute service info request pacing from fresh clock reads by bdraco · Pull Request #1895 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: refactor: compute service info request pacing from fresh clock reads by bdraco · Pull Request #1895 · python-zeroconf/python-zeroconf

X Title: refactor: compute service info request pacing from fresh clock reads by bdraco · Pull Request #1895 · python-zeroconf/python-zeroconf

Description: Summary Restructures the ServiceInfo.async_request polling loop the same way #1888 restructured the registration probe loop: wait-first if/continue shape, a fresh clock read at the top of each cycle, and deadline arithmetic in place of the carried now/next_/last trio. This is the last structural item from the tenth audit's inventory (#1835). Details Behavior preserved: fail at the deadline or on denial; the first query goes out immediately (QU unless a question type is passed, later queries QM); each send schedules the next at delay plus random jitter; the QM duplicate question escalation stands; every wake from a record update re-checks completeness; the listener is always removed. Wait durations are computed from the current clock rather than a value cached before the previous send, so queries land on schedule instead of accumulating per-cycle lag. The loop now reads the same way as async_check_service without being coupled to it. A shared pacing primitive was considered and rejected: the two loops differ in termination (probe count vs deadline/completion), cadence (fixed schedule vs adaptive jitter) and wake condition (engine notify vs the info's own futures), so extraction would be a callback-shaped abstraction bigger than the three lines it saves, with bound-method indirection in a Cythonized module. Perf: one extra current_time_millis() call per query sent, in a loop whose iterations are separated by 25 to 1000 ms waits; no per-packet or per-record path changed and nothing in info.pxd is touched. Test plan full compiled test suite after REQUIRE_CYTHON=1 rebuild: 518 passed pre-commit clean four-agent simplify review: reuse, efficiency and altitude clean; the flatter loop shape it proposed was declined since it is the 2009 statement sequence this change retires

Open Graph Description: Summary Restructures the ServiceInfo.async_request polling loop the same way #1888 restructured the registration probe loop: wait-first if/continue shape, a fresh clock read at the top of each cycl...

X Description: Summary Restructures the ServiceInfo.async_request polling loop the same way #1888 restructured the registration probe loop: wait-first if/continue shape, a fresh clock read at the top of each cycl...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1895

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2939ae9b-206f-f6f7-5a78-4953ec3c259f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA486:58BB1:181D6B:219E46:6B00831E
html-safe-nonce1e45e8026523b601eabca7d9d52e76ca1156a027edaaa2826ff1bc7f7eb2c53c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDg2OjU4QkIxOjE4MUQ2QjoyMTlFNDY6NkIwMDgzMUUiLCJ2aXNpdG9yX2lkIjoiMzgyNjgzNDI4Nzk0MDg5NTUxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd6485fedb834fcc35846dddb07c3cb127d98477268194bc3c12e8b72d005e052
hovercard-subject-tagpull_request:4394312459
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1895/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altSummary Restructures the ServiceInfo.async_request polling loop the same way #1888 restructured the registration probe loop: wait-first if/continue shape, a fresh clock read at the top of each cycl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1895%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1895%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
request_pacinghttps://github.com/python-zeroconf/python-zeroconf/tree/request_pacing
Conversation 3 https://github.com/python-zeroconf/python-zeroconf/pull/1895
Commits 1 https://github.com/python-zeroconf/python-zeroconf/pull/1895/commits
Checks 39 https://github.com/python-zeroconf/python-zeroconf/pull/1895/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1895/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files
refactor: compute service info request pacing from fresh clock reads https://github.com/python-zeroconf/python-zeroconf/pull/1895/files#top
Show all changes 1 commit https://github.com/python-zeroconf/python-zeroconf/pull/1895/files
2676b27 refactor: compute service info request pacing from fresh clock reads bdraco Aug 30, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1895/commits/2676b27c5d46fba5468b9170e0f515153e789072
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1895/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files
src/zeroconf/_services/info.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
View file https://github.com/python-zeroconf/python-zeroconf/blob/2676b27c5d46fba5468b9170e0f515153e789072/src/zeroconf/_services/info.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1895/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1895/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1895/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1895/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.