René's URL Explorer Experiment


Title: refactor: compute probe pacing from fresh clock reads by bdraco · Pull Request #1888 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: refactor: compute probe pacing from fresh clock reads by bdraco · Pull Request #1888 · python-zeroconf/python-zeroconf

X Title: refactor: compute probe pacing from fresh clock reads by bdraco · Pull Request #1888 · python-zeroconf/python-zeroconf

Description: Summary Rework the probe pacing loop in async_check_service so the wait arithmetic uses fresh clock reads. The old loop reused a now cached before the previous send, so each probe went out late by the time spent sending, and the counter reset dance across i/now/next_time was hard to follow. Details Probes stay _CHECK_TIME apart on an absolute schedule (next_probe_at += _CHECK_TIME), matching the RFC 6762 section 8.1 probe interval; the wait is now computed against the current clock, so sends land on schedule instead of accumulating per-iteration lag. Behavior is otherwise unchanged: a conflicting cached record still raises NonUniqueNameException or renames and restarts probing from zero, and every wake from async_wait (which record updates notify) re-checks for a conflict before waiting again. The nested conflict while is flattened to an if/continue since the outer loop re-runs the check anyway. Noticed while reviewing this loop during the #1835 audit work; the restructure also retires the last of the 2009-era control flow there. Test plan full compiled test suite (REQUIRE_CYTHON=1 rebuild): 516 passed pre-commit clean

Open Graph Description: Summary Rework the probe pacing loop in async_check_service so the wait arithmetic uses fresh clock reads. The old loop reused a now cached before the previous send, so each probe went out late by ...

X Description: Summary Rework the probe pacing loop in async_check_service so the wait arithmetic uses fresh clock reads. The old loop reused a now cached before the previous send, so each probe went out late by ...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1888

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f477e4ed-9427-a223-e4f5-f8088b81231b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF94:1A5591:19D6A6:22D524:6B00834B
html-safe-nonce16cbf0b1fc250a82938cbedec42ec685e247f7202e379f13ed847ced7d0c09e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjk0OjFBNTU5MToxOUQ2QTY6MjJENTI0OjZCMDA4MzRCIiwidmlzaXRvcl9pZCI6IjExMjAxNDU0MTI2NzAzOTExMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd653d14c29d3581f16b9b874bf43ba657baa19725cb2e984ec6f23ad1ad13779
hovercard-subject-tagpull_request:4393991180
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1888/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altSummary Rework the probe pacing loop in async_check_service so the wait arithmetic uses fresh clock reads. The old loop reused a now cached before the previous send, so each probe went out late by ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1888%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1888%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
probe_pacinghttps://github.com/python-zeroconf/python-zeroconf/tree/probe_pacing
Conversation 3 https://github.com/python-zeroconf/python-zeroconf/pull/1888
Commits 1 https://github.com/python-zeroconf/python-zeroconf/pull/1888/commits
Checks 39 https://github.com/python-zeroconf/python-zeroconf/pull/1888/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1888/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files
refactor: compute probe pacing from fresh clock reads https://github.com/python-zeroconf/python-zeroconf/pull/1888/files#top
Show all changes 1 commit https://github.com/python-zeroconf/python-zeroconf/pull/1888/files
cf5aa99 refactor: compute probe pacing from fresh clock reads bdraco Aug 30, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1888/commits/cf5aa993355d4abc81d06d73de3088ad2e01f46e
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1888/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files
src/zeroconf/_core.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files#diff-334d60456692812966fc9644e6d71b6e2c60dfc6fb2d02d02d5fef6a480c360d
View file https://github.com/python-zeroconf/python-zeroconf/blob/cf5aa993355d4abc81d06d73de3088ad2e01f46e/src/zeroconf/_core.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1888/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1888/files#diff-334d60456692812966fc9644e6d71b6e2c60dfc6fb2d02d02d5fef6a480c360d
https://github.com/python-zeroconf/python-zeroconf/pull/1888/files#diff-334d60456692812966fc9644e6d71b6e2c60dfc6fb2d02d02d5fef6a480c360d
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1888/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.