René's URL Explorer Experiment


Title: fix: correct nsec bitmap semantics and resolve txt denials by bdraco · Pull Request #1825 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: fix: correct nsec bitmap semantics and resolve txt denials by bdraco · Pull Request #1825 · python-zeroconf/python-zeroconf

X Title: fix: correct nsec bitmap semantics and resolve txt denials by bdraco · Pull Request #1825 · python-zeroconf/python-zeroconf

Description: Summary Follow up to #1821. Outgoing NSEC records now follow RFC 6762 §6.1, and ServiceInfo consumes an NSEC that denies the TXT record so async_request resolves promptly instead of burning the full timeout. Details The type bitmap was inverted; we listed the missing address types, but RFC 4034 §4.1.2 and RFC 6762 §6.1 require the types that exist at the name. A real Bonjour capture in test_protocol.py confirms this encoding. The NSEC was owned by the service instance name; address denials now use the server name, matching the A/AAAA question they answer, with next_name set to the record's own name per RFC 6762 §6.1. An NSEC at the service name with the SRV bit set and the TXT bit absent now counts as a TXT denial; the service completes with empty properties, since RFC 6763 §6 requires a TXT record yet some devices deny it instead. Requiring the SRV bit keeps NSECs from older python-zeroconf releases, which carried the inverted bitmap, from being misread as denials. dns_address_nsec() replaces the public dns_nsec(), which produced protocol invalid records; dns_nsec() stays for one release as a deprecated shim that warns, delegates, and ignores missing_types. A service registered without any addresses no longer emits an NSEC; an empty bitmap is not encodable. Out of scope: letting AddressResolver bail early on an address denial, left as a follow up. Test plan poetry run pytest tests passes, 466 passed new tests in tests/services/test_info.py and tests/test_handlers.py cover denial, the legacy bitmap guard, cache loading, and responder output extension builds with REQUIRE_CYTHON=1 under Cython 3.3.0 verified on a live network; a v4 only responder answers an AAAA question with an NSEC owned by the host name listing only A, a crafted no TXT responder resolves immediately with empty properties, and 15 of 15 real LAN services still resolve with their TXT data

Open Graph Description: Summary Follow up to #1821. Outgoing NSEC records now follow RFC 6762 §6.1, and ServiceInfo consumes an NSEC that denies the TXT record so async_request resolves promptly instead of burning the ful...

X Description: Summary Follow up to #1821. Outgoing NSEC records now follow RFC 6762 §6.1, and ServiceInfo consumes an NSEC that denies the TXT record so async_request resolves promptly instead of burning the ful...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1825

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c8f1edb8-3ce3-d62a-c812-d25a523e6509
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE340:1652B0:3945EF:4D137A:6B008A17
html-safe-nonce3af0aade28ebae8bfa4d7481928caa73b27c654d6a3169f395fa3b3db48a2491
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzQwOjE2NTJCMDozOTQ1RUY6NEQxMzdBOjZCMDA4QTE3IiwidmlzaXRvcl9pZCI6IjQ1MzY0MTY1NDY1NjE0OTM1MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca5938c8939ea05baf4e6099e35c57afdeced320e303ad0f63d8812ff0464c15b
hovercard-subject-tagpull_request:4386755881
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1825/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altSummary Follow up to #1821. Outgoing NSEC records now follow RFC 6762 §6.1, and ServiceInfo consumes an NSEC that denies the TXT record so async_request resolves promptly instead of burning the ful...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1825%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1825%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
nsec_supporthttps://github.com/python-zeroconf/python-zeroconf/tree/nsec_support
Conversation 4 https://github.com/python-zeroconf/python-zeroconf/pull/1825
Commits 2 https://github.com/python-zeroconf/python-zeroconf/pull/1825/commits
Checks 36 https://github.com/python-zeroconf/python-zeroconf/pull/1825/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1825/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files
fix: correct nsec bitmap semantics and resolve txt denials https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#top
Show all changes 2 commits https://github.com/python-zeroconf/python-zeroconf/pull/1825/files
7fb0c4f fix: correct nsec bitmap semantics and resolve txt denials bdraco Aug 28, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1825/commits/7fb0c4f938c281cefa145489ccb0365e4db45469
a46dea6 Merge branch 'master' into nsec_support bdraco Aug 28, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1825/commits/a46dea621ab81c505f82163257986468e44950f3
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1825/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files
query_handler.pxd https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
query_handler.py https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-dcb2bcd662da3efbef6d7130df11573195707931c9318ac44e922e54f32c9a25
info.pxd https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
info.py https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
test_info.py https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
test_handlers.py https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-a80edd2ae6b30f0f5a2a8f7bdd4089a43fc5dca4d21588fa4879392950b609f1
src/zeroconf/_handlers/query_handler.pxdhttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
View file https://github.com/python-zeroconf/python-zeroconf/blob/a46dea621ab81c505f82163257986468e44950f3/src/zeroconf/_handlers/query_handler.pxd
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1825/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
src/zeroconf/_handlers/query_handler.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-dcb2bcd662da3efbef6d7130df11573195707931c9318ac44e922e54f32c9a25
View file https://github.com/python-zeroconf/python-zeroconf/blob/a46dea621ab81c505f82163257986468e44950f3/src/zeroconf/_handlers/query_handler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1825/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-dcb2bcd662da3efbef6d7130df11573195707931c9318ac44e922e54f32c9a25
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-dcb2bcd662da3efbef6d7130df11573195707931c9318ac44e922e54f32c9a25
src/zeroconf/_services/info.pxdhttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
View file https://github.com/python-zeroconf/python-zeroconf/blob/a46dea621ab81c505f82163257986468e44950f3/src/zeroconf/_services/info.pxd
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1825/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
src/zeroconf/_services/info.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
View file https://github.com/python-zeroconf/python-zeroconf/blob/a46dea621ab81c505f82163257986468e44950f3/src/zeroconf/_services/info.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1825/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1825/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1825/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.