René's URL Explorer Experiment


Title: fix: require a TXT record before a service is considered complete by bluetoothbot · Pull Request #1821 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: fix: require a TXT record before a service is considered complete by bluetoothbot · Pull Request #1821 · python-zeroconf/python-zeroconf

X Title: fix: require a TXT record before a service is considered complete by bluetoothbot · Pull Request #1821 · python-zeroconf/python-zeroconf

Description: Summary RFC 6763 §6 requires every DNS-SD service to have a TXT record, but ServiceInfo._is_complete guarded on self.text is not None — a condition that never fails, since __init__ seeds self.text = b"". A service that answered with SRV + A/AAAA but no TXT therefore resolved as fully complete. ServiceInfo now tracks whether TXT data has actually been seen, so an empty TXT record still completes the service while a missing one does not (per @bdraco's note on the issue). Closes #1815 Changes ServiceInfo gains a _txt_seen flag (bint in info.pxd), seeded from caller-supplied properties and set when a DNSText record is processed from the network or the cache. _is_complete checks _txt_seen instead of the dead self.text is not None test. AddressResolver{,IPv4,IPv6} override _is_complete and are unaffected. Four tests: no TXT in cache → incomplete; empty TXT → complete with properties == {}; caller-supplied properties → complete; async_request returns False until a TXT record arrives, then True. Two deliberate scoping decisions worth a maintainer's eye: Caller-supplied properties count as TXT data, mirroring how caller-supplied addresses already satisfy the address half of _is_complete. Without this, pre-seeding a ServiceInfo with known data and calling request() to refresh would block for the full timeout. Incoming NSEC records are still not consulted, so a responder that denies TXT via NSEC now burns the request timeout instead of resolving. Handling that properly first needs the rdtype-bitmap semantics sorted out — _get_address_and_nsec_records() puts missing types in the bitmap where RFC 4034 §4.1.2 / RFC 6762 §6.1 put the existing ones — so it is left out of this fix. Test plan poetry run pytest --durations=20 --timeout=60 tests → 451 passed, 2 skipped (no pre-existing tests needed changing). New tests fail on master (assert True is False on the no-TXT cache load) and pass with the fix. ruff, ruff-format, mypy, flake8, codespell, cython-lint pre-commit hooks pass. cython -3 -I src src/zeroconf/_services/info.py transpiles cleanly with the new .pxd declaration (no new warnings). The C compile itself could not be exercised — this sandbox has no Python headers — so CI's wheel build is the real check on that. Quality Report Changes: 3 files changed, 164 insertions(+), 2 deletions(-) Code scan: clean Tests: passed (4 PASSED) Branch hygiene: clean Generated by Kōan

Open Graph Description: Summary RFC 6763 §6 requires every DNS-SD service to have a TXT record, but ServiceInfo._is_complete guarded on self.text is not None — a condition that never fails, since __init__ seeds self.text ...

X Description: Summary RFC 6763 §6 requires every DNS-SD service to have a TXT record, but ServiceInfo._is_complete guarded on self.text is not None — a condition that never fails, since __init__ seeds self.text ...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1821

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c9f18def-7461-437f-7625-a1d298f8484d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE34:27DA74:2B6FEA:3A58E7:6B008748
html-safe-noncec81cafe29bdd56de39f313e9ab1f488a7842ef6bf855c05075e62f714959db0d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTM0OjI3REE3NDoyQjZGRUE6M0E1OEU3OjZCMDA4NzQ4IiwidmlzaXRvcl9pZCI6IjczODc0NDk4NTgwODIyNDQ0MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac81acd4e520759305cf1a69edbe5ea83f589210541d446de3f9d2206f233bf3f3
hovercard-subject-tagpull_request:4368481991
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1821/files
twitter:imagehttps://avatars.githubusercontent.com/u/284751220?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/284751220?s=400&v=4
og:image:altSummary RFC 6763 §6 requires every DNS-SD service to have a TXT record, but ServiceInfo._is_complete guarded on self.text is not None — a condition that never fails, since __init__ seeds self.text ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1821%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1821%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bluetoothbot:koan/fix-issue-1815https://github.com/bluetoothbot/python-zeroconf/tree/koan/fix-issue-1815
Conversation 13 https://github.com/python-zeroconf/python-zeroconf/pull/1821
Commits 7 https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits
Checks 36 https://github.com/python-zeroconf/python-zeroconf/pull/1821/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1821/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files
fix: require a TXT record before a service is considered complete https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#top
Show all changes 7 commits https://github.com/python-zeroconf/python-zeroconf/pull/1821/files
4e33c3c fix: require a TXT record before a service is considered complete bluetoothbot Aug 26, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/4e33c3c11d9bc90e8410d7c77c8cb70421530d86
2f89138 fix: treat caller-supplied empty properties as a seen TXT record bluetoothbot Aug 26, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/2f89138020a4b6d0140405a44682dcad13b69948
38a9f79 docs: document that omitting properties means the TXT record is unknown bluetoothbot Aug 26, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/38a9f79eed063c1bf829cc376d46ada015d6213d
844a466 build: pin cython below 3.3 to fix extension build bluetoothbot Aug 26, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/844a46666c3aa34198d9a40c1a5d1bcfbaf533de
3e7eea6 fix: resolve CI failures on #1821 (attempt 1) bluetoothbot Aug 26, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/3e7eea60d8eb0fc89c412c0214ec86341a10c187
6005da0 fix: drop unrelated cython pin and ci rework, cover empty text seeding bluetoothbot Aug 28, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/6005da0c758f3717ed6e576d8952e29aa0390231
7f2bec6 docs: note that assigning text directly does not mark txt as seen bluetoothbot Aug 28, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/7f2bec62b5e00969753236239680beaf53729f34
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1821/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files
info.pxd https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
info.py https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
test_info.py https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
src/zeroconf/_services/info.pxdhttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
View file https://github.com/bluetoothbot/python-zeroconf/blob/7f2bec62b5e00969753236239680beaf53729f34/src/zeroconf/_services/info.pxd
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1821/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
src/zeroconf/_services/info.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
View file https://github.com/bluetoothbot/python-zeroconf/blob/7f2bec62b5e00969753236239680beaf53729f34/src/zeroconf/_services/info.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1821/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
tests/services/test_info.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
View file https://github.com/bluetoothbot/python-zeroconf/blob/7f2bec62b5e00969753236239680beaf53729f34/tests/services/test_info.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1821/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1821/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1821/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.