| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:6bac6625-5277-fcb1-a778-aa15995cc2e8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E21A:CD50A:23AD71:31A0FB:6B008765 |
| html-safe-nonce | 947dd50075b19a87dbfcb4c6bba18e9804d8f6127aba26969706b019f01e7974 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjFBOkNENTBBOjIzQUQ3MTozMUEwRkI6NkIwMDg3NjUiLCJ2aXNpdG9yX2lkIjoiNDgyMzc0NjE0NzgxMjE0OTA5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b0ff0ea14383debb56e8d2ffc6ba8a12cb19b9cfc5e03c030db59d4f979fe45c |
| hovercard-subject-tag | pull_request:4368481991 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits |
| twitter:image | https://opengraph.githubassets.com/bfa6c1f42ac2bcc4f9b7719bbf104ed7eeb721cf97722cdf02fcfa1a53882b85/python-zeroconf/python-zeroconf/pull/1821 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bfa6c1f42ac2bcc4f9b7719bbf104ed7eeb721cf97722cdf02fcfa1a53882b85/python-zeroconf/python-zeroconf/pull/1821 |
| og:image:alt | Summary
RFC 6763 §6 requires every DNS-SD service to have a TXT record, but ServiceInfo._is_complete guarded on self.text is not None — a condition that never fails, since __init__ seeds self.text ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bluetoothbot |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git |
| octolytics-dimension-user_id | 120192235 |
| octolytics-dimension-user_login | python-zeroconf |
| octolytics-dimension-repository_id | 21548731 |
| octolytics-dimension-repository_nwo | python-zeroconf/python-zeroconf |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21548731 |
| octolytics-dimension-repository_network_root_nwo | python-zeroconf/python-zeroconf |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | db758f8e02b8257935fb03edf81a3e76eb3abd11 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1821%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1821%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf |
| Reload | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits |
| Reload | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits |
| Reload | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits |
| python-zeroconf | https://github.com/python-zeroconf |
| python-zeroconf | https://github.com/python-zeroconf/python-zeroconf |
| Code | https://github.com/python-zeroconf/python-zeroconf |
| Issues50 (50) | https://github.com/python-zeroconf/python-zeroconf/issues |
| Pull requests16 (16) | https://github.com/python-zeroconf/python-zeroconf/pulls |
| Discussions | https://github.com/python-zeroconf/python-zeroconf/discussions |
| Actions | https://github.com/python-zeroconf/python-zeroconf/actions |
| Projects | https://github.com/python-zeroconf/python-zeroconf/projects |
| Wiki | https://github.com/python-zeroconf/python-zeroconf/wiki |
| Security and quality5 (5) | https://github.com/python-zeroconf/python-zeroconf/security |
| Insights | https://github.com/python-zeroconf/python-zeroconf/insights |
| https://github.com/python-zeroconf/python-zeroconf |
| bdraco | https://github.com/bdraco |
| python-zeroconf:master | https://github.com/python-zeroconf/python-zeroconf/tree/master |
| bluetoothbot:koan/fix-issue-1815 | https://github.com/bluetoothbot/python-zeroconf/tree/koan/fix-issue-1815 |
| Conversation | https://github.com/python-zeroconf/python-zeroconf/pull/1821 |
| Commits7 (7) | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits |
| Checks | https://github.com/python-zeroconf/python-zeroconf/pull/1821/checks |
| Files changed | https://github.com/python-zeroconf/python-zeroconf/pull/1821/files |
| fix: require a TXT record before a service is considered complete | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits#top |
| bdraco | https://github.com/bdraco |
| python-zeroconf:master | https://github.com/python-zeroconf/python-zeroconf/tree/master |
| bluetoothbot:koan/fix-issue-1815 | https://github.com/bluetoothbot/python-zeroconf/tree/koan/fix-issue-1815 |
| fix: require a TXT record before a service is considered complete | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/4e33c3c11d9bc90e8410d7c77c8cb70421530d86 |
| https://github.com/bluetoothbot |
| bluetoothbot | https://github.com/python-zeroconf/python-zeroconf/commits?author=bluetoothbot |
| 4e33c3c | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/4e33c3c11d9bc90e8410d7c77c8cb70421530d86 |
| https://github.com/python-zeroconf/python-zeroconf/tree/4e33c3c11d9bc90e8410d7c77c8cb70421530d86 |
| fix: treat caller-supplied empty properties as a seen TXT record | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/2f89138020a4b6d0140405a44682dcad13b69948 |
| https://github.com/bluetoothbot |
| bluetoothbot | https://github.com/python-zeroconf/python-zeroconf/commits?author=bluetoothbot |
| 2f89138 | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/2f89138020a4b6d0140405a44682dcad13b69948 |
| https://github.com/python-zeroconf/python-zeroconf/tree/2f89138020a4b6d0140405a44682dcad13b69948 |
| docs: document that omitting properties means the TXT record is unknown | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/38a9f79eed063c1bf829cc376d46ada015d6213d |
| https://github.com/bluetoothbot |
| bluetoothbot | https://github.com/python-zeroconf/python-zeroconf/commits?author=bluetoothbot |
| 38a9f79 | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/38a9f79eed063c1bf829cc376d46ada015d6213d |
| https://github.com/python-zeroconf/python-zeroconf/tree/38a9f79eed063c1bf829cc376d46ada015d6213d |
| build: pin cython below 3.3 to fix extension build | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/844a46666c3aa34198d9a40c1a5d1bcfbaf533de |
| https://github.com/bluetoothbot |
| bluetoothbot | https://github.com/python-zeroconf/python-zeroconf/commits?author=bluetoothbot |
| 844a466 | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/844a46666c3aa34198d9a40c1a5d1bcfbaf533de |
| https://github.com/python-zeroconf/python-zeroconf/tree/844a46666c3aa34198d9a40c1a5d1bcfbaf533de |
| fix: resolve CI failures on #1821 (attempt 1) | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/3e7eea60d8eb0fc89c412c0214ec86341a10c187 |
| https://github.com/bluetoothbot |
| bluetoothbot | https://github.com/python-zeroconf/python-zeroconf/commits?author=bluetoothbot |
| 3e7eea6 | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/3e7eea60d8eb0fc89c412c0214ec86341a10c187 |
| https://github.com/python-zeroconf/python-zeroconf/tree/3e7eea60d8eb0fc89c412c0214ec86341a10c187 |
| fix: drop unrelated cython pin and ci rework, cover empty text seeding | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/6005da0c758f3717ed6e576d8952e29aa0390231 |
| https://github.com/bluetoothbot |
| bluetoothbot | https://github.com/python-zeroconf/python-zeroconf/commits?author=bluetoothbot |
| 6005da0 | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/6005da0c758f3717ed6e576d8952e29aa0390231 |
| https://github.com/python-zeroconf/python-zeroconf/tree/6005da0c758f3717ed6e576d8952e29aa0390231 |
| docs: note that assigning text directly does not mark txt as seen | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/7f2bec62b5e00969753236239680beaf53729f34 |
| https://github.com/bluetoothbot |
| bluetoothbot | https://github.com/python-zeroconf/python-zeroconf/commits?author=bluetoothbot |
| 7f2bec6 | https://github.com/python-zeroconf/python-zeroconf/pull/1821/commits/7f2bec62b5e00969753236239680beaf53729f34 |
| https://github.com/python-zeroconf/python-zeroconf/tree/7f2bec62b5e00969753236239680beaf53729f34 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |