René's URL Explorer Experiment


Title: fix: tolerate removing unregistered record listener by bluetoothbot · Pull Request #1783 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: fix: tolerate removing unregistered record listener by bluetoothbot · Pull Request #1783 · python-zeroconf/python-zeroconf

X Title: fix: tolerate removing unregistered record listener by bluetoothbot · Pull Request #1783 · python-zeroconf/python-zeroconf

Description: What Switch RecordManager.async_remove_listener from set.remove() + except ValueError to set.discard(), so removing a listener that was never registered no longer raises. Why self.listeners is a set, so .remove(listener) raises KeyError on a missing element — not ValueError. The existing except ValueError clause could not catch the only realistic failure mode of that line, so the documented "log and continue" intent was effectively dead code. A teardown / reconnect path that double-removes a listener propagates KeyError out of Zeroconf.async_remove_listener and breaks the surrounding shutdown. How Use set.discard() (the set-native "remove if present" idiom) gated by if listener in self.listeners, so async_notify_all() only fires when something actually changed. The try / except is gone. Testing Added tests/test_handlers.py::test_async_remove_listener_missing_does_not_raise in a separate commit against the unfixed code first, so the before/after is explicit. Full suite (SKIP_CYTHON=1 pytest): 393 passed. Quality Report Changes: 2 files changed, 16 insertions(+), 4 deletions(-) Code scan: clean Tests: passed (4 PASSED) Branch hygiene: clean Generated by Kōan post-mission quality pipeline

Open Graph Description: What Switch RecordManager.async_remove_listener from set.remove() + except ValueError to set.discard(), so removing a listener that was never registered no longer raises. Why self.listeners is a se...

X Description: What Switch RecordManager.async_remove_listener from set.remove() + except ValueError to set.discard(), so removing a listener that was never registered no longer raises. Why self.listeners is a se...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1783

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a2baf6cd-5b3e-0971-d615-f7d0f26c0dab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96BA:FA1B4:D2AF3:124D4E:6B008039
html-safe-nonce455ba34a15e9cf9e8011a6bddb9bfa82e56147c9a82e98a9ed6cc0fc67c16025
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkJBOkZBMUI0OkQyQUYzOjEyNEQ0RTo2QjAwODAzOSIsInZpc2l0b3JfaWQiOiI3MzA1Mzg1OTE3OTU3NTcwNjE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3777592c92932a4d8f21bf7d3b974ad9a0f2be71bd171ac1c6c3c6c31b7b7da3
hovercard-subject-tagpull_request:3749676994
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1783/files
twitter:imagehttps://avatars.githubusercontent.com/u/284751220?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/284751220?s=400&v=4
og:image:altWhat Switch RecordManager.async_remove_listener from set.remove() + except ValueError to set.discard(), so removing a listener that was never registered no longer raises. Why self.listeners is a se...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None82c186f13e104004ab7bdb779f3195e59dd38bfde531aaa74b76470fc2462b83
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1bc2aa1939001689f5ce935982c10a6138f745c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1783%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1783%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bluetoothbothttps://github.com/bluetoothbot
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bluetoothbot:koan/fix-remove-listener-keyerrorhttps://github.com/bluetoothbot/python-zeroconf/tree/koan/fix-remove-listener-keyerror
Conversation 5 https://github.com/python-zeroconf/python-zeroconf/pull/1783
Commits 2 https://github.com/python-zeroconf/python-zeroconf/pull/1783/commits
Checks 35 https://github.com/python-zeroconf/python-zeroconf/pull/1783/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1783/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files
fix: tolerate removing unregistered record listener https://github.com/python-zeroconf/python-zeroconf/pull/1783/files#top
Show all changes 2 commits https://github.com/python-zeroconf/python-zeroconf/pull/1783/files
cd765e8 test: pin async_remove_listener tolerance of unregistered listener bluetoothbot May 26, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1783/commits/cd765e8fdf53dd6ebd9aeaf3174614c237d45231
fbed0b8 fix: tolerate removing unregistered listener (GHSA-5pv9-xcmm-gqc7) bluetoothbot May 26, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1783/commits/fbed0b869665cbbc50411cf89d4bbf2f7f1ee72d
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1783/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files
record_manager.py https://github.com/python-zeroconf/python-zeroconf/pull/1783/files#diff-f1737ce73cad1a974e837532d241813eeebb0234d27116449fd8d7a79df494f6
test_handlers.py https://github.com/python-zeroconf/python-zeroconf/pull/1783/files#diff-a80edd2ae6b30f0f5a2a8f7bdd4089a43fc5dca4d21588fa4879392950b609f1
src/zeroconf/_handlers/record_manager.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files#diff-f1737ce73cad1a974e837532d241813eeebb0234d27116449fd8d7a79df494f6
View file https://github.com/python-zeroconf/python-zeroconf/blob/fbed0b869665cbbc50411cf89d4bbf2f7f1ee72d/src/zeroconf/_handlers/record_manager.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1783/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1783/files#diff-f1737ce73cad1a974e837532d241813eeebb0234d27116449fd8d7a79df494f6
tests/test_handlers.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files#diff-a80edd2ae6b30f0f5a2a8f7bdd4089a43fc5dca4d21588fa4879392950b609f1
View file https://github.com/python-zeroconf/python-zeroconf/blob/fbed0b869665cbbc50411cf89d4bbf2f7f1ee72d/tests/test_handlers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1783/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1783/files#diff-a80edd2ae6b30f0f5a2a8f7bdd4089a43fc5dca4d21588fa4879392950b609f1
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1783/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.