René's URL Explorer Experiment


Title: fix: preserve scope_id when scoped AAAA arrives alongside unscoped by bluetoothbot · Pull Request #1764 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: fix: preserve scope_id when scoped AAAA arrives alongside unscoped by bluetoothbot · Pull Request #1764 · python-zeroconf/python-zeroconf

X Title: fix: preserve scope_id when scoped AAAA arrives alongside unscoped by bluetoothbot · Pull Request #1764 · python-zeroconf/python-zeroconf

Description: Summary ServiceInfo.parsed_scoped_addresses() is documented to qualify link-local IPv6 addresses with % when available, but the qualifier was being dropped when the same AAAA arrived as two records — once via the IPv4 listener (no scope captured) and once via the IPv6 listener (scope from the receiving socket). The cache stored both records as distinct entries (DNSAddress equality includes scope_id), so dedup at the ServiceInfo layer either kept both copies side-by-side or, depending on arrival order, silently chose the unscoped one. Match addresses on their packed integer (zc_integer, scope-agnostic) when collapsing duplicates in _get_ip_addresses_from_cache_lifo and _process_record_threadsafe, and prefer whichever variant carries a scope_id. The fix is local to the ServiceInfo layer — DNS records remain hashed by scope_id so the cache still distinguishes them — and addresses the dedup half of #1567 without touching socket setup. The complementary work for the IPv4-only-arrival case (per-interface sockets or IP_PKTINFO) remains for a follow-up. Fixes #1567 Changes Add _index_of_same_address / _has_more_scope_info helpers that compare addresses ignoring scope_id and tell whether a new record carries scope info the stored variant lacks. Rewrite the cache-LIFO and live-update paths in ServiceInfo so a later-arriving scoped AAAA upgrades the stored entry instead of being deduped away (or appended as a duplicate). Extract the AAAA-add branch of _process_record_threadsafe into _upsert_ipv6_address, declared in info.pxd. Test plan New test_scoped_address_preferred_when_unscoped_arrives_first_in_cache — both variants cached, parsed_scoped_addresses() returns the %-qualified form only. New test_scoped_address_replaces_unscoped_in_live_update — exercises async_update_records with unscoped-then-scoped arrival order. SKIP_CYTHON=1 poetry run pytest tests --timeout=60 → 391 passed, 2 skipped. Generated by Kōan /fix Quality Report Changes: 3 files changed, 159 insertions(+), 14 deletions(-) Code scan: clean Tests: passed (4 PASSED) Branch hygiene: clean Generated by Kōan post-mission quality pipeline

Open Graph Description: Summary ServiceInfo.parsed_scoped_addresses() is documented to qualify link-local IPv6 addresses with %<interface_index> when available, but the qualifier was being dropped when the same AAAA...

X Description: Summary ServiceInfo.parsed_scoped_addresses() is documented to qualify link-local IPv6 addresses with %&lt;interface_index&gt; when available, but the qualifier was being dropped when the s...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1764

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3ad8683c-3348-7713-c1ad-96c582bf1682
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC22:950C5:2FAAA5:40A58D:6B00833B
html-safe-nonce222c89441d77fd176b3a23df0c50a4b100be8624b9e7aa5064591a3267756514
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzIyOjk1MEM1OjJGQUFBNTo0MEE1OEQ6NkIwMDgzM0IiLCJ2aXNpdG9yX2lkIjoiODA2OTgxMjExNzIxOTM0NTIxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1028f96470b0478ef087424cb318b74cce3ed6bfb71efd0e27dae359da8e79c1
hovercard-subject-tagpull_request:3719123923
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1764/files
twitter:imagehttps://avatars.githubusercontent.com/u/284751220?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/284751220?s=400&v=4
og:image:altSummary ServiceInfo.parsed_scoped_addresses() is documented to qualify link-local IPv6 addresses with %<interface_index> when available, but the qualifier was being dropped when the same AAAA...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1764%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1764%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bluetoothbot:koan/fix-issue-1567https://github.com/bluetoothbot/python-zeroconf/tree/koan/fix-issue-1567
Conversation 10 https://github.com/python-zeroconf/python-zeroconf/pull/1764
Commits 3 https://github.com/python-zeroconf/python-zeroconf/pull/1764/commits
Checks 35 https://github.com/python-zeroconf/python-zeroconf/pull/1764/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1764/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files
fix: preserve scope_id when scoped AAAA arrives alongside unscoped https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#top
Show all changes 3 commits https://github.com/python-zeroconf/python-zeroconf/pull/1764/files
28cffed fix: preserve scope_id when scoped AAAA arrives alongside unscoped bluetoothbot May 20, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1764/commits/28cffedb01622ab08443803d4be8cbc86543414f
9f8182b test: cover scope_id ipv6 dedupe partial branches bdraco May 20, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1764/commits/9f8182bdb8e0ec04bfc077f96747aa228c7bcedf
8c356dd fix: preserve lifo recency when scope upgrade replaces an entry bdraco May 20, 2026 https://github.com/python-zeroconf/python-zeroconf/pull/1764/commits/8c356ddd3778c766dbfe520ba767bed9d07f1c54
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1764/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files
info.pxd https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
info.py https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
test_info.py https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
src/zeroconf/_services/info.pxdhttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
View file https://github.com/bluetoothbot/python-zeroconf/blob/8c356ddd3778c766dbfe520ba767bed9d07f1c54/src/zeroconf/_services/info.pxd
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1764/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-58f57e2931f03dd0eeb142a137a62905a24fd9b73dff07672becad788b17a5ba
src/zeroconf/_services/info.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
View file https://github.com/bluetoothbot/python-zeroconf/blob/8c356ddd3778c766dbfe520ba767bed9d07f1c54/src/zeroconf/_services/info.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1764/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-1d9147eb9baf7756138dfa891475affa18bbe55d565efca5b039f301ab045fa4
tests/services/test_info.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
View file https://github.com/bluetoothbot/python-zeroconf/blob/8c356ddd3778c766dbfe520ba767bed9d07f1c54/tests/services/test_info.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1764/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
https://github.com/python-zeroconf/python-zeroconf/pull/1764/files#diff-60efc1967b54eee765e08a9d13b2acd7ebe19a0908157973d68cf847ec849205
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1764/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.