René's URL Explorer Experiment


Title: fix: correctly override question type flag for requests by agners · Pull Request #1558 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: fix: correctly override question type flag for requests by agners · Pull Request #1558 · python-zeroconf/python-zeroconf

X Title: fix: correctly override question type flag for requests by agners · Pull Request #1558 · python-zeroconf/python-zeroconf

Description: Currently even when setting the explicit question type flag, the implementation ignores it for subsequent queries. This commit ensures that all queries respect the explicit question type flag.

Open Graph Description: Currently even when setting the explicit question type flag, the implementation ignores it for subsequent queries. This commit ensures that all queries respect the explicit question type flag.

X Description: Currently even when setting the explicit question type flag, the implementation ignores it for subsequent queries. This commit ensures that all queries respect the explicit question type flag.

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1558

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f781b066-e60a-1432-72da-800762fc4b19
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id976E:10B1FA:274AE2:37B2A7:69724219
html-safe-nonce2a2823c9378490e83a7605fc864416b26dde2dfc3207d3afc80925fa6ce06519
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzZFOjEwQjFGQToyNzRBRTI6MzdCMkE3OjY5NzI0MjE5IiwidmlzaXRvcl9pZCI6IjI0Mjk2MjQwMTg3MzUxMDkzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc0bfd8ecd5ad75c07f5603ac463972ffa477ea67d2fb2ef62a2fb26524a14ac9
hovercard-subject-tagpull_request:2434407070
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-zeroconf/python-zeroconf/1558/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8a3fd9362ba406347adae2e4857a8aa10aca81eb32d1670420ad7903dc539fea/python-zeroconf/python-zeroconf/pull/1558
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8a3fd9362ba406347adae2e4857a8aa10aca81eb32d1670420ad7903dc539fea/python-zeroconf/python-zeroconf/pull/1558
og:image:altCurrently even when setting the explicit question type flag, the implementation ignores it for subsequent queries. This commit ensures that all queries respect the explicit question type flag.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameagners
hostnamegithub.com
expected-hostnamegithub.com
None2c16db4e575031f6e3be03e0437c1ab663e0b4643ba5cbbfba48c1e4fc056a11
turbo-cache-controlno-preview
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release584fea6daacd0ba6f8dbec869937910ee0ae2e64
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1558#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1558
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1558
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1558
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1558
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1558
python-zeroconf https://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Notifications https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Fork 232 https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Star 704 https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Code https://github.com/python-zeroconf/python-zeroconf
Issues 50 https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests 5 https://github.com/python-zeroconf/python-zeroconf/pulls
Discussions https://github.com/python-zeroconf/python-zeroconf/discussions
Actions https://github.com/python-zeroconf/python-zeroconf/actions
Projects 0 https://github.com/python-zeroconf/python-zeroconf/projects
Wiki https://github.com/python-zeroconf/python-zeroconf/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python-zeroconf/python-zeroconf/security
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
Insights https://github.com/python-zeroconf/python-zeroconf/pulse
Code https://github.com/python-zeroconf/python-zeroconf
Issues https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests https://github.com/python-zeroconf/python-zeroconf/pulls
Discussions https://github.com/python-zeroconf/python-zeroconf/discussions
Actions https://github.com/python-zeroconf/python-zeroconf/actions
Projects https://github.com/python-zeroconf/python-zeroconf/projects
Wiki https://github.com/python-zeroconf/python-zeroconf/wiki
Security https://github.com/python-zeroconf/python-zeroconf/security
Insights https://github.com/python-zeroconf/python-zeroconf/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-zeroconf/python-zeroconf/pull/1558#issue-comment-box
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
agners:fix-explicit-question-type-flaghttps://github.com/agners/python-zeroconf/tree/fix-explicit-question-type-flag
fix: correctly override question type flag for requests https://github.com/python-zeroconf/python-zeroconf/pull/1558#top
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
agners:fix-explicit-question-type-flaghttps://github.com/agners/python-zeroconf/tree/fix-explicit-question-type-flag
Conversation 4 https://github.com/python-zeroconf/python-zeroconf/pull/1558
Commits 2 https://github.com/python-zeroconf/python-zeroconf/pull/1558/commits
Checks 33 https://github.com/python-zeroconf/python-zeroconf/pull/1558/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1558/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/{{ revealButtonHref }}
https://github.com/agners
agnershttps://github.com/agners
Apr 2, 2025https://github.com/python-zeroconf/python-zeroconf/pull/1558#issue-2966619382
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
https://github.com/agners
fix: correctly override question type flag for requestshttps://github.com/python-zeroconf/python-zeroconf/pull/1558/commits/0d3dcff526e16d47f8a005cb4da39188225fecce
0d3dcffhttps://github.com/python-zeroconf/python-zeroconf/pull/1558/commits/0d3dcff526e16d47f8a005cb4da39188225fecce
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 2, 2025https://github.com/python-zeroconf/python-zeroconf/pull/1558#issuecomment-2772808566
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
Codecovhttps://app.codecov.io/gh/python-zeroconf/python-zeroconf/pull/1558?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
(b757ddf)https://app.codecov.io/gh/python-zeroconf/python-zeroconf/commit/b757ddf98d7d04c366281a4281a449c5c2cb897d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
(4d5dfa4)https://app.codecov.io/gh/python-zeroconf/python-zeroconf/commit/4d5dfa423eab68b61aba4df58663fb07cda28bc0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/python-zeroconf/python-zeroconf/pull/1558?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
https://github.com/agners
agnershttps://github.com/agners
Apr 2, 2025https://github.com/python-zeroconf/python-zeroconf/pull/1558#issuecomment-2772808567
#852https://github.com/python-zeroconf/python-zeroconf/pull/852
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
https://github.com/apps/codspeed-hq
codspeed-hqhttps://github.com/apps/codspeed-hq
Apr 2, 2025https://github.com/python-zeroconf/python-zeroconf/pull/1558#issuecomment-2772810183
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
CodSpeed Performance Reporthttps://codspeed.io/python-zeroconf/python-zeroconf/branches/agners%3Afix-explicit-question-type-flag
#1558https://github.com/python-zeroconf/python-zeroconf/pull/1558
4d5dfa4https://github.com/python-zeroconf/python-zeroconf/commit/4d5dfa423eab68b61aba4df58663fb07cda28bc0
b757ddfhttps://github.com/python-zeroconf/python-zeroconf/commit/b757ddf98d7d04c366281a4281a449c5c2cb897d
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
https://github.com/agners
chore(tests): add test for explicit question type flaghttps://github.com/python-zeroconf/python-zeroconf/pull/1558/commits/4d5dfa423eab68b61aba4df58663fb07cda28bc0
4d5dfa4https://github.com/python-zeroconf/python-zeroconf/pull/1558/commits/4d5dfa423eab68b61aba4df58663fb07cda28bc0
https://github.com/agners
agnershttps://github.com/agners
force-pushedhttps://github.com/python-zeroconf/python-zeroconf/compare/b419f329b3e8a1973fa03faeeb18407b86851032..4d5dfa423eab68b61aba4df58663fb07cda28bc0
b419f32https://github.com/python-zeroconf/python-zeroconf/commit/b419f329b3e8a1973fa03faeeb18407b86851032
4d5dfa4https://github.com/python-zeroconf/python-zeroconf/commit/4d5dfa423eab68b61aba4df58663fb07cda28bc0
Compare https://github.com/python-zeroconf/python-zeroconf/compare/b419f329b3e8a1973fa03faeeb18407b86851032..4d5dfa423eab68b61aba4df58663fb07cda28bc0
April 2, 2025 14:56https://github.com/python-zeroconf/python-zeroconf/pull/1558#event-17095689492
https://github.com/agners
agnershttps://github.com/agners
had a problem deployinghttps://github.com/python-zeroconf/python-zeroconf/actions/runs/14222815340/job/39855536038
April 2, 2025 15:05https://github.com/python-zeroconf/python-zeroconf/pull/1558#event-17095889753
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/bdraco
bdracohttps://github.com/bdraco
Apr 2, 2025 https://github.com/python-zeroconf/python-zeroconf/pull/1558#pullrequestreview-2737081645
View reviewed changes https://github.com/python-zeroconf/python-zeroconf/pull/1558/files/4d5dfa423eab68b61aba4df58663fb07cda28bc0
https://github.com/bdraco
bdracohttps://github.com/bdraco
Apr 2, 2025https://github.com/python-zeroconf/python-zeroconf/pull/1558#issuecomment-2773278014
@agnershttps://github.com/agners
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
https://github.com/bdraco
bdracohttps://github.com/bdraco
bd643a2https://github.com/python-zeroconf/python-zeroconf/commit/bd643a227bc4d6a949d558850ad1431bc2940d74
Apr 2, 2025https://github.com/python-zeroconf/python-zeroconf/pull/1558#event-17098397506
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1558
https://github.com/bdraco
bdraco https://github.com/bdraco
https://github.com/python-zeroconf/python-zeroconf/pull/1558/files/4d5dfa423eab68b61aba4df58663fb07cda28bc0
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1558
https://github.com/agners
https://github.com/bdraco
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.