René's URL Explorer Experiment


Title: fix: scheduling race with the QueryScheduler by bdraco · Pull Request #1347 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: fix: scheduling race with the QueryScheduler by bdraco · Pull Request #1347 · python-zeroconf/python-zeroconf

X Title: fix: scheduling race with the QueryScheduler by bdraco · Pull Request #1347 · python-zeroconf/python-zeroconf

Description: We should always call reschedule instead of schedule in case one is already scheduled. The code assumed records are always delivered in order which would be nice, but does not reflect a real network

Open Graph Description: We should always call reschedule instead of schedule in case one is already scheduled. The code assumed records are always delivered in order which would be nice, but does not reflect a real network

X Description: We should always call reschedule instead of schedule in case one is already scheduled. The code assumed records are always delivered in order which would be nice, but does not reflect a real network

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1347

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dc98eacf-b819-bfd7-613a-cbab10f45791
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8198:172B92:12A26:19E09:6B00B708
html-safe-nonce27422cb8b1f3467d6b2e10083718012ac012734ae3fe23ab8efd6970122f7d2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTk4OjE3MkI5MjoxMkEyNjoxOUUwOTo2QjAwQjcwOCIsInZpc2l0b3JfaWQiOiIzNDA0NzgyMDI1MTU1MDY1NjA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac26a8836fbd2c851e862cbb04f35a185b81500639cb0deea223c42244323d8011
hovercard-subject-tagpull_request:1646789548
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1347/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altWe should always call reschedule instead of schedule in case one is already scheduled. The code assumed records are always delivered in order which would be nice, but does not reflect a real network
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1347%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1347%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
heappop_fixhttps://github.com/python-zeroconf/python-zeroconf/tree/heappop_fix
Conversation 1 https://github.com/python-zeroconf/python-zeroconf/pull/1347
Commits 8 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/1347/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1347/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files
fix: scheduling race with the QueryScheduler https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#top
Show all changes 8 commits https://github.com/python-zeroconf/python-zeroconf/pull/1347/files
c40a73b fix: ensure correct scheduled query is removed from the heap with the… bdraco Dec 16, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/c40a73b48ee422e44406feb695c12bfe6c2d4e4c
f0fc8df Merge branch 'master' into heappop_fix bdraco Dec 16, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/f0fc8df62baa18f17a2b6c3843e71d6669e7c0af
54ce2d4 fix: ensure correct scheduled query is removed from the heap with the… bdraco Dec 16, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/54ce2d4d6c07d5b95533b6f14aade2b95090fe08
76b5aaf Merge remote-tracking branch 'origin/heappop_fix' into heappop_fix bdraco Dec 16, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/76b5aaf0ca06dff81e66649482c3274e2b23503a
6bc9d05 fix: ensure correct scheduled query is removed from the heap with the… bdraco Dec 16, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/6bc9d05aeb0912c577a5668d5eb11b9edd4d8813
94892fe fix: always reschedule since records can get added twice due to race bdraco Dec 16, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/94892fe5f5e9bdf7602f6d54f16527bf1bae1af4
3e8334d fix: name bdraco Dec 16, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/3e8334d7b8e02c8bbbab256fad2cd6b40c246ce8
bd99f29 fix: remove now unreachable code bdraco Dec 16, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/bd99f29af91c31ee9981db66d8b225d79a9bb828
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1347/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files
browser.pxd https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-aabf7d8f738b32d602b33d74c0df402d2a953f7f8e280cff18011fab08db4a06
browser.py https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
test_browser.py https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
src/zeroconf/_services/browser.pxdhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-aabf7d8f738b32d602b33d74c0df402d2a953f7f8e280cff18011fab08db4a06
View file https://github.com/python-zeroconf/python-zeroconf/blob/bd99f29af91c31ee9981db66d8b225d79a9bb828/src/zeroconf/_services/browser.pxd
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1347/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-aabf7d8f738b32d602b33d74c0df402d2a953f7f8e280cff18011fab08db4a06
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-aabf7d8f738b32d602b33d74c0df402d2a953f7f8e280cff18011fab08db4a06
src/zeroconf/_services/browser.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
View file https://github.com/python-zeroconf/python-zeroconf/blob/bd99f29af91c31ee9981db66d8b225d79a9bb828/src/zeroconf/_services/browser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1347/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-03d8923ed2332d5f0754a33b811ff1e11b95c782e3e2832871c5f473df71aad7
tests/services/test_browser.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
View file https://github.com/python-zeroconf/python-zeroconf/blob/bd99f29af91c31ee9981db66d8b225d79a9bb828/tests/services/test_browser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1347/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/1347/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.