René's URL Explorer Experiment


Title: fix: scheduling race with the QueryScheduler by bdraco · Pull Request #1347 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: fix: scheduling race with the QueryScheduler by bdraco · Pull Request #1347 · python-zeroconf/python-zeroconf

X Title: fix: scheduling race with the QueryScheduler by bdraco · Pull Request #1347 · python-zeroconf/python-zeroconf

Description: A pure python implementation of multicast DNS service discovery - fix: scheduling race with the QueryScheduler by bdraco · Pull Request #1347 · python-zeroconf/python-zeroconf

Open Graph Description: We should always call reschedule instead of schedule in case one is already scheduled. The code assumed records are always delivered in order which would be nice, but does not reflect a real network

X Description: We should always call reschedule instead of schedule in case one is already scheduled. The code assumed records are always delivered in order which would be nice, but does not reflect a real network

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1347

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a2d44f33-7950-f451-07a3-fba307e6d985
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8BE:3C5B89:3425F4:476B7D:6B00B46A
html-safe-nonce9cbb513d74325c848c6899f9d6cda7b10b873e1ade197f3605a09e7c3abb24e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEJFOjNDNUI4OTozNDI1RjQ6NDc2QjdEOjZCMDBCNDZBIiwidmlzaXRvcl9pZCI6IjY3MDIyMjU2MzAzMDc1OTUzNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac24a2071dfa28513d85121af5b00207b823cade63a99777c783ed69a184de4a1f
hovercard-subject-tagpull_request:1646789548
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-zeroconf/python-zeroconf/1347/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bd55771814f3b34eee9ca6457fc1753c10c91786799bccddf259fc970f72b931/python-zeroconf/python-zeroconf/pull/1347
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd55771814f3b34eee9ca6457fc1753c10c91786799bccddf259fc970f72b931/python-zeroconf/python-zeroconf/pull/1347
og:image:altWe should always call reschedule instead of schedule in case one is already scheduled. The code assumed records are always delivered in order which would be nice, but does not reflect a real network
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebdraco
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-cache
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1347#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1347
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1347
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1347
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1347
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1347
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
https://github.com/python-zeroconf/python-zeroconf
bdracohttps://github.com/bdraco
masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
heappop_fixhttps://github.com/python-zeroconf/python-zeroconf/tree/heappop_fix
Conversationhttps://github.com/python-zeroconf/python-zeroconf/pull/1347
Commits8 (8)https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits
Checkshttps://github.com/python-zeroconf/python-zeroconf/pull/1347/checks
Files changedhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/files
fix: scheduling race with the QuerySchedulerhttps://github.com/python-zeroconf/python-zeroconf/pull/1347#top
bdracohttps://github.com/bdraco
masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
heappop_fixhttps://github.com/python-zeroconf/python-zeroconf/tree/heappop_fix
https://github.com/bdraco
bdracohttps://github.com/bdraco
Dec 16, 2023https://github.com/python-zeroconf/python-zeroconf/pull/1347#issue-2044579453
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347
bdracohttps://github.com/bdraco
December 15, 2023 17:02https://github.com/python-zeroconf/python-zeroconf/pull/1347#commits-pushed-c40a73b
https://github.com/bdraco
fix: ensure correct scheduled query is removed from the heap with the…https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/c40a73b48ee422e44406feb695c12bfe6c2d4e4c
c40a73bhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/c40a73b48ee422e44406feb695c12bfe6c2d4e4c
https://github.com/bdraco
Merge branch 'master' into heappop_fixhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/f0fc8df62baa18f17a2b6c3843e71d6669e7c0af
f0fc8dfhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/f0fc8df62baa18f17a2b6c3843e71d6669e7c0af
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Dec 16, 2023https://github.com/python-zeroconf/python-zeroconf/pull/1347#issuecomment-1858694515
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347
Codecovhttps://app.codecov.io/gh/python-zeroconf/python-zeroconf/pull/1347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
(9b595a1)https://app.codecov.io/gh/python-zeroconf/python-zeroconf/commit/9b595a1dcacf109c699953219d70fe36296c7318?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
(bd99f29)https://app.codecov.io/gh/python-zeroconf/python-zeroconf/pull/1347?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/python-zeroconf/python-zeroconf/pull/1347?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zeroconf
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347
bdracohttps://github.com/bdraco
December 15, 2023 17:07https://github.com/python-zeroconf/python-zeroconf/pull/1347#commits-pushed-54ce2d4
https://github.com/bdraco
fix: ensure correct scheduled query is removed from the heap with the…https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/54ce2d4d6c07d5b95533b6f14aade2b95090fe08
54ce2d4https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/54ce2d4d6c07d5b95533b6f14aade2b95090fe08
https://github.com/bdraco
Merge remote-tracking branch 'origin/heappop_fix' into heappop_fixhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/76b5aaf0ca06dff81e66649482c3274e2b23503a
76b5aafhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/76b5aaf0ca06dff81e66649482c3274e2b23503a
https://github.com/bdraco
fix: ensure correct scheduled query is removed from the heap with the…https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/6bc9d05aeb0912c577a5668d5eb11b9edd4d8813
6bc9d05https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/6bc9d05aeb0912c577a5668d5eb11b9edd4d8813
https://github.com/bdraco
fix: always reschedule since records can get added twice due to racehttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/94892fe5f5e9bdf7602f6d54f16527bf1bae1af4
94892fehttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/94892fe5f5e9bdf7602f6d54f16527bf1bae1af4
https://github.com/bdraco
fix: namehttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/3e8334d7b8e02c8bbbab256fad2cd6b40c246ce8
3e8334dhttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/3e8334d7b8e02c8bbbab256fad2cd6b40c246ce8
https://github.com/bdraco
bdracohttps://github.com/bdraco
Dec 16, 2023https://github.com/python-zeroconf/python-zeroconf/pull/1347#event-11264911255
https://github.com/bdraco
fix: remove now unreachable codehttps://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/bd99f29af91c31ee9981db66d8b225d79a9bb828
bd99f29https://github.com/python-zeroconf/python-zeroconf/pull/1347/commits/bd99f29af91c31ee9981db66d8b225d79a9bb828
https://github.com/bdraco
bdracohttps://github.com/bdraco
cf40470https://github.com/python-zeroconf/python-zeroconf/commit/cf40470b89f918d3c24d7889d3536f3ffa44846c
Dec 16, 2023https://github.com/python-zeroconf/python-zeroconf/pull/1347#event-11264934018
https://github.com/bdraco
bdracohttps://github.com/bdraco
December 16, 2023 03:39https://github.com/python-zeroconf/python-zeroconf/pull/1347#event-11264934032
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1347
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1347
https://github.com/bdraco
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.