René's URL Explorer Experiment


Title: feat: avoid decoding known answers if we have no answers to give by bdraco · Pull Request #1308 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: feat: avoid decoding known answers if we have no answers to give by bdraco · Pull Request #1308 · python-zeroconf/python-zeroconf

X Title: feat: avoid decoding known answers if we have no answers to give by bdraco · Pull Request #1308 · python-zeroconf/python-zeroconf

Description: Inspired by #1307 In most cases were won't be able to answer the questions because we don't have an answer in the ServiceRegistry for the question since we only know how to answer for entries we have. In this case we can avoid building a set of answers and parsing the known answers in the incoming packet in the majority of cases. This is a significant speed up since parsing incoming packets is the most expensive thing zeroconf does. The downside is we might ask a question in the ServiceBrowser that was just asked by another host with the exact same known answer list but this is unlikely as its usually multiple ServiceBrowsers running in the same instance that would do that. We really need to solve #1171 though as thats where the really traffic reduction opportunity is.

Open Graph Description: Inspired by #1307 In most cases were won't be able to answer the questions because we don't have an answer in the ServiceRegistry for the question since we only know how to answer for entri...

X Description: Inspired by #1307 In most cases were won't be able to answer the questions because we don't have an answer in the ServiceRegistry for the question since we only know how to answer f...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/1308

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:120cae96-1b71-fabf-dc65-3fa8b9c6bdd8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC760:1F9C:86D43A:B4D140:6B00B655
html-safe-nonce7c6431c80215572e58271b60c637d6f59931f9827165b002dfc5f3c4f05b7ce1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzYwOjFGOUM6ODZENDNBOkI0RDE0MDo2QjAwQjY1NSIsInZpc2l0b3JfaWQiOiIxNDU1OTUyNTc2MDc4OTg0Nzg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac45d4943a8937b7931d60decb2a0840a65f9eb7951f710d732a62beac02febc5a
hovercard-subject-tagpull_request:1597810336
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/1308/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altInspired by #1307 In most cases were won't be able to answer the questions because we don't have an answer in the ServiceRegistry for the question since we only know how to answer for entri...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1308%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F1308%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
avoid_parsing_answershttps://github.com/python-zeroconf/python-zeroconf/tree/avoid_parsing_answers
Conversation 1 https://github.com/python-zeroconf/python-zeroconf/pull/1308
Commits 32 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/1308/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/1308/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files
feat: avoid decoding known answers if we have no answers to give https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#top
Show all changes 32 commits https://github.com/python-zeroconf/python-zeroconf/pull/1308/files
273ba7a feat: avoid decoding known answers if we have no answers to give bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/273ba7a270c15a5bd5405ff6ad07bffdc0de6a70
5e4f56f feat: avoid decoding known answers if we have no answers to give bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/5e4f56f2ed352403a19e6a1c659d3cfac0396dae
2ae8897 feat: avoid decoding known answers if we have no answers to give bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/2ae8897f143fc4d5acc124f9793219a83f9004c0
e1161b8 fix: fixes bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/e1161b8abc3007d18073b7dfb6b41409153f53c4
fc83516 fix: fixes bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/fc83516507d4030c1335feeb1a30c2c0544bc529
19d8262 fix: fixes bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/19d8262638173f18c2ba799dde2dcb560bc40077
80003b9 fix: fixes bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/80003b996fe54bc2d554312e76a9df3df7da1c6b
9f2f1eb fix: fixes bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/9f2f1eb944f8ce1cd8b9604015d6c0e7daf7abf7
4c84de6 fix: fixes bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/4c84de6d56a797d4507f9bbd5457b41142e6c381
1f1e76b fix: make responses optional bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/1f1e76b9e726fbc233aa506c90e6d297a4f5da8f
488a1df fix: cleanups bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/488a1df335ad2585c074c4126a87c7dccb43cf8c
9b4d78d fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/9b4d78d4a2060e8d6b98702331969529432d8858
4c9f7e1 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/4c9f7e1d99690802363998a175c500ce06491328
8102b7e fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/8102b7e90b50d4e805aadca4623bb88ffeff0f39
ed80a33 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/ed80a339a77e63bac4f7432a6c5b5c5d5f4eb57b
2dc8045 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/2dc8045732012d198b0d3480354cd7417abce04a
f1c18eb fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/f1c18eba3d39557dcb35af0eefb028d515aa8719
fb27400 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/fb27400467e8ca5be60bc44d4141e24d412efba9
f0bb844 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/f0bb8449a108ff6b89242b47f443e8079e1a98fa
1bc70d2 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/1bc70d204eae2f492e7ea3837a8b1a7d7731cef9
470fc83 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/470fc8355080be57f2996e91a5726fd36185b87f
7bc8fb3 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/7bc8fb30546199543a07e6e8d8cda4ed71c0d1f0
a88af11 fix: tweaks bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/a88af110d52a2833fecb29e2588432a4003864bf
a55f805 fix: typo in tests bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/a55f8052bf1b8a704d98042dfd44894510dedd1e
a4b8a06 fix: more test fixes bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/a4b8a06fb5bc1b9947174b6d0f420da081c039cd
1aa8869 fix: more test fixes bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/1aa886916c9bc4899ea6300de89af0949966b417
ef7f622 fix: test repr bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/ef7f622f058fd8f4a440bff3d37010f9272fea3b
eb3f8fd fix: only 5 options bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/eb3f8fd9cb955265e75ef5616f49076f65bde444
b2f4ae7 fix: branching bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/b2f4ae7c9defdb665d0375523065448b30f115f7
115ae93 fix: cleanup bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/115ae932224f6593347ea2249ddc20c3a1ce04c1
d1db9c0 fix: cleanup bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/d1db9c0fc238a99e12ca06ea665a4497b60b676f
028fa9e Merge branch 'master' into avoid_parsing_answers bdraco Nov 12, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/1308/commits/028fa9ee96e97fa53ac4876b844439693546972f
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/1308/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files
_core.py https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-334d60456692812966fc9644e6d71b6e2c60dfc6fb2d02d02d5fef6a480c360d
answers.py https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-dbe76e24064dd61be77fde13f93b48d3b6ee10bd43ae116b5b7427ab54f80b8e
multicast_outgoing_queue.py https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-782a526af6e9973de4e5357f2856cb73d7c9c655bba58d9ee8ceb660afa99434
query_handler.pxd https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
query_handler.py https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-dcb2bcd662da3efbef6d7130df11573195707931c9318ac44e922e54f32c9a25
_record_update.py https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-d3f58aa2875f33ce258f88ed9026829e9e7ffa34b8ac3edaebc813c0886fc8d1
test_handlers.py https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-a80edd2ae6b30f0f5a2a8f7bdd4089a43fc5dca4d21588fa4879392950b609f1
src/zeroconf/_core.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-334d60456692812966fc9644e6d71b6e2c60dfc6fb2d02d02d5fef6a480c360d
View file https://github.com/python-zeroconf/python-zeroconf/blob/028fa9ee96e97fa53ac4876b844439693546972f/src/zeroconf/_core.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1308/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-334d60456692812966fc9644e6d71b6e2c60dfc6fb2d02d02d5fef6a480c360d
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-334d60456692812966fc9644e6d71b6e2c60dfc6fb2d02d02d5fef6a480c360d
src/zeroconf/_handlers/answers.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-dbe76e24064dd61be77fde13f93b48d3b6ee10bd43ae116b5b7427ab54f80b8e
View file https://github.com/python-zeroconf/python-zeroconf/blob/028fa9ee96e97fa53ac4876b844439693546972f/src/zeroconf/_handlers/answers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1308/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-dbe76e24064dd61be77fde13f93b48d3b6ee10bd43ae116b5b7427ab54f80b8e
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-dbe76e24064dd61be77fde13f93b48d3b6ee10bd43ae116b5b7427ab54f80b8e
src/zeroconf/_handlers/multicast_outgoing_queue.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-782a526af6e9973de4e5357f2856cb73d7c9c655bba58d9ee8ceb660afa99434
View file https://github.com/python-zeroconf/python-zeroconf/blob/028fa9ee96e97fa53ac4876b844439693546972f/src/zeroconf/_handlers/multicast_outgoing_queue.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1308/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-782a526af6e9973de4e5357f2856cb73d7c9c655bba58d9ee8ceb660afa99434
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-782a526af6e9973de4e5357f2856cb73d7c9c655bba58d9ee8ceb660afa99434
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-782a526af6e9973de4e5357f2856cb73d7c9c655bba58d9ee8ceb660afa99434
src/zeroconf/_handlers/query_handler.pxdhttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
View file https://github.com/python-zeroconf/python-zeroconf/blob/028fa9ee96e97fa53ac4876b844439693546972f/src/zeroconf/_handlers/query_handler.pxd
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/1308/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
https://github.com/python-zeroconf/python-zeroconf/pull/1308/files#diff-0bb683599aef93d11bf006b81b24853895fc7e0dc3384ef2fa4ea14f9db4d540
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/1308/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.