René's URL Explorer Experiment


Title: Regression in unique/shared handling for service browser in 0.24.5? · Issue #236 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Regression in unique/shared handling for service browser in 0.24.5? · Issue #236 · python-zeroconf/python-zeroconf

X Title: Regression in unique/shared handling for service browser in 0.24.5? · Issue #236 · python-zeroconf/python-zeroconf

Description: Home Assistant uses zeroconf to detect HomeKit (_hap._tcp.local) devices. Since it was updated to use 0.24.5 we've seen a couple of cases where discovery wasn't behaving correctly. With the help of an affected user we ran browser.py. Thi...

Open Graph Description: Home Assistant uses zeroconf to detect HomeKit (_hap._tcp.local) devices. Since it was updated to use 0.24.5 we've seen a couple of cases where discovery wasn't behaving correctly. With the help of...

X Description: Home Assistant uses zeroconf to detect HomeKit (_hap._tcp.local) devices. Since it was updated to use 0.24.5 we've seen a couple of cases where discovery wasn't behaving correctly. With the...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/issues/236

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Regression in unique/shared handling for service browser in 0.24.5?","articleBody":"Home Assistant uses zeroconf to detect HomeKit (`_hap._tcp.local`) devices. Since it was updated to use 0.24.5 we've seen a couple of cases where discovery wasn't behaving correctly. With the help of an affected user we ran [browser.py](https://github.com/jstasiak/python-zeroconf/blob/master/examples/browser.py). This showed that 0.24.5 without any Home Assistant code triggered the error.\r\n\r\nEventually we discovered that they have devices on their network which have `srv` records that don't set the record as unique, and since #217 was merged this triggers an assertion in `get_service_info`:\r\n\r\n```\r\nException in thread zeroconf-ServiceBrowser__hap._tcp.local.:\r\nTraceback (most recent call last):\r\n  File \"/usr/lib/python3.7/threading.py\", line 917, in _bootstrap_inner\r\n    self.run()\r\n  File \"/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py\", line 1504, in run\r\n    handler(self.zc)\r\n  File \"/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py\", line 1444, in \u003clambda>\r\n    zeroconf=zeroconf, service_type=self.type, name=name, state_change=state_change\r\n  File \"/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py\", line 1322, in fire\r\n    h(**kwargs)\r\n  File \"browser.py\", line 20, in on_service_state_change\r\n    info = zeroconf.get_service_info(service_type, name)\r\n  File \"/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py\", line 2191, in get_service_info\r\n    if info.request(self, timeout):\r\n  File \"/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py\", line 1762, in request\r\n    out.add_answer_at_time(zc.cache.get_by_details(self.name, _TYPE_SRV, _CLASS_IN), now)\r\n  File \"/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py\", line 907, in add_answer_at_time\r\n    assert record.unique\r\nAssertionError\r\n```\r\n\r\nUnplugging these devices allowed things to function normally.\r\n\r\nReverting to 0.24.4 (before #217) also allowed things to function normally.\r\n\r\nIf i understood correctly the check in #217 was for when publishing a zeroconf record? Is it possible to relax/disalbe the check when browsing? As obviously we can't do anything about vendors implementations of things.\r\n\r\nCCing @Neejoh as would not have been able to trace this issue without their devices and @mattsaxon in case you can shed any light on this?\r\n","author":{"url":"https://github.com/Jc2k","@type":"Person","name":"Jc2k"},"datePublished":"2020-03-31T22:03:48Z","url":"https://github.com/python-zeroconf/python-zeroconf/issues/236"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a42ce10a-a78c-708b-27fd-2d518fc1a8e7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD2D4:1CE9AC:36F716:49A932:6B0089EE
html-safe-nonce45af334d68d663bc9cd85fb04cadc35fa895ca82d88a210168e1d53c4de4af5a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkQ0OjFDRTlBQzozNkY3MTY6NDlBOTMyOjZCMDA4OUVFIiwidmlzaXRvcl9pZCI6IjczNTA4MDA4OTY4Mjc0MTc0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac820304aa43dcb1c26b1c41b5cdc279265194d77f6ae284686822162f2271ac83
hovercard-subject-tagissue:591462396
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-zeroconf/python-zeroconf/236/issue_layout
twitter:imagehttps://opengraph.githubassets.com/879148f8217e961c8d4bc8e37237271d4cac685b141eea6505a5099e2e67a83f/python-zeroconf/python-zeroconf/issues/236
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/879148f8217e961c8d4bc8e37237271d4cac685b141eea6505a5099e2e67a83f/python-zeroconf/python-zeroconf/issues/236
og:image:altHome Assistant uses zeroconf to detect HomeKit (_hap._tcp.local) devices. Since it was updated to use 0.24.5 we've seen a couple of cases where discovery wasn't behaving correctly. With the help of...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJc2k
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-preview
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/issues/236#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2F236
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2F236
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/issues/236
Reloadhttps://github.com/python-zeroconf/python-zeroconf/issues/236
Reloadhttps://github.com/python-zeroconf/python-zeroconf/issues/236
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
https://github.com/python-zeroconf/python-zeroconf
New issuehttps://github.com/login?return_to=https://github.com/python-zeroconf/python-zeroconf/issues/236
New issuehttps://github.com/login?return_to=https://github.com/python-zeroconf/python-zeroconf/issues/236
Regression in unique/shared handling for service browser in 0.24.5?https://github.com/python-zeroconf/python-zeroconf/issues/236#top
https://github.com/Jc2k
Jc2khttps://github.com/Jc2k
on Mar 31, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#issue-591462396
browser.pyhttps://github.com/jstasiak/python-zeroconf/blob/master/examples/browser.py
#217https://github.com/python-zeroconf/python-zeroconf/pull/217
#217https://github.com/python-zeroconf/python-zeroconf/pull/217
#217https://github.com/python-zeroconf/python-zeroconf/pull/217
@neejohhttps://github.com/neejoh
@mattsaxonhttps://github.com/mattsaxon
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
on Apr 1, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#issuecomment-607067440
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
on Apr 1, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#issuecomment-607160771
@mattsaxonhttps://github.com/mattsaxon
@Jc2khttps://github.com/Jc2k
@neejohhttps://github.com/neejoh
https://github.com/Jc2k
Jc2khttps://github.com/Jc2k
on Apr 1, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#issuecomment-607166049
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
on Apr 1, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#issuecomment-607268015
@jstasiakhttps://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
on Apr 3, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#event-3195611078
Remove uniqueness assertionshttps://github.com/python-zeroconf/python-zeroconf/commit/fdb803b39d69a31b9d1d1e46b55849f79a87ef3c
fdb803bhttps://github.com/python-zeroconf/python-zeroconf/commit/fdb803b39d69a31b9d1d1e46b55849f79a87ef3c
Remove uniqueness assertionshttps://github.com/python-zeroconf/python-zeroconf/commit/a79015e7c4bdc843d97bd5c82ef8ed4eeae01a34
a79015ehttps://github.com/python-zeroconf/python-zeroconf/commit/a79015e7c4bdc843d97bd5c82ef8ed4eeae01a34
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
on Apr 3, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#issuecomment-608372447
#226https://github.com/python-zeroconf/python-zeroconf/pull/226
jstasiakhttps://github.com/jstasiak
completedhttps://github.com/python-zeroconf/python-zeroconf/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 3, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#event-3195921351
https://github.com/Jc2k
Jc2khttps://github.com/Jc2k
on Apr 3, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#issuecomment-608381232
@jstasiakhttps://github.com/jstasiak
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
on Apr 3, 2020https://github.com/python-zeroconf/python-zeroconf/issues/236#issuecomment-608384202
#235https://github.com/python-zeroconf/python-zeroconf/issues/235
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-zeroconf/python-zeroconf/issues/236
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-zeroconf/python-zeroconf/issues/236
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.