René's URL Explorer Experiment


Title: interface_risk: `Signal.fire(**kwargs)` loses all callback contract information · Issue #1779 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: interface_risk: `Signal.fire(**kwargs)` loses all callback contract information · Issue #1779 · python-zeroconf/python-zeroconf

X Title: interface_risk: `Signal.fire(**kwargs)` loses all callback contract information · Issue #1779 · python-zeroconf/python-zeroconf

Description: Problem Signal._handlers is typed list[Callable[..., None]], and fire(**kwargs: Any) forwards arbitrary kwargs through to each registered handler. There is no compile-time, mypy-time, or runtime check that callers are passing the keys ha...

Open Graph Description: Problem Signal._handlers is typed list[Callable[..., None]], and fire(**kwargs: Any) forwards arbitrary kwargs through to each registered handler. There is no compile-time, mypy-time, or runtime ch...

X Description: Problem Signal._handlers is typed list[Callable[..., None]], and fire(**kwargs: Any) forwards arbitrary kwargs through to each registered handler. There is no compile-time, mypy-time, or runtime ch...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/issues/1779

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"interface_risk: `Signal.fire(**kwargs)` loses all callback contract information","articleBody":"## Problem\n\n`Signal._handlers` is typed `list[Callable[..., None]]`, and `fire(**kwargs: Any)` forwards arbitrary kwargs through to each registered handler. There is no compile-time, mypy-time, or runtime check that callers are passing the keys handlers expect (`zc`, `service_type`, `state_change`) or that handlers declare them. A typo in a fire-site key, or a handler that forgets one of the keyword args, fails only at the moment a real event happens to dispatch — which on quiet networks may be hours or days into the run. The signature also makes refactoring the dispatch contract effectively undetectable: adding or renaming a key shows up nowhere in type-checking. Because `ServiceBrowser`, `AsyncServiceBrowser`, and external consumers all wire callbacks through this mechanism, the contract is load-bearing for the whole browse API.\n\n## Why This Matters\n\nThe lack of contract masks integration bugs in third-party code that subscribes to `ServiceBrowser`, and it blocks mypy from helping anyone (including this repo) catch dispatch mismatches when the dispatch shape ever changes.\n\n## Suggested Fix\n\nLock the contract down. Define a `Protocol` describing the handler signature (`def __call__(self, zeroconf: Zeroconf, service_type: str, name: str, state_change: ServiceStateChange) -> None`), type `_handlers` as `list[that protocol]`, and change `fire` to take positional/keyword parameters that match — `def fire(self, *, zeroconf: Zeroconf, service_type: str, name: str, state_change: ServiceStateChange) -> None`. Keep backward compatibility by leaving the `register_handler` accepting `Callable[..., None]` but type-narrowing internally. Test coverage already exists for the happy paths, so the migration is mostly mechanical.\n\n## Details\n\n| | |\n|---|---|\n| **Severity** | 🟡 Medium |\n| **Category** | interface_risk |\n| **Location** | `src/zeroconf/_services/__init__.py:51-78` |\n| **Effort** | 🛠️ Moderate effort |\n\n---\n🤖 Created by Kōan from audit session\n\u003c!-- koan-audit-id: 0270740ec20a6d0e -->","author":{"url":"https://github.com/bluetoothbot","@type":"Person","name":"bluetoothbot"},"datePublished":"2026-05-26T16:28:14Z","url":"https://github.com/python-zeroconf/python-zeroconf/issues/1779"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c28768ab-9ea5-4f41-ce14-86b8300a7e9f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8E8A:2BA6E:1010:14C5:6B007D37
html-safe-nonce2328137587993278b23197e1251798c2c0d3cf22b7a3d9a183d4da6334e60a09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RThBOjJCQTZFOjEwMTA6MTRDNTo2QjAwN0QzNyIsInZpc2l0b3JfaWQiOiI3NjI3Mzg1ODI2NjYxMzk5ODYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbdee86997d237c220cb3db8299665e3f43b7b40665a76bdd4b2cc6668986b405
hovercard-subject-tagissue:4525792671
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-zeroconf/python-zeroconf/1779/issue_layout
twitter:imagehttps://opengraph.githubassets.com/79c169a47781539eb9030e3a05b241ee37628b50300201f737300813f5471cee/python-zeroconf/python-zeroconf/issues/1779
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/79c169a47781539eb9030e3a05b241ee37628b50300201f737300813f5471cee/python-zeroconf/python-zeroconf/issues/1779
og:image:altProblem Signal._handlers is typed list[Callable[..., None]], and fire(**kwargs: Any) forwards arbitrary kwargs through to each registered handler. There is no compile-time, mypy-time, or runtime ch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebluetoothbot
hostnamegithub.com
expected-hostnamegithub.com
None82c186f13e104004ab7bdb779f3195e59dd38bfde531aaa74b76470fc2462b83
turbo-cache-controlno-preview
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1bc2aa1939001689f5ce935982c10a6138f745c
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/issues/1779#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2F1779
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2F1779
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/issues/1779
Reloadhttps://github.com/python-zeroconf/python-zeroconf/issues/1779
Reloadhttps://github.com/python-zeroconf/python-zeroconf/issues/1779
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
https://github.com/python-zeroconf/python-zeroconf
New issuehttps://github.com/login?return_to=https://github.com/python-zeroconf/python-zeroconf/issues/1779
New issuehttps://github.com/login?return_to=https://github.com/python-zeroconf/python-zeroconf/issues/1779
#1784https://github.com/python-zeroconf/python-zeroconf/pull/1784
interface_risk: Signal.fire(**kwargs) loses all callback contract informationhttps://github.com/python-zeroconf/python-zeroconf/issues/1779#top
#1784https://github.com/python-zeroconf/python-zeroconf/pull/1784
https://github.com/bluetoothbot
bluetoothbothttps://github.com/bluetoothbot
on May 26, 2026https://github.com/python-zeroconf/python-zeroconf/issues/1779#issue-4525792671
https://github.com/bdraco
bdracohttps://github.com/bdraco
on May 26, 2026https://github.com/python-zeroconf/python-zeroconf/issues/1779#issuecomment-4546283266
@bluetoothbothttps://github.com/bluetoothbot
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-zeroconf/python-zeroconf/issues/1779
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-zeroconf/python-zeroconf/issues/1779
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.