Title: Supertype query discards subtype in result · Issue #1093 · python-zeroconf/python-zeroconf · GitHub
Open Graph Title: Supertype query discards subtype in result · Issue #1093 · python-zeroconf/python-zeroconf
X Title: Supertype query discards subtype in result · Issue #1093 · python-zeroconf/python-zeroconf
Description: If a device is advertising a service of type "_blah._http._tcp.local.", but I've set ServiceBrowser to filter for its supertype "_http._tcp.local.", then in def add_service(self, zc: Zeroconf, type_: str, name: str) -> None: info = zc.ge...
Open Graph Description: If a device is advertising a service of type "_blah._http._tcp.local.", but I've set ServiceBrowser to filter for its supertype "_http._tcp.local.", then in def add_service(self, zc: Zeroconf, type...
X Description: If a device is advertising a service of type "_blah._http._tcp.local.", but I've set ServiceBrowser to filter for its supertype "_http._tcp.local.", then in def add_service(...
Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/issues/1093
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Supertype query discards subtype in result","articleBody":"If a device is advertising a service of type \"_blah._http._tcp.local.\", but I've set `ServiceBrowser` to filter for its supertype \"_http._tcp.local.\", then in\r\n```python\r\n def add_service(self, zc: Zeroconf, type_: str, name: str) -> None:\r\n info = zc.get_service_info(type_, name)\r\n```\r\nthe `type_`, and `info.type`, are both the supertype \"_http._tcp.local.\", rather than the actual type of the service. IMO, the actual type ought to be accessible. A key point seems to be here:\r\nhttps://github.com/jstasiak/python-zeroconf/blob/7430ce1c462be0dd210712b4f7b3675efd3a6963/zeroconf/_services/browser.py#L355\r\nwherein the actual type is split into a list of it and its supertypes, I guess? Probably then there's something that filters the resulting events, and only the one keyed to the supertype succeeds.\r\n\r\nDesired result: `get_service_info` ought to include the actual type of the service, and possibly `type_` in `add_service` et al. ought to be the actual type, too, though I'm less convinced of that.","author":{"url":"https://github.com/Erhannis","@type":"Person","name":"Erhannis"},"datePublished":"2022-10-06T06:45:11Z","url":"https://github.com/python-zeroconf/python-zeroconf/issues/1093"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:60227acf-19d9-1e16-d498-5023d348fff5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E310:136EFE:E949:1442C:6B007D35 |
| html-safe-nonce | dd78903f9fe361f098c0f46174a8b2644fbef0aa7c85565b450920a903bf8b33 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzEwOjEzNkVGRTpFOTQ5OjE0NDJDOjZCMDA3RDM1IiwidmlzaXRvcl9pZCI6IjYzMDI3NDMyNzg5MjgyOTcyNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 160e86d2b54b96329993928a82705693030b008d13f32879a0597742e53d6bdc |
| hovercard-subject-tag | issue:1398928092 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-zeroconf/python-zeroconf/1093/issue_layout |
| twitter:image | https://opengraph.githubassets.com/cc68ddc97e0770fd6aea76c04c77fa9d7101eb2f4a3791121fbc6243acf7f95d/python-zeroconf/python-zeroconf/issues/1093 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cc68ddc97e0770fd6aea76c04c77fa9d7101eb2f4a3791121fbc6243acf7f95d/python-zeroconf/python-zeroconf/issues/1093 |
| og:image:alt | If a device is advertising a service of type "_blah._http._tcp.local.", but I've set ServiceBrowser to filter for its supertype "_http._tcp.local.", then in def add_service(self, zc: Zeroconf, type... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Erhannis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 82c186f13e104004ab7bdb779f3195e59dd38bfde531aaa74b76470fc2462b83 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git |
| octolytics-dimension-user_id | 120192235 |
| octolytics-dimension-user_login | python-zeroconf |
| octolytics-dimension-repository_id | 21548731 |
| octolytics-dimension-repository_nwo | python-zeroconf/python-zeroconf |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21548731 |
| octolytics-dimension-repository_network_root_nwo | python-zeroconf/python-zeroconf |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d1bc2aa1939001689f5ce935982c10a6138f745c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width