Title: Add support for timeout. Change from select syscall to poll by nveloso · Pull Request #210 · python-xlib/python-xlib · GitHub
Open Graph Title: Add support for timeout. Change from select syscall to poll by nveloso · Pull Request #210 · python-xlib/python-xlib
X Title: Add support for timeout. Change from select syscall to poll by nveloso · Pull Request #210 · python-xlib/python-xlib
Description: Hi! In this PR I added support for specifying the timeout used in sockets via an argument. I changed the use of select syscall to poll syscall. Select syscall has a known limitation: WARNING: select() can monitor only file descriptors numbers that are less than FD_SETSIZE (1024)—an unreasonably low limit for many modern applications—and this limitation will not change. All modern applications should instead use poll(2) or epoll(7), which do not suffer this limitation. Taken from https://man7.org/linux/man-pages/man2/select.2.html I also make the BaseDisplay class public because it can be useful to connect to a X11 server without making several requests to get all the extensions available. I also added a check in parse_connection_setup method that checks if the response has a valid status. In the protocol specification page 11 and 114 you can see all the available status (0, 1 or 2). I ran the tests with python3 runtests.py and all passed. ---------------------------------------------------------------------- XML: /com.docker.devenvironments.code/nosetests.xml ---------------------------------------------------------------------- Ran 524 tests in 12.184s OK (SKIP=142) I hope you can merge my changes. Any question feel free to ask.
Open Graph Description: Hi! In this PR I added support for specifying the timeout used in sockets via an argument. I changed the use of select syscall to poll syscall. Select syscall has a known limitation: WARNING: sele...
X Description: Hi! In this PR I added support for specifying the timeout used in sockets via an argument. I changed the use of select syscall to poll syscall. Select syscall has a known limitation: WARNING: sele...
Opengraph URL: https://github.com/python-xlib/python-xlib/pull/210
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:88671b7d-59a0-572e-51ad-1cdbc0973cf8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B408:1E4FEF:E5E9F:1230B9:696AD5B3 |
| html-safe-nonce | 2d6d1a67f3a9089a89f178461c42510e17ede9dee44ebda85e06fb0ca384bd46 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDA4OjFFNEZFRjpFNUU5RjoxMjMwQjk6Njk2QUQ1QjMiLCJ2aXNpdG9yX2lkIjoiODIwODA2MDAzNjM0NDg5NDg5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2be0466b1a38df80b5c3127f371e93fa37c4f70c9c3715c0786209429370c86a |
| hovercard-subject-tag | pull_request:760463022 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-xlib/python-xlib/pull/210/files |
| twitter:image | https://avatars.githubusercontent.com/u/24777851?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/24777851?s=400&v=4 |
| og:image:alt | Hi! In this PR I added support for specifying the timeout used in sockets via an argument. I changed the use of select syscall to poll syscall. Select syscall has a known limitation: WARNING: sele... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-xlib/python-xlib git https://github.com/python-xlib/python-xlib.git |
| octolytics-dimension-user_id | 16151530 |
| octolytics-dimension-user_login | python-xlib |
| octolytics-dimension-repository_id | 47391866 |
| octolytics-dimension-repository_nwo | python-xlib/python-xlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 47391866 |
| octolytics-dimension-repository_network_root_nwo | python-xlib/python-xlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c718a376fcf780eb22089171adb84a543f660bf7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width