René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"shape_combine definition is invalid - TypeError: Missing required argument destination_window","articleBody":"I thought I was missing something, but it's looking like no one has EVER used shape_combine, but the definition of the function does not attempt to create the object with the required destination_window parameter:\r\n\r\n```\r\nclass Combine(rq.Request):\r\n\r\n    _request = rq.Struct(\r\n        rq.Card8('opcode'),\r\n        rq.Opcode(3),\r\n        rq.RequestLength(),\r\n        OP('operation'),\r\n        KIND('destination_kind'),\r\n        KIND('source_kind'),\r\n        rq.Pad(1),\r\n        rq.Window('destination_window'),\r\n        rq.Int16('x_offset'),\r\n        rq.Int16('y_offset'),\r\n        rq.Window('source_window'),\r\n    )\r\n[...]\r\ndef combine(self, operation, destination_kind, source_kind, x_offset, y_offset):\r\n    Combine(\r\n        display=self.display,\r\n        opcode=self.display.get_extension_major(extname),\r\n        source_window=self,\r\n        operation=operation,\r\n        destination_kind=destination_kind,\r\n        source_kind=source_kind,\r\n        x_offset=x_offset,\r\n        y_offset=y_offset,\r\n    )\r\n\r\n```\r\nshape_mask is, in believe, only different from shape_combine in that it takes in a window of varying colour depth, instead of a binary bitmap. As such the parameters should be identical except the source_bitmap parameter in shape_mask should instead be the source_kind option (present) and source_window (missing!) in shape_combine. mask is defined as:\r\n\r\n```\r\ndef mask(self, operation, destination_kind, x_offset, y_offset, source_bitmap):\r\n    Mask(\r\n        display=self.display,\r\n        opcode=self.display.get_extension_major(extname),\r\n        destination_window=self,\r\n        operation=operation,\r\n        destination_kind=destination_kind,\r\n        x_offset=x_offset,\r\n        y_offset=y_offset,\r\n        source_bitmap=source_bitmap,\r\n    )\r\n```\r\nso combine should actually be defined as:\r\n```\r\ndef combine(self, operation, destination_kind, source_kind, x_offset, y_offset):\r\n    Combine(\r\n        display=self.display,\r\n        opcode=self.display.get_extension_major(extname),\r\n        source_window=source_window\r\n        destination_window=self,\r\n        operation=operation,\r\n        destination_kind=destination_kind,\r\n        source_kind=source_kind,\r\n        x_offset=x_offset,\r\n        y_offset=y_offset,\r\n        source_window=source_window\r\n    )\r\n```\r\nIndeed it seems that parameters for source and destination windows have in fact been... wait for it... combined! \r\n\r\n #263 ","author":{"url":"https://github.com/acidkewpie","@type":"Person","name":"acidkewpie"},"datePublished":"2023-03-15T22:55:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/262/python-xlib/issues/262"}