| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8640c584-4307-aa33-e7ed-5c45be6c8128 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DCF6:2C893:1D1CF:257E7:698DDA6E |
| html-safe-nonce | 34f69a220ccb81f60cbeda6c691f15cfec41eb898f78d9f53c470b1d14f5844c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0Y2OjJDODkzOjFEMUNGOjI1N0U3OjY5OEREQTZFIiwidmlzaXRvcl9pZCI6IjMzMTg5NjQxNTA0NDUzOTg2MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ac4b4a84cec476911d68591c7bb7eb10d2b34c06c1c63d5a52289dec96ba1a05 |
| hovercard-subject-tag | pull_request:1971272916 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-validators/validators/390/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5a24bd8932cb1110505b94f74aff64d0038e734532ca9f81c40d6da108a2c0db/python-validators/validators/pull/390 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5a24bd8932cb1110505b94f74aff64d0038e734532ca9f81c40d6da108a2c0db/python-validators/validators/pull/390 |
| og:image:alt | Follow-up to the discussion in #362.
I wasn't sure what was meant by using dataclass, as this isn't a data-first class. I used a regular class, instead.
One thing that's obviously missi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | salty-horse |
| hostname | github.com |
| expected-hostname | github.com |
| None | 51102c619bffd74bf95dcf3796f0e599d197c0206d70e9e8b5c241b1b9707ee3 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-validators/validators git https://github.com/python-validators/validators.git |
| octolytics-dimension-user_id | 113113270 |
| octolytics-dimension-user_login | python-validators |
| octolytics-dimension-repository_id | 13642984 |
| octolytics-dimension-repository_nwo | python-validators/validators |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13642984 |
| octolytics-dimension-repository_network_root_nwo | python-validators/validators |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fcdeb213ace418f8a19d95dd6b93ba3337346169 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python-validators/validators/pull/390#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-validators%2Fvalidators%2Fpull%2F390 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-validators%2Fvalidators%2Fpull%2F390 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-validators%2Fvalidators |
| Reload | https://github.com/python-validators/validators/pull/390 |
| Reload | https://github.com/python-validators/validators/pull/390 |
| Reload | https://github.com/python-validators/validators/pull/390 |
|
python-validators
| https://github.com/python-validators |
| validators | https://github.com/python-validators/validators |
|
Notifications
| https://github.com/login?return_to=%2Fpython-validators%2Fvalidators |
|
Fork
169
| https://github.com/login?return_to=%2Fpython-validators%2Fvalidators |
|
Star
1.1k
| https://github.com/login?return_to=%2Fpython-validators%2Fvalidators |
|
Code
| https://github.com/python-validators/validators |
|
Issues
4
| https://github.com/python-validators/validators/issues |
|
Pull requests
3
| https://github.com/python-validators/validators/pulls |
|
Discussions
| https://github.com/python-validators/validators/discussions |
|
Actions
| https://github.com/python-validators/validators/actions |
|
Projects
0
| https://github.com/python-validators/validators/projects |
|
Wiki
| https://github.com/python-validators/validators/wiki |
|
Security
0
| https://github.com/python-validators/validators/security |
|
Insights
| https://github.com/python-validators/validators/pulse |
|
Code
| https://github.com/python-validators/validators |
|
Issues
| https://github.com/python-validators/validators/issues |
|
Pull requests
| https://github.com/python-validators/validators/pulls |
|
Discussions
| https://github.com/python-validators/validators/discussions |
|
Actions
| https://github.com/python-validators/validators/actions |
|
Projects
| https://github.com/python-validators/validators/projects |
|
Wiki
| https://github.com/python-validators/validators/wiki |
|
Security
| https://github.com/python-validators/validators/security |
|
Insights
| https://github.com/python-validators/validators/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython-validators%2Fvalidators%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython-validators%2Fvalidators%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python-validators/validators/pull/390#issue-comment-box |
| nandgator | https://github.com/nandgator |
| python-validators:master | https://github.com/python-validators/validators/tree/master |
| salty-horse:load_iana_tlds_to_memory | https://github.com/salty-horse/validators/tree/load_iana_tlds_to_memory |
|
feat: cache IANA TLDs for faster lookups
| https://github.com/python-validators/validators/pull/390#top |
| nandgator | https://github.com/nandgator |
| python-validators:master | https://github.com/python-validators/validators/tree/master |
| salty-horse:load_iana_tlds_to_memory | https://github.com/salty-horse/validators/tree/load_iana_tlds_to_memory |
|
Conversation
25
| https://github.com/python-validators/validators/pull/390 |
|
Commits
5
| https://github.com/python-validators/validators/pull/390/commits |
|
Checks
0
| https://github.com/python-validators/validators/pull/390/checks |
|
Files changed
1
| https://github.com/python-validators/validators/pull/390/files |
| https://github.co/hiddenchars |
| https://github.com/python-validators/validators/pull/{{ revealButtonHref }} |
|
| https://github.com/salty-horse |
| salty-horse | https://github.com/salty-horse |
| Jul 16, 2024 | https://github.com/python-validators/validators/pull/390#issue-2410816717 |
| #362 | https://github.com/python-validators/validators/pull/362 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
|
| https://github.com/salty-horse |
| feat: add load_iana_tlds_to_memory | https://github.com/python-validators/validators/pull/390/commits/1c06c5bb218e626ebe10fdf3d09dfcfbd4db39ea |
| 1c06c5b | https://github.com/python-validators/validators/pull/390/commits/1c06c5bb218e626ebe10fdf3d09dfcfbd4db39ea |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
| Jul 17, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2232407492 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| https://github.com/salty-horse |
| salty-horse | https://github.com/salty-horse |
| Jul 17, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2232508133 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
| Jul 17, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2232551082 |
| documentation shows | https://yozachar.github.io/pyvalidators/stable/install_and_use/#to-raise-validation-error |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| https://github.com/salty-horse |
| salty-horse | https://github.com/salty-horse |
| Jul 17, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2232965886 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
|
| https://github.com/salty-horse |
| Updates based on discussion | https://github.com/python-validators/validators/pull/390/commits/999dfac8859401dfa841e3758e89c0ec3ac90da3 |
| 999dfac | https://github.com/python-validators/validators/pull/390/commits/999dfac8859401dfa841e3758e89c0ec3ac90da3 |
| https://github.com/salty-horse |
| salty-horse | https://github.com/salty-horse |
| Jul 17, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2233686025 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
|
Jul 18, 2024
| https://github.com/python-validators/validators/pull/390#pullrequestreview-2184445645 |
|
View reviewed changes
| https://github.com/python-validators/validators/pull/390/files/999dfac8859401dfa841e3758e89c0ec3ac90da3 |
| nandgator | https://github.com/nandgator |
| https://github.com/python-validators/validators/pull/390#pullrequestreview-2184445645 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| src/validators/domain.py | https://github.com/python-validators/validators/pull/390/files/999dfac8859401dfa841e3758e89c0ec3ac90da3#diff-651b3aa3a93943662c8c3957c9cf27094d772de4e4b8a428eedb9296e57240d3 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| src/validators/domain.py | https://github.com/python-validators/validators/pull/390/files/999dfac8859401dfa841e3758e89c0ec3ac90da3#diff-651b3aa3a93943662c8c3957c9cf27094d772de4e4b8a428eedb9296e57240d3 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| src/validators/domain.py | https://github.com/python-validators/validators/pull/390/files/999dfac8859401dfa841e3758e89c0ec3ac90da3#diff-651b3aa3a93943662c8c3957c9cf27094d772de4e4b8a428eedb9296e57240d3 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| src/validators/domain.py | https://github.com/python-validators/validators/pull/390/files/999dfac8859401dfa841e3758e89c0ec3ac90da3#diff-651b3aa3a93943662c8c3957c9cf27094d772de4e4b8a428eedb9296e57240d3 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
|
| https://github.com/salty-horse |
| More updates | https://github.com/python-validators/validators/pull/390/commits/027319283566ce45326c3ecabad64718ed246d5f |
| 0273192 | https://github.com/python-validators/validators/pull/390/commits/027319283566ce45326c3ecabad64718ed246d5f |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
|
Jul 19, 2024
| https://github.com/python-validators/validators/pull/390#pullrequestreview-2187404379 |
|
View reviewed changes
| https://github.com/python-validators/validators/pull/390/files/027319283566ce45326c3ecabad64718ed246d5f |
| src/validators/domain.py | https://github.com/python-validators/validators/pull/390/files/027319283566ce45326c3ecabad64718ed246d5f#diff-651b3aa3a93943662c8c3957c9cf27094d772de4e4b8a428eedb9296e57240d3 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| src/validators/domain.py | https://github.com/python-validators/validators/pull/390/files/027319283566ce45326c3ecabad64718ed246d5f#diff-651b3aa3a93943662c8c3957c9cf27094d772de4e4b8a428eedb9296e57240d3 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| salty-horse | https://github.com/salty-horse |
| July 19, 2024 09:43 | https://github.com/python-validators/validators/pull/390#commits-pushed-1fa4bb5 |
|
| https://github.com/salty-horse |
| Update _full_cache null test | https://github.com/python-validators/validators/pull/390/commits/1fa4bb52b27c537eb32ad1ad46bcb7d523b3cd2c |
| 1fa4bb5 | https://github.com/python-validators/validators/pull/390/commits/1fa4bb52b27c537eb32ad1ad46bcb7d523b3cd2c |
|
| https://github.com/salty-horse |
| Simplify PYVLD_CACHE_TLD check | https://github.com/python-validators/validators/pull/390/commits/4618dd634f1c08650cdc63086c8ee9da1e5452a7 |
| 4618dd6 | https://github.com/python-validators/validators/pull/390/commits/4618dd634f1c08650cdc63086c8ee9da1e5452a7 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
|
Jul 19, 2024
| https://github.com/python-validators/validators/pull/390#pullrequestreview-2187709325 |
|
View reviewed changes
| https://github.com/python-validators/validators/pull/390/files/4618dd634f1c08650cdc63086c8ee9da1e5452a7 |
| https://github.com/salty-horse |
| salty-horse | https://github.com/salty-horse |
| Jul 19, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2238685052 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
| Jul 19, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2238687938 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
| Jul 19, 2024 | https://github.com/python-validators/validators/pull/390#event-13571135905 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
| 2dc2a9e | https://github.com/python-validators/validators/commit/2dc2a9e5412c92fd7f306d0b45171beb9e87a1e7 |
| Jul 19, 2024 | https://github.com/python-validators/validators/pull/390#event-13571159105 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
| Jul 19, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2238692518 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| https://github.com/salty-horse |
| salty-horse | https://github.com/salty-horse |
| Jul 19, 2024 | https://github.com/python-validators/validators/pull/390#issuecomment-2238700828 |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
|
Aug 9, 2024
| https://github.com/python-validators/validators/pull/390#ref-pullrequest-2454718295 |
|
feat: add extra schemes to url validation
#396
| https://github.com/python-validators/validators/pull/396 |
| https://github.com/davidt99 |
| davidt99 | https://github.com/davidt99 |
|
Sep 2, 2024
| https://github.com/python-validators/validators/pull/390#ref-issue-2500479394 |
|
Release
#398
| https://github.com/python-validators/validators/issues/398 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
|
enhancement
| https://github.com/python-validators/validators/issues?q=state%3Aopen%20label%3Aenhancement |
| Sep 13, 2024 | https://github.com/python-validators/validators/pull/390#event-14241848122 |
| https://github.com/nandgator |
| nandgator | https://github.com/nandgator |
| Sep 13, 2024 | https://github.com/python-validators/validators/pull/390#event-14241848607 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-validators%2Fvalidators%2Fpull%2F390 |
|
| https://github.com/nandgator |
|
nandgator
| https://github.com/nandgator |
|
| https://github.com/python-validators/validators/pull/390/files/4618dd634f1c08650cdc63086c8ee9da1e5452a7 |
|
| https://github.com/nandgator |
|
nandgator
| https://github.com/nandgator |
|
enhancement
| https://github.com/python-validators/validators/issues?q=state%3Aopen%20label%3Aenhancement |
| Please reload this page | https://github.com/python-validators/validators/pull/390 |
|
| https://github.com/salty-horse |
|
| https://github.com/nandgator |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |