René's URL Explorer Experiment


Title: maint: improves `domain` module by nandgator · Pull Request #231 · python-validators/validators · GitHub

Open Graph Title: maint: improves `domain` module by nandgator · Pull Request #231 · python-validators/validators

X Title: maint: improves `domain` module by nandgator · Pull Request #231 · python-validators/validators

Description: Python Data Validation for Humans™. Contribute to python-validators/validators development by creating an account on GitHub.

Open Graph Description: maint: improves domain module Uses type hints, improve docs Regards RFC 1034 and RFC 2782 Updates corresponding test functions Related items Issues Closes Allows commas in domain validator #52 C...

X Description: maint: improves domain module Uses type hints, improve docs Regards RFC 1034 and RFC 2782 Updates corresponding test functions Related items Issues Closes Allows commas in domain validator #52 C...

Opengraph URL: https://github.com/python-validators/validators/pull/231

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4278b576-2661-9ea6-eb1e-9c8b7fd0487d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE03E:16BB5A:CEACC6:10E851A:69923033
html-safe-nonce5c5a301c4b0ab35c53c8d9db491e2e09ac737432084f4a1be3147b62dcb3d320
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDNFOjE2QkI1QTpDRUFDQzY6MTBFODUxQTo2OTkyMzAzMyIsInZpc2l0b3JfaWQiOiIxNTI4Njg2ODU1MDc1Mjc4ODk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7a13110672d2529a060ad2ee5f4d131462ebfc0779fb3d5884a6bff99ce4bf8e
hovercard-subject-tagpull_request:1259822378
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-validators/validators/231/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d6188589bd3eae91cde8259fcdd43207b189b442f20484da0044586832945d59/python-validators/validators/pull/231
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d6188589bd3eae91cde8259fcdd43207b189b442f20484da0044586832945d59/python-validators/validators/pull/231
og:image:altmaint: improves domain module Uses type hints, improve docs Regards RFC 1034 and RFC 2782 Updates corresponding test functions Related items Issues Closes Allows commas in domain validator #52 C...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenandgator
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/python-validators/validators git https://github.com/python-validators/validators.git
octolytics-dimension-user_id113113270
octolytics-dimension-user_loginpython-validators
octolytics-dimension-repository_id13642984
octolytics-dimension-repository_nwopython-validators/validators
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13642984
octolytics-dimension-repository_network_root_nwopython-validators/validators
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-validators/validators/pull/231#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-validators%2Fvalidators%2Fpull%2F231
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-validators%2Fvalidators%2Fpull%2F231
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-validators%2Fvalidators
Reloadhttps://github.com/python-validators/validators/pull/231
Reloadhttps://github.com/python-validators/validators/pull/231
Reloadhttps://github.com/python-validators/validators/pull/231
python-validators https://github.com/python-validators
validatorshttps://github.com/python-validators/validators
Notifications https://github.com/login?return_to=%2Fpython-validators%2Fvalidators
Fork 171 https://github.com/login?return_to=%2Fpython-validators%2Fvalidators
Star 1.1k https://github.com/login?return_to=%2Fpython-validators%2Fvalidators
Code https://github.com/python-validators/validators
Issues 4 https://github.com/python-validators/validators/issues
Pull requests 4 https://github.com/python-validators/validators/pulls
Discussions https://github.com/python-validators/validators/discussions
Actions https://github.com/python-validators/validators/actions
Projects 0 https://github.com/python-validators/validators/projects
Wiki https://github.com/python-validators/validators/wiki
Security 0 https://github.com/python-validators/validators/security
Insights https://github.com/python-validators/validators/pulse
Code https://github.com/python-validators/validators
Issues https://github.com/python-validators/validators/issues
Pull requests https://github.com/python-validators/validators/pulls
Discussions https://github.com/python-validators/validators/discussions
Actions https://github.com/python-validators/validators/actions
Projects https://github.com/python-validators/validators/projects
Wiki https://github.com/python-validators/validators/wiki
Security https://github.com/python-validators/validators/security
Insights https://github.com/python-validators/validators/pulse
nandgatorhttps://github.com/nandgator
python-validators:masterhttps://github.com/python-validators/validators/tree/master
nandgator:workshophttps://github.com/nandgator/pyvalidators/tree/workshop
Conversationhttps://github.com/python-validators/validators/pull/231
Commits1 (1)https://github.com/python-validators/validators/pull/231/commits
Checkshttps://github.com/python-validators/validators/pull/231/checks
Files changedhttps://github.com/python-validators/validators/pull/231/files
maint: improves domain modulehttps://github.com/python-validators/validators/pull/231#top
nandgatorhttps://github.com/nandgator
python-validators:masterhttps://github.com/python-validators/validators/tree/master
nandgator:workshophttps://github.com/nandgator/pyvalidators/tree/workshop
https://github.com/nandgator
nandgatorhttps://github.com/nandgator
Mar 2, 2023https://github.com/python-validators/validators/pull/231#issue-1606093601
Please reload this pagehttps://github.com/python-validators/validators/pull/231
RFC 1034https://www.rfc-editor.org/rfc/rfc1034
RFC 2782https://www.rfc-editor.org/rfc/rfc2782
Allows commas in domain validator #52https://github.com/python-validators/validators/issues/52
ValidationFailure on real domains with accent characters #74https://github.com/python-validators/validators/issues/74
Valid domain name taken as invalid #81https://github.com/python-validators/validators/issues/81
Methods using regex ignore the last \n . #89https://github.com/python-validators/validators/issues/89
valid domain return an invalid error #95https://github.com/python-validators/validators/issues/95
Domain with colons at beginning returns True #120https://github.com/python-validators/validators/issues/120
domain validator fails for fully qualified ("absolute") domain names #124https://github.com/python-validators/validators/issues/124
www.google.com. is not a valid domain #141https://github.com/python-validators/validators/issues/141
Domain not handle None object #143https://github.com/python-validators/validators/issues/143
Falsely detects unicode with FULL STOP as valid domain (eg ⒈com) #199https://github.com/python-validators/validators/issues/199
Bug, hostname with trailing dot throws exception #204https://github.com/python-validators/validators/issues/204
Allow domain with one digit at the beginning or between two dots #114https://github.com/python-validators/validators/pull/114
Updated domain validator coverage #179https://github.com/python-validators/validators/pull/179
Please reload this pagehttps://github.com/python-validators/validators/pull/231
https://github.com/nandgator
nandgatorhttps://github.com/nandgator
review https://github.com/python-validators/validators/issues?q=state%3Aopen%20label%3Areview
Mar 2, 2023https://github.com/python-validators/validators/pull/231#event-8645188518
https://github.com/nandgator
nandgatorhttps://github.com/nandgator
Mar 2, 2023https://github.com/python-validators/validators/pull/231#event-8645188565
https://github.com/nandgator
nandgatorhttps://github.com/nandgator
force-pushedhttps://github.com/python-validators/validators/compare/10a853d556c57bc7ff1d64c378dc884764c0f4af..5e58cb3d0827f72b9867f219e314b2fe1837a05c
10a853dhttps://github.com/python-validators/validators/commit/10a853d556c57bc7ff1d64c378dc884764c0f4af
5e58cb3https://github.com/python-validators/validators/commit/5e58cb3d0827f72b9867f219e314b2fe1837a05c
Compare https://github.com/python-validators/validators/compare/10a853d556c57bc7ff1d64c378dc884764c0f4af..5e58cb3d0827f72b9867f219e314b2fe1837a05c
March 2, 2023 06:30https://github.com/python-validators/validators/pull/231#event-8645743274
https://github.com/nandgator
maint: improves domain modulehttps://github.com/python-validators/validators/pull/231/commits/74898572f824c33e0e3f066bc28c5297647fda21
https://github.com/python-validators/validators/commit/74898572f824c33e0e3f066bc28c5297647fda21#comments
7489857https://github.com/python-validators/validators/pull/231/commits/74898572f824c33e0e3f066bc28c5297647fda21
https://www.rfc-editor.org/rfc/rfc1034https://www.rfc-editor.org/rfc/rfc1034
https://www.rfc-editor.org/rfc/rfc2782https://www.rfc-editor.org/rfc/rfc2782
python-validators#52https://github.com/python-validators/validators/issues/52
python-validators#74https://github.com/python-validators/validators/issues/74
python-validators#81https://github.com/python-validators/validators/issues/81
python-validators#89https://github.com/python-validators/validators/issues/89
python-validators#95https://github.com/python-validators/validators/issues/95
python-validators#120https://github.com/python-validators/validators/issues/120
python-validators#124https://github.com/python-validators/validators/issues/124
python-validators#141https://github.com/python-validators/validators/issues/141
python-validators#143https://github.com/python-validators/validators/issues/143
python-validators#199https://github.com/python-validators/validators/issues/199
python-validators#204https://github.com/python-validators/validators/issues/204
python-validators#114https://github.com/python-validators/validators/pull/114
python-validators#179https://github.com/python-validators/validators/pull/179
https://github.com/nandgator
nandgatorhttps://github.com/nandgator
force-pushedhttps://github.com/python-validators/validators/compare/5e58cb3d0827f72b9867f219e314b2fe1837a05c..74898572f824c33e0e3f066bc28c5297647fda21
5e58cb3https://github.com/python-validators/validators/commit/5e58cb3d0827f72b9867f219e314b2fe1837a05c
7489857https://github.com/python-validators/validators/commit/74898572f824c33e0e3f066bc28c5297647fda21
Compare https://github.com/python-validators/validators/compare/5e58cb3d0827f72b9867f219e314b2fe1837a05c..74898572f824c33e0e3f066bc28c5297647fda21
March 2, 2023 06:33https://github.com/python-validators/validators/pull/231#event-8645758679
https://github.com/nandgator
nandgatorhttps://github.com/nandgator
8f596c3https://github.com/python-validators/validators/commit/8f596c318a63bb39dec3fa33f82af8e1226c810f
Mar 3, 2023https://github.com/python-validators/validators/pull/231#event-8655413981
https://github.com/nandgator
nandgatorhttps://github.com/nandgator
maintenance https://github.com/python-validators/validators/issues?q=state%3Aopen%20label%3Amaintenance
review https://github.com/python-validators/validators/issues?q=state%3Aopen%20label%3Areview
Mar 6, 2023https://github.com/python-validators/validators/pull/231#event-8670607157
https://github.co/hiddenchars
https://github.com/python-validators/validators/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-validators%2Fvalidators%2Fpull%2F231
https://github.com/nandgator
nandgator https://github.com/nandgator
maintenance https://github.com/python-validators/validators/issues?q=state%3Aopen%20label%3Amaintenance
valid domain return an invalid error https://github.com/python-validators/validators/issues/95
Methods using regex ignore the last \n . https://github.com/python-validators/validators/issues/89
Valid domain name taken as invalid https://github.com/python-validators/validators/issues/81
ValidationFailure on real domains with accent characters https://github.com/python-validators/validators/issues/74
Allows commas in domain validator https://github.com/python-validators/validators/issues/52
Domain with colons at beginning returns True https://github.com/python-validators/validators/issues/120
domain validator fails for fully qualified ("absolute") domain names https://github.com/python-validators/validators/issues/124
www.google.com. is not a valid domain https://github.com/python-validators/validators/issues/141
Domain not handle None object https://github.com/python-validators/validators/issues/143
Falsely detects unicode with FULL STOP as valid domain (eg ⒈com) https://github.com/python-validators/validators/issues/199
Please reload this pagehttps://github.com/python-validators/validators/pull/231
https://github.com/nandgator
https://github.com/kvesteri
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.