Title: Incorrect finance Validation Logic · Issue #440 · python-validators/validators · GitHub
Open Graph Title: Incorrect finance Validation Logic · Issue #440 · python-validators/validators
X Title: Incorrect finance Validation Logic · Issue #440 · python-validators/validators
Description: Incorrect finance Validation Logic (possible bug) Hi, while reviewing the finance.py validators (ISIN, CUSIP, SEDOL), I found that the validators contain several issues, and I’d like to confirm whether this is a bug or if I’m missing som...
Open Graph Description: Incorrect finance Validation Logic (possible bug) Hi, while reviewing the finance.py validators (ISIN, CUSIP, SEDOL), I found that the validators contain several issues, and I’d like to confirm whe...
X Description: Incorrect finance Validation Logic (possible bug) Hi, while reviewing the finance.py validators (ISIN, CUSIP, SEDOL), I found that the validators contain several issues, and I’d like to confirm whe...
Opengraph URL: https://github.com/python-validators/validators/issues/440
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect finance Validation Logic","articleBody":"## Incorrect finance Validation Logic (possible bug)\nHi, \nwhile reviewing the `finance.py` validators (ISIN, CUSIP, SEDOL), I found that the validators contain several issues, and I’d like to confirm whether this is a bug or if I’m missing something.\n\nReference to my mutation-testing analysis: \nhttps://github.com/Bolest-oci/mutation-testing/issues/35\n\n### F.e ISIN\nThe official ISIN format is **two uppercase letters, nine alphanumeric characters, and one check digit** (12 characters total). \nHowever, the current validator seems incomplete:\n\n- The Luhn checksum is implemented incorrectly and never computed.\n- The format is not enforced (first two characters should be uppercase letters, last must be a digit).\n- Lowercase letters and invalid characters are accepted.\n- It does not verify that the first two letters form a country code (optional, but usually expected).\n\nI'm thinking of submitting a PR with a fix, but I'm asking first to make sure I'm not missing something. \nThanks! ","author":{"url":"https://github.com/lexendo","@type":"Person","name":"lexendo"},"datePublished":"2025-11-25T01:50:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/440/validators/issues/440"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:dab2e47b-f56f-9093-af69-c6c7705fa22f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 954E:1233C7:46E55:5FB88:698E26DA |
| html-safe-nonce | 050133f27b4663866bcfdd5c5c17e37cb412ee832fe0cc66161998fb12850b01 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTRFOjEyMzNDNzo0NkU1NTo1RkI4ODo2OThFMjZEQSIsInZpc2l0b3JfaWQiOiI2NzAwNDkzNTk0NTI2ODg1NTk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5dc7884b6106f49877705db230937c3de0e588f4b22d270f24fc600a064589b8 |
| hovercard-subject-tag | issue:3661181714 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-validators/validators/440/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f0530011d2e013a086672028f7cde5226be5c6186b4aea539a13ff89a9441519/python-validators/validators/issues/440 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f0530011d2e013a086672028f7cde5226be5c6186b4aea539a13ff89a9441519/python-validators/validators/issues/440 |
| og:image:alt | Incorrect finance Validation Logic (possible bug) Hi, while reviewing the finance.py validators (ISIN, CUSIP, SEDOL), I found that the validators contain several issues, and I’d like to confirm whe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lexendo |
| hostname | github.com |
| expected-hostname | github.com |
| None | a5632af64f7fed7bff1d6a428d1aca1b94fa7a48f760de2d39d9b1effdbf0082 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-validators/validators git https://github.com/python-validators/validators.git |
| octolytics-dimension-user_id | 113113270 |
| octolytics-dimension-user_login | python-validators |
| octolytics-dimension-repository_id | 13642984 |
| octolytics-dimension-repository_nwo | python-validators/validators |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13642984 |
| octolytics-dimension-repository_network_root_nwo | python-validators/validators |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2f1e729d231ea1ea5a098d21f1491b75bea53631 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width