René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Domain validator allows invalid characters in some cases","articleBody":"It appears that, currently, any character is valid for the final character in the gTLD if `rfc1034` is `True`, for example:\r\n```\r\n\u003e\u003e\u003e domain('example.com?', rfc_1034=True, rfc_2782=False)\r\nTrue\r\n\u003e\u003e\u003e domain('example.com!', rfc_1034=True, rfc_2782=False)\r\nTrue\r\n```\r\n\r\nI believe the '.' just needs to be escaped in the pattern string ([link](https://github.com/python-validators/validators/blob/master/src/validators/domain.py#L72)):\r\n```\r\n+ rf\"[a-z]{r'.?$' if rfc_1034 else r'$'}\",\r\n             ^\r\n```\r\n\r\nAlso, it appears question marks are allowed when `rfc_2782` is `True` for domain validation:\r\n```\r\n\u003e\u003e\u003e from validators import domain\r\n\u003e\u003e\u003e domain('example?.com', rfc_1034=False, rfc_2782=True)\r\nTrue\r\n```\r\nThis appears to be from the use of '?' after the '_' inside of a character class:\r\n```\r\nrf\"^(?:[a-z0-9{r'_?'if rfc_2782 else ''}]\"\r\n                  ^\r\n```\r\nPresumably, this is to make the '_' optional, but since metacharacters aren't active in character classes ([link](https://docs.python.org/3/howto/regex.html#:~:text=a%2Dz%5D.-,Metacharacters,-(except%20%5C)%20are)), this is interpreted as a literal '?' instead.  \r\n\r\n","author":{"url":"https://github.com/hagenrd","@type":"Person","name":"hagenrd"},"datePublished":"2024-04-17T22:24:18.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/366/validators/issues/366"}