Title: URL is validated as true if contains brackets or apostrophe signs · Issue #338 · python-validators/validators · GitHub
Open Graph Title: URL is validated as true if contains brackets or apostrophe signs · Issue #338 · python-validators/validators
X Title: URL is validated as true if contains brackets or apostrophe signs · Issue #338 · python-validators/validators
Description: Hello, I am not sure if this is the desired behaviour so I just wanted to check with you. We have had an issue that came up where we wanted to fix a valid cross-site scripting vulnerability in our web application code where the following...
Open Graph Description: Hello, I am not sure if this is the desired behaviour so I just wanted to check with you. We have had an issue that came up where we wanted to fix a valid cross-site scripting vulnerability in our ...
X Description: Hello, I am not sure if this is the desired behaviour so I just wanted to check with you. We have had an issue that came up where we wanted to fix a valid cross-site scripting vulnerability in our ...
Opengraph URL: https://github.com/python-validators/validators/issues/338
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"URL is validated as true if contains brackets or apostrophe signs","articleBody":"Hello, \r\n\r\nI am not sure if this is the desired behaviour so I just wanted to check with you. We have had an issue that came up where we wanted to fix a valid cross-site scripting vulnerability in our web application code where the following malicious code – including apostrophe (`'`) and a round bracket sign ( `)` )– was injected:\r\n\r\n`https://example.org?q=search');alert(document.domain);`\r\n\r\nBut when tried to use the `validators.url()` function it accepts the above as _True_ :\r\n\r\n```\r\n\u003e\u003e\u003e validators.url(\"https://example.org?q=search');alert(document.domain);\")\r\nTrue\r\n```\r\n\r\nApparently this should not happen. The desired behaviour of the `url()` routine is would be _False_ in this case. Do I overlook something or is the above accepted? Let me know if I am missing something or you need further information. My version of validators is 0.23.2 on Python 3.9.6 . \r\n\r\nThank you, \r\nMiklos","author":{"url":"https://github.com/mquartus","@type":"Person","name":"mquartus"},"datePublished":"2024-03-20T12:11:49.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/338/validators/issues/338"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b7b82c80-884e-980f-1eae-72d016973140 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 84E8:14C5A8:1859E7:216E9E:698F2261 |
| html-safe-nonce | 866f2d43cfe5b75037204bd574894ece7ae47a0e3d51c24a74d63401a40ae611 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEU4OjE0QzVBODoxODU5RTc6MjE2RTlFOjY5OEYyMjYxIiwidmlzaXRvcl9pZCI6IjcwNTg2NDQ5MTI5NzYxMTAxNzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1c9a0195d6ea482756a6b57cf2e2996cb12b608ea386025fc38c13b8f9abfdc4 |
| hovercard-subject-tag | issue:2197381760 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-validators/validators/338/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a79684fd48eab8f28370c9fb9bbe1f59912326b4e349b6b9907445860f171ab5/python-validators/validators/issues/338 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a79684fd48eab8f28370c9fb9bbe1f59912326b4e349b6b9907445860f171ab5/python-validators/validators/issues/338 |
| og:image:alt | Hello, I am not sure if this is the desired behaviour so I just wanted to check with you. We have had an issue that came up where we wanted to fix a valid cross-site scripting vulnerability in our ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mquartus |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6102991c714c1a6a27d05fb4f96ea6ca87a6750b4f093b95cc57ed1b84b145a1 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-validators/validators git https://github.com/python-validators/validators.git |
| octolytics-dimension-user_id | 113113270 |
| octolytics-dimension-user_login | python-validators |
| octolytics-dimension-repository_id | 13642984 |
| octolytics-dimension-repository_nwo | python-validators/validators |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13642984 |
| octolytics-dimension-repository_network_root_nwo | python-validators/validators |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1f991dff419ee6d80807c889c647c151386ba074 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width