Title: URLs validation should use urlparse · Issue #189 · python-validators/validators · GitHub
Open Graph Title: URLs validation should use urlparse · Issue #189 · python-validators/validators
X Title: URLs validation should use urlparse · Issue #189 · python-validators/validators
Description: Python already parses URLs, and does it correctly: >>> from urllib.parse import urlparse >>> urlparse('https://google.com') ParseResult(scheme='https', netloc='google.com', path='', params='', query='', fragment='') >>> urlparse('gopher:...
Open Graph Description: Python already parses URLs, and does it correctly: >>> from urllib.parse import urlparse >>> urlparse('https://google.com') ParseResult(scheme='https', netloc='google.com', path='', params='', quer...
X Description: Python already parses URLs, and does it correctly: >>> from urllib.parse import urlparse >>> urlparse('https://google.com') ParseResult(scheme='https', netloc='...
Opengraph URL: https://github.com/python-validators/validators/issues/189
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"URLs validation should use urlparse","articleBody":"Python already parses URLs, and does it correctly:\r\n\r\n```\r\n\u003e\u003e\u003e from urllib.parse import urlparse\r\n\u003e\u003e\u003e urlparse('https://google.com')\r\nParseResult(scheme='https', netloc='google.com', path='', params='', query='', fragment='')\r\n\u003e\u003e\u003e urlparse('gopher://gopher.waynewerner.com')\r\nParseResult(scheme='gopher', netloc='gopher.waynewerner.com', path='', params='', query='', fragment='')\r\n\u003e\u003e\u003e urlparse('tel://555-555-5555')\r\nParseResult(scheme='tel', netloc='555-555-5555', path='', params='', query='', fragment='')\r\n\u003e\u003e\u003e urlparse('file:///path-to-some-file')\r\nParseResult(scheme='file', netloc='', path='/path-to-some-file', params='', query='', fragment='')\r\n\u003e\u003e\u003e urlparse('missing-scheme.com')\r\nParseResult(scheme='', netloc='', path='missing-scheme.com', params='', query='', fragment='')\r\n```\r\n\r\nI had to chase down this library because click-params uses validators to validate URLs, but totally valid URLs aren't parsed correctly because the scheme wasn't expected by this library :disappointed: ","author":{"url":"https://github.com/waynew","@type":"Person","name":"waynew"},"datePublished":"2021-03-23T17:31:59.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/189/validators/issues/189"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0b1510da-758b-34d8-4970-233f85ba415a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AE64:15BF38:6D93AE:904218:698FA53A |
| html-safe-nonce | 4aa9a4d2a768f6be50f8b6b8a2f0a74f5e3a7bf77dd89046829a4c4be3b374ba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTY0OjE1QkYzODo2RDkzQUU6OTA0MjE4OjY5OEZBNTNBIiwidmlzaXRvcl9pZCI6IjY1NDUyMjY1MTk1NzIwOTYzMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f1d9a9a7a837018977fbe610e273eae16706c1811453e93de4e744330bf5483c |
| hovercard-subject-tag | issue:838958831 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-validators/validators/189/issue_layout |
| twitter:image | https://opengraph.githubassets.com/76be09a725a488883fdfbad0ff57ff8f85987ba353f982f9e3a0f07e15ec8997/python-validators/validators/issues/189 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/76be09a725a488883fdfbad0ff57ff8f85987ba353f982f9e3a0f07e15ec8997/python-validators/validators/issues/189 |
| og:image:alt | Python already parses URLs, and does it correctly: >>> from urllib.parse import urlparse >>> urlparse('https://google.com') ParseResult(scheme='https', netloc='google.com', path='', params='', quer... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | waynew |
| hostname | github.com |
| expected-hostname | github.com |
| None | ff0b5286b4f7cd2eb22d357a0ae8fb9a0ae1eaf6abfbae7410c3b315d16414e1 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-validators/validators git https://github.com/python-validators/validators.git |
| octolytics-dimension-user_id | 113113270 |
| octolytics-dimension-user_login | python-validators |
| octolytics-dimension-repository_id | 13642984 |
| octolytics-dimension-repository_nwo | python-validators/validators |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13642984 |
| octolytics-dimension-repository_network_root_nwo | python-validators/validators |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5268d66f533eb3b2e65a6a398a739f35827fd64a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width