| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1363cf29-75cd-7c7c-6a01-c7a7d0de7fd8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7DE:2747BE:22E0BE:31AAAB:6AFDDE08 |
| html-safe-nonce | 7a4dd7b9ec37909c80b1f0650ba7a810abec7059f1a06c48139f2e1be70f7336 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0RFOjI3NDdCRToyMkUwQkU6MzFBQUFCOjZBRkRERTA4IiwidmlzaXRvcl9pZCI6IjMwNjY2NDQ5ODgwMTcxMDY0NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 30fc5538defe7a29ed14738bad357dea6013f14dd49d2b7a95c8d31421c8312d |
| hovercard-subject-tag | pull_request:2871083192 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-trio/unasync/84/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/332059cf7491f8fd16886fb17f97c5493bdecfebdf44989fe5fcaf48159e4390/python-trio/unasync/pull/84 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/332059cf7491f8fd16886fb17f97c5493bdecfebdf44989fe5fcaf48159e4390/python-trio/unasync/pull/84 |
| og:image:alt | I propose to make the unasync functions of Rule public so that custom Rule implementations can more easily inherit from Rule and change the exact replacement mechanisms.
Here are my use-cases that ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | robsdedude |
| hostname | github.com |
| expected-hostname | github.com |
| None | 90d7884679efe0f89b35e0eef84213a75179f38d11a62f2a0af551bbe5110799 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-trio/unasync git https://github.com/python-trio/unasync.git |
| octolytics-dimension-user_id | 26335827 |
| octolytics-dimension-user_login | python-trio |
| octolytics-dimension-repository_id | 154537846 |
| octolytics-dimension-repository_nwo | python-trio/unasync |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 154537846 |
| octolytics-dimension-repository_network_root_nwo | python-trio/unasync |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 89e3d4b2f59ef440fc496c853aee1d9a06a137d6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python-trio/unasync/pull/84#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-trio%2Funasync%2Fpull%2F84 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-trio%2Funasync%2Fpull%2F84 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-trio%2Funasync |
| Reload | https://github.com/python-trio/unasync/pull/84 |
| Reload | https://github.com/python-trio/unasync/pull/84 |
| Reload | https://github.com/python-trio/unasync/pull/84 |
| python-trio | https://github.com/python-trio |
| unasync | https://github.com/python-trio/unasync |
| Code | https://github.com/python-trio/unasync |
| Issues11 (11) | https://github.com/python-trio/unasync/issues |
| Pull requests3 (3) | https://github.com/python-trio/unasync/pulls |
| Actions | https://github.com/python-trio/unasync/actions |
| Projects | https://github.com/python-trio/unasync/projects |
| Security and quality | https://github.com/python-trio/unasync/security |
| Insights | https://github.com/python-trio/unasync/insights |
| https://github.com/python-trio/unasync |
| pquentin | https://github.com/pquentin |
| python-trio:master | https://github.com/python-trio/unasync/tree/master |
| robsdedude:feat/public-rule-unasync-funcs | https://github.com/robsdedude/unasync/tree/feat/public-rule-unasync-funcs |
| Conversation | https://github.com/python-trio/unasync/pull/84 |
| Commits3 (3) | https://github.com/python-trio/unasync/pull/84/commits |
| Checks | https://github.com/python-trio/unasync/pull/84/checks |
| Files changed | https://github.com/python-trio/unasync/pull/84/files |
| Make Rule's unasync functions public for overwriting | https://github.com/python-trio/unasync/pull/84#top |
| pquentin | https://github.com/pquentin |
| python-trio:master | https://github.com/python-trio/unasync/tree/master |
| robsdedude:feat/public-rule-unasync-funcs | https://github.com/robsdedude/unasync/tree/feat/public-rule-unasync-funcs |
|
| https://github.com/robsdedude |
| robsdedude | https://github.com/robsdedude |
| Sep 29, 2025 | https://github.com/python-trio/unasync/pull/84#issue-3465508322 |
| Please reload this page | https://github.com/python-trio/unasync/pull/84 |
|
| https://github.com/robsdedude |
| Make Rule's unasync functions public for overwriting | https://github.com/python-trio/unasync/pull/84/commits/aff9c84d367aa9d0390910490552ae2473ff3e76 |
| aff9c84 | https://github.com/python-trio/unasync/pull/84/commits/aff9c84d367aa9d0390910490552ae2473ff3e76 |
| https://github.com/robsdedude |
| robsdedude | https://github.com/robsdedude |
| force-pushed | https://github.com/python-trio/unasync/compare/5d08d89c911503f25b07ca6afd31f7ddd2f5bbf6..aff9c84d367aa9d0390910490552ae2473ff3e76 |
| 5d08d89 | https://github.com/python-trio/unasync/commit/5d08d89c911503f25b07ca6afd31f7ddd2f5bbf6 |
| aff9c84 | https://github.com/python-trio/unasync/commit/aff9c84d367aa9d0390910490552ae2473ff3e76 |
|
Compare
| https://github.com/python-trio/unasync/compare/5d08d89c911503f25b07ca6afd31f7ddd2f5bbf6..aff9c84d367aa9d0390910490552ae2473ff3e76 |
| September 29, 2025 15:39 | https://github.com/python-trio/unasync/pull/84#event-19987616116 |
| robsdedude | https://github.com/robsdedude |
| September 29, 2025 17:44 | https://github.com/python-trio/unasync/pull/84#commits-pushed-f642a90 |
|
| https://github.com/robsdedude |
| Add changelog entry | https://github.com/python-trio/unasync/pull/84/commits/f642a90ef0ee2bc985d454c467edf3f8ac930428 |
| f642a90 | https://github.com/python-trio/unasync/pull/84/commits/f642a90ef0ee2bc985d454c467edf3f8ac930428 |
|
| https://github.com/pquentin |
| Merge branch 'master' into feat/public-rule-unasync-funcs | https://github.com/python-trio/unasync/pull/84/commits/7566f621f5b0f07f063253b63ac82cbe83147df8 |
| 7566f62 | https://github.com/python-trio/unasync/pull/84/commits/7566f621f5b0f07f063253b63ac82cbe83147df8 |
| https://github.com/pquentin |
| pquentin | https://github.com/pquentin |
|
Feb 5, 2026
| https://github.com/python-trio/unasync/pull/84#pullrequestreview-3755129097 |
|
View reviewed changes
| https://github.com/python-trio/unasync/pull/84/files/7566f621f5b0f07f063253b63ac82cbe83147df8 |
| pquentin | https://github.com/pquentin |
| https://github.com/python-trio/unasync/pull/84#pullrequestreview-3755129097 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python-trio/unasync/pull/84 |
| https://github.com/pquentin |
| pquentin | https://github.com/pquentin |
| 0470588 | https://github.com/python-trio/unasync/commit/0470588fe9ce6f8a8adb4ff50cb8dbd8fc0e1445 |
| Feb 5, 2026 | https://github.com/python-trio/unasync/pull/84#event-22550808262 |
| Please reload this page | https://github.com/python-trio/unasync/pull/84 |
| https://github.com/apps/trio-bot |
| trio-bot | https://github.com/apps/trio-bot |
| Feb 5, 2026 | https://github.com/python-trio/unasync/pull/84#issuecomment-3851677864 |
| @robsdedude | https://github.com/robsdedude |
| member's page | https://github.com/orgs/python-trio/people |
| details | https://help.github.com/en/articles/publicizing-or-hiding-organization-membership |
| here's the relevant section in our contributing guide | https://trio.readthedocs.io/en/latest/contributing.html#joining-the-team |
| humble Python script | https://github.com/python-trio/snekomatic |
| in our chat | https://gitter.im/python-trio/general |
| on our forum | https://trio.discourse.group/c/help-and-advice |
| Please reload this page | https://github.com/python-trio/unasync/pull/84 |
| https://github.com/robsdedude |
| robsdedude | https://github.com/robsdedude |
| February 5, 2026 09:55 | https://github.com/python-trio/unasync/pull/84#event-22553499509 |
| https://github.com/robsdedude |
| robsdedude | https://github.com/robsdedude |
| Feb 5, 2026 | https://github.com/python-trio/unasync/pull/84#issuecomment-3852512533 |
| Please reload this page | https://github.com/python-trio/unasync/pull/84 |
| https://github.co/hiddenchars |
| https://github.com/python-trio/unasync/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-trio%2Funasync%2Fpull%2F84 |
|
| https://github.com/pquentin |
|
pquentin
| https://github.com/pquentin |
|
| https://github.com/python-trio/unasync/pull/84/files/7566f621f5b0f07f063253b63ac82cbe83147df8 |
| Please reload this page | https://github.com/python-trio/unasync/pull/84 |
| Please reload this page | https://github.com/python-trio/unasync/pull/84 |
|
| https://github.com/robsdedude |
|
| https://github.com/pquentin |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |