René's URL Explorer Experiment


Title: Fix from attribute by SimonDamberg · Pull Request #2719 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Fix from attribute by SimonDamberg · Pull Request #2719 · python-telegram-bot/python-telegram-bot

X Title: Fix from attribute by SimonDamberg · Pull Request #2719 · python-telegram-bot/python-telegram-bot

Description: TelegramObject.__getitem__ now raises KeyError instead of returning None, and a special case is made for obj['from'] to look up obj['from_user']. Removed __getitem__ override from Message Test for Message changed to check for KeyError instead of None. Checklist for PRs Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) Created new or adapted existing unit tests Added myself alphabetically to AUTHORS.rst (optional)

Open Graph Description: TelegramObject.__getitem__ now raises KeyError instead of returning None, and a special case is made for obj['from'] to look up obj['from_user']. Removed __getitem__ override from M...

X Description: TelegramObject.__getitem__ now raises KeyError instead of returning None, and a special case is made for obj['from'] to look up obj['from_user']. Removed __getitem__...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/pull/2719

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:71b0758a-1b85-5488-c728-ee196bbd0a3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA45A:17FB7:47C790C:5AB7B5D:6B027935
html-safe-noncef872a1299bf0d7811f12ef4afa67806e69c7be5c8bbc8d71f93e4991af84170b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDVBOjE3RkI3OjQ3Qzc5MEM6NUFCN0I1RDo2QjAyNzkzNSIsInZpc2l0b3JfaWQiOiI4NDA2OTczMjE3NTI4NTEwNzczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac86f34c22330e83cad51f14c1d16b74bb89b148801a2093223bbd2f4ddfebd0ae
hovercard-subject-tagpull_request:754317772
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
twitter:imagehttps://avatars.githubusercontent.com/u/49840909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/49840909?s=400&v=4
og:image:altTelegramObject.__getitem__ now raises KeyError instead of returning None, and a special case is made for obj['from'] to look up obj['from_user']. Removed __getitem__ override from M...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2719%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2719%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
Bibo-Joshihttps://github.com/Bibo-Joshi
python-telegram-bot:v14https://github.com/python-telegram-bot/python-telegram-bot/tree/v14
Conversation 14 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719
Commits 12 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits
Checks 0 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/checks
Files changed https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
Fix from attribute https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#top
Show all changes 12 commits https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
8b5966d Refactor Warnings in ConversationHandler (#2755) Poolitzer Nov 6, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/8b5966d7b50d3f9631d89db13a3ca63d75d33795
bde2a90 Updated behaviour of __getitem__ SimonDamberg Oct 8, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/bde2a90f647db5e229d0bd6e9b69c255469a0c8a
54f91b5 Updated testcase to check for KeyError instead of None SimonDamberg Oct 8, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/54f91b59ef2ecff3db59ed5747289e87beb0459b
7949d0a Removed __getitem__ override SimonDamberg Oct 8, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/7949d0ae14deda521db11f1ebc133467007315e8
377fa7c Added test for from accessing from_user SimonDamberg Oct 11, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/377fa7c12e780d4f20e56842240371ece24a341c
c8b462a Fixed linting SimonDamberg Oct 11, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/c8b462a76f185947876daf3374a804ad3bd5b72b
fd73f6d Address review Bibo-Joshi Nov 19, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/fd73f6dd119f9e5439b58fc2c5448cd1e5e61469
3693212 Documentation Bibo-Joshi Nov 19, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/3693212299ca3984480202209beb42dc94dae899
dc12827 Merge branch 'v14' into fix-from-attribute Bibo-Joshi Nov 21, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/dc12827746122a518926ce77246371d89129dcee
766739c Apply suggestions from code review Bibo-Joshi Nov 21, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/766739cbc9db6516b4a0fa3b9b64e16103de7b76
6dadc33 pre-commit Bibo-Joshi Nov 21, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/6dadc33fa6c3ba7a9c3aa855a509fa8a731bdf05
704aeae versioning Bibo-Joshi Nov 21, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/commits/704aeae561f9480c88fcba4ba2122ddc51eec6b2
Clear filters https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files
_message.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-a9dec124bab0bbe6efcdb93c525ae03d28c86809642c8550d2057b19db8d7bf3
_telegramobject.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-85e3da5ba7fc33ed1139edd7b4b7b81d48eb0c45fe0ff1dcd22528df7c4a6434
test_message.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-a9df67c4518275a00d085ad12aed536385d6a15cf04d2fa186e928f504689a5f
test_telegramobject.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-2a1ef9d60286b6b2b174a8165a5935c1ba1de80480f5977ab3ed85b419126371
telegram/_message.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-a9dec124bab0bbe6efcdb93c525ae03d28c86809642c8550d2057b19db8d7bf3
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/704aeae561f9480c88fcba4ba2122ddc51eec6b2/telegram/_message.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-a9dec124bab0bbe6efcdb93c525ae03d28c86809642c8550d2057b19db8d7bf3
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-a9dec124bab0bbe6efcdb93c525ae03d28c86809642c8550d2057b19db8d7bf3
telegram/_telegramobject.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-85e3da5ba7fc33ed1139edd7b4b7b81d48eb0c45fe0ff1dcd22528df7c4a6434
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/704aeae561f9480c88fcba4ba2122ddc51eec6b2/telegram/_telegramobject.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-85e3da5ba7fc33ed1139edd7b4b7b81d48eb0c45fe0ff1dcd22528df7c4a6434
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-85e3da5ba7fc33ed1139edd7b4b7b81d48eb0c45fe0ff1dcd22528df7c4a6434
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-85e3da5ba7fc33ed1139edd7b4b7b81d48eb0c45fe0ff1dcd22528df7c4a6434
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-85e3da5ba7fc33ed1139edd7b4b7b81d48eb0c45fe0ff1dcd22528df7c4a6434
tests/test_message.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-a9df67c4518275a00d085ad12aed536385d6a15cf04d2fa186e928f504689a5f
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/704aeae561f9480c88fcba4ba2122ddc51eec6b2/tests/test_message.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-a9df67c4518275a00d085ad12aed536385d6a15cf04d2fa186e928f504689a5f
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-a9df67c4518275a00d085ad12aed536385d6a15cf04d2fa186e928f504689a5f
tests/test_telegramobject.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-2a1ef9d60286b6b2b174a8165a5935c1ba1de80480f5977ab3ed85b419126371
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/704aeae561f9480c88fcba4ba2122ddc51eec6b2/tests/test_telegramobject.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-2a1ef9d60286b6b2b174a8165a5935c1ba1de80480f5977ab3ed85b419126371
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-2a1ef9d60286b6b2b174a8165a5935c1ba1de80480f5977ab3ed85b419126371
https://github.com/python-telegram-bot/python-telegram-bot/pull/2719/files#diff-2a1ef9d60286b6b2b174a8165a5935c1ba1de80480f5977ab3ed85b419126371
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.