René's URL Explorer Experiment


Title: Pass job to error handler where possible by Bibo-Joshi · Pull Request #2570 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Pass job to error handler where possible by Bibo-Joshi · Pull Request #2570 · python-telegram-bot/python-telegram-bot

X Title: Pass job to error handler where possible by Bibo-Joshi · Pull Request #2570 · python-telegram-bot/python-telegram-bot

Description: Closes #2568 - at least partly. For jobs that run only once, APS already drops the job from memory before reporting any exception so that we can't get it back by its ID. One could maybe try to work around that somehow by reworking some of the internals of JobQueue (bascially tell APS to run job.run(dispatcher) instead of running the callback directly, but I'm not sure if that's worth it. That would also make it even more complicated for custom persistence solutions like the recently introduced ptbcontrib/ptb_sqlalchemy_jobstore (even though this shouldn't be the main reason to to do it) The main use case probably is to stop repeating jobs that cause exceptions, anyway. Because this adds a new parameter to CallbackContext.from_error, this is maybe kind of breaking if people subclassed for ContextTypes and overrode that. Anyway, not that urgent so I'll be putting it on the v14 milestone for now. edit: We could just make tg.ext.Job callable (where job(dispatcher) just does job.run(dispatcher)). This would probably solve all of the issues mentioned above 🤔 Checklist for PRs Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings - did that but should be updated before merging Created new or adapted existing unit tests

Open Graph Description: Closes #2568 - at least partly. For jobs that run only once, APS already drops the job from memory before reporting any exception so that we can't get it back by its ID. One could maybe try to ...

X Description: Closes #2568 - at least partly. For jobs that run only once, APS already drops the job from memory before reporting any exception so that we can't get it back by its ID. One could maybe try...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/pull/2570

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ab5d5d52-96b2-78e0-42d2-2f0924a68030
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDABC:223EE1:8DDB4D:BAB29D:6B0278F9
html-safe-nonce61b710311ca496c78cdee730aa55e839398ca432c68c1b92449293f0fbfdbbae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUJDOjIyM0VFMTo4RERCNEQ6QkFCMjlEOjZCMDI3OEY5IiwidmlzaXRvcl9pZCI6IjI3ODI0NjI5MDYzMDQ5ODUzMzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacac36b5629e18fd52ea07e4a55d58f5025db01426e98e588416a4e5aacf6f3b33
hovercard-subject-tagpull_request:677202782
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
twitter:imagehttps://avatars.githubusercontent.com/u/22366557?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22366557?s=400&v=4
og:image:altCloses #2568 - at least partly. For jobs that run only once, APS already drops the job from memory before reporting any exception so that we can't get it back by its ID. One could maybe try to ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2570%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2570%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
Bibo-Joshihttps://github.com/Bibo-Joshi
masterhttps://github.com/python-telegram-bot/python-telegram-bot/tree/master
job-error-handlinghttps://github.com/python-telegram-bot/python-telegram-bot/tree/job-error-handling
Conversation 1 https://github.com/python-telegram-bot/python-telegram-bot/pull/2570
Commits 1 https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/commits
Checks 0 https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/checks
Files changed https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
Pass job to error handler where possible https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#top
Show all changes 1 commit https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
f392747 Pass job to error handler where possible Bibo-Joshi Jun 24, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/commits/f3927475a311187fb0e943dc3c2c492a899415bf
Clear filters https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files
callbackcontext.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-6ea94637f214d031dad75e17c46996104b42bddce09e9152811f12277c889303
dispatcher.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
jobqueue.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-7fa0ddef530ade1b4faa3788c11caad821f1fd96118e2d4be5a5fe9cc3020a8a
test_jobqueue.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-604ebef76527742b265682c0ef562d6b19d1a023a4b432e014799fee8ce543b8
telegram/ext/callbackcontext.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-6ea94637f214d031dad75e17c46996104b42bddce09e9152811f12277c889303
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/f3927475a311187fb0e943dc3c2c492a899415bf/telegram/ext/callbackcontext.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-6ea94637f214d031dad75e17c46996104b42bddce09e9152811f12277c889303
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-6ea94637f214d031dad75e17c46996104b42bddce09e9152811f12277c889303
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-6ea94637f214d031dad75e17c46996104b42bddce09e9152811f12277c889303
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-6ea94637f214d031dad75e17c46996104b42bddce09e9152811f12277c889303
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-6ea94637f214d031dad75e17c46996104b42bddce09e9152811f12277c889303
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-6ea94637f214d031dad75e17c46996104b42bddce09e9152811f12277c889303
telegram/ext/dispatcher.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/f3927475a311187fb0e943dc3c2c492a899415bf/telegram/ext/dispatcher.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
telegram/ext/jobqueue.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-7fa0ddef530ade1b4faa3788c11caad821f1fd96118e2d4be5a5fe9cc3020a8a
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/f3927475a311187fb0e943dc3c2c492a899415bf/telegram/ext/jobqueue.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-7fa0ddef530ade1b4faa3788c11caad821f1fd96118e2d4be5a5fe9cc3020a8a
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-7fa0ddef530ade1b4faa3788c11caad821f1fd96118e2d4be5a5fe9cc3020a8a
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-7fa0ddef530ade1b4faa3788c11caad821f1fd96118e2d4be5a5fe9cc3020a8a
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-7fa0ddef530ade1b4faa3788c11caad821f1fd96118e2d4be5a5fe9cc3020a8a
tests/test_jobqueue.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-604ebef76527742b265682c0ef562d6b19d1a023a4b432e014799fee8ce543b8
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/f3927475a311187fb0e943dc3c2c492a899415bf/tests/test_jobqueue.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-604ebef76527742b265682c0ef562d6b19d1a023a4b432e014799fee8ce543b8
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-604ebef76527742b265682c0ef562d6b19d1a023a4b432e014799fee8ce543b8
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-604ebef76527742b265682c0ef562d6b19d1a023a4b432e014799fee8ce543b8
https://github.com/python-telegram-bot/python-telegram-bot/pull/2570/files#diff-604ebef76527742b265682c0ef562d6b19d1a023a4b432e014799fee8ce543b8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.