René's URL Explorer Experiment


Title: Don't call `done_callback` if Promise raises an exception. by starry-shivam · Pull Request #2544 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Don't call `done_callback` if Promise raises an exception. by starry-shivam · Pull Request #2544 · python-telegram-bot/python-telegram-bot

X Title: Don't call `done_callback` if Promise raises an exception. by starry-shivam · Pull Request #2544 · python-telegram-bot/python-telegram-bot

Description: We have made you a wrapper you can't refuse. Contribute to python-telegram-bot/python-telegram-bot development by creating an account on GitHub.

Open Graph Description: Closes #2542

X Description: Closes #2542

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/pull/2544

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5604f331-a99a-68b8-8600-6cce5cd6a015
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7D4:A70A9:26F5608:3325B7E:6B026314
html-safe-nonce6e741a423b9371af3653d7203fb6644da32a0cef031b6abeaaad031dc7850d7d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0Q0OkE3MEE5OjI2RjU2MDg6MzMyNUI3RTo2QjAyNjMxNCIsInZpc2l0b3JfaWQiOiI0NTA2MTUwMjI5ODU0MjgyNTE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac21fe986de44d40480ba8dd8917dbf34320c16d4be56e06cca94f556c84782da2
hovercard-subject-tagpull_request:662352588
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-telegram-bot/python-telegram-bot/2544/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f8f129392a162e6ff3fa9618a78f48b9d7bb1f370945125e38cf667a0c78ebe2/python-telegram-bot/python-telegram-bot/pull/2544
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f8f129392a162e6ff3fa9618a78f48b9d7bb1f370945125e38cf667a0c78ebe2/python-telegram-bot/python-telegram-bot/pull/2544
og:image:altCloses #2542
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestarry-shivam
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2544
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2544
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
Bibo-Joshihttps://github.com/Bibo-Joshi
masterhttps://github.com/python-telegram-bot/python-telegram-bot/tree/master
fix-promisehttps://github.com/python-telegram-bot/python-telegram-bot/tree/fix-promise
Conversationhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
Commits3 (3)https://github.com/python-telegram-bot/python-telegram-bot/pull/2544/commits
Checkshttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544/checks
Files changedhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544/files
Don't call done_callback if Promise raises an exception.https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#top
Bibo-Joshihttps://github.com/Bibo-Joshi
masterhttps://github.com/python-telegram-bot/python-telegram-bot/tree/master
fix-promisehttps://github.com/python-telegram-bot/python-telegram-bot/tree/fix-promise
https://github.com/starry-shivam
starry-shivamhttps://github.com/starry-shivam
Jun 5, 2021https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#issue-912164703
#2542https://github.com/python-telegram-bot/python-telegram-bot/issues/2542
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
https://github.com/starry-shivam
Don't call done_cb on exceptionshttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544/commits/7d65867b414678307800d477029c7382297876fe
7d65867https://github.com/python-telegram-bot/python-telegram-bot/pull/2544/commits/7d65867b414678307800d477029c7382297876fe
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
Jun 5, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#pullrequestreview-676769571
View reviewed changes https://github.com/python-telegram-bot/python-telegram-bot/pull/2544/files/7d65867b414678307800d477029c7382297876fe
telegram/ext/filters.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544/files/7d65867b414678307800d477029c7382297876fe#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
telegram/ext/utils/promise.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544/files/7d65867b414678307800d477029c7382297876fe#diff-46d34d9e7dc603493c5a02103dddaba5b6e73301bb2580277c0aed11af12ec5d
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
https://github.com/harshil21
harshil21https://github.com/harshil21
bug 🐛 https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
Jun 5, 2021https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#event-4846594902
starry-shivamhttps://github.com/starry-shivam
June 5, 2021 18:20https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#commits-pushed-065d856
https://github.com/starry-shivam
https://github.com/Bibo-Joshi
improve docshttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544/commits/065d8561d5fa2c1863613d9963f75ac538c2135e
065d856https://github.com/python-telegram-bot/python-telegram-bot/pull/2544/commits/065d8561d5fa2c1863613d9963f75ac538c2135e
https://github.com/Bibo-Joshi
revert blackhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544/commits/f87b4cbfaf6d7c5d1094867f1b1757632101a140
f87b4cbhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544/commits/f87b4cbfaf6d7c5d1094867f1b1757632101a140
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
Jun 5, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#pullrequestreview-676782651
View reviewed changes https://github.com/python-telegram-bot/python-telegram-bot/pull/2544/files/065d8561d5fa2c1863613d9963f75ac538c2135e
Bibo-Joshihttps://github.com/Bibo-Joshi
https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#pullrequestreview-676782651
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
46cdeb4https://github.com/python-telegram-bot/python-telegram-bot/commit/46cdeb495a0206c1200dc79baa120ff8bf65e6a2
Jun 5, 2021https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#event-4846813394
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
June 5, 2021 15:08https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#event-4846813454
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
Jun 5, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#ref-pullrequest-911469310
proposed fix for #2542: proper treatment of pooled_function exception… #2543 https://github.com/python-telegram-bot/python-telegram-bot/pull/2543
sakibguyhttps://github.com/sakibguy
Jun 6, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#ref-commit-b683ba6
https://github.com/sakibguy
Merge pull requesthttps://github.com/sakibguy/python-telegram-bot/commit/b683ba65bfc2189bbdfd482c2707a90b6da988e3
#3https://github.com/sakibguy/python-telegram-bot/pull/3
from python-telegram-bot/masterhttps://github.com/sakibguy/python-telegram-bot/commit/b683ba65bfc2189bbdfd482c2707a90b6da988e3
b683ba6https://github.com/sakibguy/python-telegram-bot/commit/b683ba65bfc2189bbdfd482c2707a90b6da988e3
python-telegram-bot#2544https://github.com/python-telegram-bot/python-telegram-bot/pull/2544
https://github.com/apps/renovate
renovatehttps://github.com/apps/renovate
Jun 6, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#ref-pullrequest-741954630
chore(deps): update dependency python-telegram-bot to v13 - autoclosed dixneuf19/fip-telegram-bot#8 https://github.com/dixneuf19/fip-telegram-bot/pull/8
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 6, 2021https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#event-4848452314
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
🔌 bug https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%94%8C%20bug%22
bug 🐛 https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
Nov 3, 2024https://github.com/python-telegram-bot/python-telegram-bot/pull/2544#event-15096415864
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2544
https://github.com/Bibo-Joshi
Bibo-Joshi https://github.com/Bibo-Joshi
https://github.com/python-telegram-bot/python-telegram-bot/pull/2544/files/065d8561d5fa2c1863613d9963f75ac538c2135e
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
🔌 bug https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%94%8C%20bug%22
[BUG] promise mistreats pooled_function exceptions as done_callback exceptions https://github.com/python-telegram-bot/python-telegram-bot/issues/2542
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2544
https://github.com/starry-shivam
https://github.com/Bibo-Joshi
https://github.com/harshil21
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.