René's URL Explorer Experiment


Title: Improve timeouts handling in conversation handlers by starry-shivam · Pull Request #2417 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Improve timeouts handling in conversation handlers by starry-shivam · Pull Request #2417 · python-telegram-bot/python-telegram-bot

X Title: Improve timeouts handling in conversation handlers by starry-shivam · Pull Request #2417 · python-telegram-bot/python-telegram-bot

Description: Closes #2407

Open Graph Description: Closes #2407

X Description: Closes #2407

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/pull/2417

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4644e49a-40aa-7a9c-a434-a571707c3860
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CF2:3F8AB1:53BF11F:69F51D0:6B02673F
html-safe-noncef152e57dd664dc84189194f6e61431e4520db6aa2e2def8b82e240e2505559f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0YyOjNGOEFCMTo1M0JGMTFGOjY5RjUxRDA6NkIwMjY3M0YiLCJ2aXNpdG9yX2lkIjoiMzE1OTQyODE3ODY3MDQxMzYzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7efd390dbd8c3cb8cdb8b095b3b919c4eb403718250c9081c5efc677b3aae6ed
hovercard-subject-tagpull_request:585521293
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
twitter:imagehttps://avatars.githubusercontent.com/u/58552395?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58552395?s=400&v=4
og:image:altCloses #2407
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2417%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F2417%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
Bibo-Joshihttps://github.com/Bibo-Joshi
masterhttps://github.com/python-telegram-bot/python-telegram-bot/tree/master
conv-timeouthttps://github.com/python-telegram-bot/python-telegram-bot/tree/conv-timeout
Conversation 56 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417
Commits 19 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits
Checks 0 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/checks
Files changed https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
Improve timeouts handling in conversation handlers https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#top
Show all changes 19 commits https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
c90abef Handle promise states in conversation timeout starry-shivam Mar 5, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/c90abef1f63379e8d70d3ca73cd4772d214ed331
e90c0ae warn if nested conversation & timeout starry-shivam Mar 5, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/e90c0aeb2ab241210db47ebfce9ba845fd7e6061
4ee4955 Add notes and test for conversation_timeout starry-shivam Mar 6, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/4ee495512439294a8e7e07b855adf2bd9137f300
0c6c8f4 Try to fix pre-commit starry-shivam Mar 6, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/0c6c8f49b0c14a1e2b706ea24ed26afbdb613b70
1d368cc Test promise exception starry-shivam Mar 7, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/1d368cc0658f2dfa78967cee792ea6e0215e0485
38f5f21 Welp starry-shivam Mar 7, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/38f5f21fd51e8a7729613ab3a01cebb9c85b11fe
e3cee40 improve docs starry-shivam Mar 7, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/e3cee4049a2532e4d6d53019953e8d22f01bbd10
448e748 typo starry-shivam Mar 7, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/448e74864881376d23841b0188c64aad4058ceba
a2f9b91 Merge branch 'master' into conv-timeout Bibo-Joshi Mar 10, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/a2f9b91dccf11ca48a2cc217df78c660a8792642
31896ac try to fix codecov starry-shivam Mar 11, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/31896acca57c20aeb8deee478ac22028a4645a46
1e5984e refactor timeout logic with promise.add_done_cb starry-shivam Mar 20, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/1e5984e9f21017f14414a6d74586663f072d0af9
3015712 Merge branch 'conv-timeout' of https://github.com/python-telegram-bot… starry-shivam Mar 20, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/30157122482e8391a8b59b1ce5749f52310d8469
23dddfe small fix starry-shivam Mar 20, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/23dddfe5faa99177829ba908b7c31630e552100c
a1e858c Address review starry-shivam Mar 22, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/a1e858c93507dd68de56daed6eae843787539da0
d8555d5 Fix some type hinting Bibo-Joshi Mar 24, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/d8555d5c5762a8b7ad529ee3b0cf2304bc4b9e79
ef9815e Few fixes starry-shivam Mar 24, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/ef9815e48ec86f01cc019fe506f4ae985dbbd85b
9bede76 Merge branch 'conv-timeout' of https://github.com/python-telegram-bot… starry-shivam Mar 24, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/9bede76e7ae762ac559c882c7f206bb9ca3fc9b2
aeceab6 fix tests starry-shivam Mar 24, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/aeceab6b69ff8c0fd73048808be6ee01b1cb98fc
9eba935 minor nitpick starry-shivam Mar 27, 2021 https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/commits/9eba935b113524fea330f7fb17fcfd8db660a3c0
Clear filters https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
conversationhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
promise.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-46d34d9e7dc603493c5a02103dddaba5b6e73301bb2580277c0aed11af12ec5d
test_conversationhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-966893359766932a3cfd1f019efada68f8f9eae6b79651fe1be42da405da8f8f
test_promise.py https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-a3943ac3f3d2dcdb0f08cb0286221b182cb92efcae2b4baf42ed1eb59af6c100
telegram/ext/conversationhandler.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/9eba935b113524fea330f7fb17fcfd8db660a3c0/telegram/ext/conversationhandler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
Poolitzerhttps://github.com/Poolitzer
Apr 29, 2021https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#r622818078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
Poolitzerhttps://github.com/Poolitzer
Apr 29, 2021https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#r622818322
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-3cf4d94165ed37bda70d563d48c8d22f2252dfd1753b86a86958e20622a15d53
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
telegram/ext/utils/promise.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-46d34d9e7dc603493c5a02103dddaba5b6e73301bb2580277c0aed11af12ec5d
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/9eba935b113524fea330f7fb17fcfd8db660a3c0/telegram/ext/utils/promise.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-46d34d9e7dc603493c5a02103dddaba5b6e73301bb2580277c0aed11af12ec5d
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-46d34d9e7dc603493c5a02103dddaba5b6e73301bb2580277c0aed11af12ec5d
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-46d34d9e7dc603493c5a02103dddaba5b6e73301bb2580277c0aed11af12ec5d
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
https://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files#diff-46d34d9e7dc603493c5a02103dddaba5b6e73301bb2580277c0aed11af12ec5d
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/2417/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.