René's URL Explorer Experiment


Title: Refactor msg_in by Bibo-Joshi · Pull Request #1631 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Refactor msg_in by Bibo-Joshi · Pull Request #1631 · python-telegram-bot/python-telegram-bot

X Title: Refactor msg_in by Bibo-Joshi · Pull Request #1631 · python-telegram-bot/python-telegram-bot

Description: As discussed offline, this refactors the Filters.msg_in filter to work as __call__ of Filters.text, thus closing #1625 I encountered two (and a half) obstacles: BaseFilters __call__ is used to perform the update checks, i.e. it executes filter(). To allow for Filters.text({'foo', 'bar'}) anyway, Filters.texts __call__ now checks, if the argument is of type Update. If it's not, it returns an instance of a subclass that works like the former msg_in. An alternative way would be to do something like def __call__(self, update=None, iterable=None): if update: self.filter(update) else: return _TextIterable(iterable) However calling Filters.text(iterable={'foo', 'bar'}) seemed neither convenient nor intuitive for me. Also, usually you won't have to call Filter.text(update) manually anyway … To recreate the caption filter functionality, I needed to add the base class Filters.caption that allows only messages that have a caption. Including caption filtering into Filters.text like Filters.text({'foo', 'bar'}, caption=True) didn't seem very natural to me … If you feel like Filters.caption is unneeded, we can just remove it. The main usecase for this PR is Filters.text(buttons) anyway … I wasn't very original in naming the subclasses (_TextIterable and _CaptionIterable). If you have a better naming idea, please tell :)

Open Graph Description: As discussed offline, this refactors the Filters.msg_in filter to work as __call__ of Filters.text, thus closing #1625 I encountered two (and a half) obstacles: BaseFilters __call__ is used to pe...

X Description: As discussed offline, this refactors the Filters.msg_in filter to work as __call__ of Filters.text, thus closing #1625 I encountered two (and a half) obstacles: BaseFilters __call__ is used to pe...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/pull/1631

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3c614ac8-4512-b609-cf7b-ab71bae6b1bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDB2:27CA4:CB602F:10C1198:6B027912
html-safe-nonce0bcaba3d0326986793b929d8705ef7a63c2abffcd6a9f3de897c16d6f2f8b7ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREIyOjI3Q0E0OkNCNjAyRjoxMEMxMTk4OjZCMDI3OTEyIiwidmlzaXRvcl9pZCI6IjMzNTkyMTQzOTc4Mjk1NzY5NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac56e5b98997a280459d4466016508e0f230dcff175ab46acb6721e052e57e9bac
hovercard-subject-tagpull_request:343526395
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
twitter:imagehttps://avatars.githubusercontent.com/u/22366557?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22366557?s=400&v=4
og:image:altAs discussed offline, this refactors the Filters.msg_in filter to work as __call__ of Filters.text, thus closing #1625 I encountered two (and a half) obstacles: BaseFilters __call__ is used to pe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F1631%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F1631%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
Eldinniehttps://github.com/Eldinnie
masterhttps://github.com/python-telegram-bot/python-telegram-bot/tree/master
refactor_msg_inhttps://github.com/python-telegram-bot/python-telegram-bot/tree/refactor_msg_in
Conversation 9 https://github.com/python-telegram-bot/python-telegram-bot/pull/1631
Commits 4 https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/commits
Checks 0 https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/checks
Files changed https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
Refactor msg_in https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#top
Show all changes 4 commits https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
30e0e53 Revert "Add msg_in filter (new) (#1570)" Bibo-Joshi Nov 20, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/commits/30e0e532a8dda3b7c50cbc4d1fd06ebf52177749
e7076e6 Refactor msg_in, add Filters.caption on the fly Bibo-Joshi Nov 20, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/commits/e7076e660dcf51c953498767684bcfa3c0fdb017
f43f2f1 Update docstrings Bibo-Joshi Nov 25, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/commits/f43f2f1dcc563c4b370911aa4d4e934d7fcc95db
9fac4c5 Fix copy-paste typo Bibo-Joshi Nov 25, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/commits/9fac4c5827f7bf7893d1811aeb3d857f32c24c79
Clear filters https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
AUTHORS.rst https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-4e28079e8f9a4e208ee815c55aa8f1d87ca0698da61f044486ca60de48e7a525
filters.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
test_filters.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-c42c96171310ba36a50fc20ad759507f08aa8212df793d97e33579522ffb39c4
AUTHORS.rsthttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-4e28079e8f9a4e208ee815c55aa8f1d87ca0698da61f044486ca60de48e7a525
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/9fac4c5827f7bf7893d1811aeb3d857f32c24c79/AUTHORS.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-4e28079e8f9a4e208ee815c55aa8f1d87ca0698da61f044486ca60de48e7a525
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-4e28079e8f9a4e208ee815c55aa8f1d87ca0698da61f044486ca60de48e7a525
telegram/ext/filters.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/9fac4c5827f7bf7893d1811aeb3d857f32c24c79/telegram/ext/filters.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-6260592e9e0d28a464b383edf7c50a882910ff6d502f609313dc44e3cbfdae6c
tests/test_filters.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-c42c96171310ba36a50fc20ad759507f08aa8212df793d97e33579522ffb39c4
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/9fac4c5827f7bf7893d1811aeb3d857f32c24c79/tests/test_filters.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-c42c96171310ba36a50fc20ad759507f08aa8212df793d97e33579522ffb39c4
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-c42c96171310ba36a50fc20ad759507f08aa8212df793d97e33579522ffb39c4
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-c42c96171310ba36a50fc20ad759507f08aa8212df793d97e33579522ffb39c4
https://github.com/python-telegram-bot/python-telegram-bot/pull/1631/files#diff-c42c96171310ba36a50fc20ad759507f08aa8212df793d97e33579522ffb39c4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.