René's URL Explorer Experiment


Title: bot_data as global memory by Bibo-Joshi · Pull Request #1322 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: bot_data as global memory by Bibo-Joshi · Pull Request #1322 · python-telegram-bot/python-telegram-bot

X Title: bot_data as global memory by Bibo-Joshi · Pull Request #1322 · python-telegram-bot/python-telegram-bot

Description: This PR implements the global memory proposed in #1318 by providing a dictionary bot_data in addition to user_data and chat_data. I've integrated bot_data in the dispatcher class and the handler classes. Since the bot_data is a global memory, I've also integrated it in those handlers, that are not meant for telegram.Updates (e.g. StringCommandHandler). Integration in persistence is also provided. Note, that in update_bot_data, the data is updated by self.bot_data = data.copy() in contrast to the current implentation for user/chat_data self.user_data[chat_id] = data This is to avoid problems as described in #1297. However, to leave this PR self-contained, I didn't change it for user_data and chat_data. In DictPersistence, I just used json.loads() to decode serialized data. For user_data and chat_data, a function from the helpers module is used to allow integer keys. imo, this is not really necessary and may lead to problems (e.g. when using '3' as a key, that will be decoded as 3), so I left it out. If I just didn't get the point of it, I will gladly add this. Also, I've started to adjust the test routines. I will add them, once I get make test to work again (see #1321 )

Open Graph Description: This PR implements the global memory proposed in #1318 by providing a dictionary bot_data in addition to user_data and chat_data. I've integrated bot_data in the dispatcher class and the handle...

X Description: This PR implements the global memory proposed in #1318 by providing a dictionary bot_data in addition to user_data and chat_data. I've integrated bot_data in the dispatcher class and the ha...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/pull/1322

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:94c98c84-f076-e20f-be5c-5722cebc1b98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6F6:223EE1:8D705D:BA283A:6B0278CC
html-safe-nonceb6a257a469f716b9cd00d02cdcf02dd6e06c2dc2c56e1753d513c17e0dfa1f38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkY2OjIyM0VFMTo4RDcwNUQ6QkEyODNBOjZCMDI3OENDIiwidmlzaXRvcl9pZCI6IjY4OTI4NTk1OTYyODE2NDExNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc4053e81ba5deb64c01bb861d28992e52a774599025a53880731479168c70b3b
hovercard-subject-tagpull_request:242742755
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
twitter:imagehttps://avatars.githubusercontent.com/u/22366557?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22366557?s=400&v=4
og:image:altThis PR implements the global memory proposed in #1318 by providing a dictionary bot_data in addition to user_data and chat_data. I've integrated bot_data in the dispatcher class and the handle...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F1322%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F1322%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
Bibo-Joshihttps://github.com/Bibo-Joshi
python-telegram-bot:masterhttps://github.com/python-telegram-bot/python-telegram-bot/tree/master
Conversation 2 https://github.com/python-telegram-bot/python-telegram-bot/pull/1322
Commits 3 https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/commits
Checks 0 https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/checks
Files changed https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
bot_data as global memory https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#top
Show all changes 3 commits https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
39db13f Add bot_data as global memory Jan 7, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/commits/39db13f6689fb8ad326dda53633b5418702787ab
2cd9b40 Fix bot_data initialization by Dispatcher Jan 7, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/commits/2cd9b4008f122d761bfed937931441fdf7732724
cf94485 Undo change in PicklePersistence Jan 7, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/commits/cf9448509b9da83fd4df1350cff0105c5804401e
Clear filters https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
basepersistence.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
callbackqueryhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-fcd0121353e8adc4932824742154029ea466dbe2eeefb011d2922a67d2c2bfd9
choseninlineresulthandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-b9b2b3979b2f94c6a992fbfd59df9e5fae154c29832beb89664688452ef38fe8
commandhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-71a298b187835b428f86d4f7bb5adceb489ed900036a4b9bebf7495a6e7975ca
dictpersistence.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
dispatcher.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-f88ded2bad521b4f29f6581172da343e5767e97d243abe871cd4edb5ad9c9ebe
handler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-0e7004c0674bf6efa17b7e8a739ee75291477e0e84c508e52bea0f93a530e880
inlinequeryhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-5a42014c14adfedb2469c92e0f0df6ebc417f4196c3e4b9e07b1f9190b7b37c0
messagehandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-779dd6103ae2b10c4dc6140cbf1f55334998699e8b2c00113a5ffdf71255680b
picklepersistence.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
precheckoutqueryhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-d4a87cb85e59c65ab8a4b7b55f1f28c83f6109dd8e0ccf5490ef719a69d026e4
regexhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-554cc483740f586f1fddea1455d754bb8a09690c93be6955cd1b1493e565bea1
shippingqueryhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-167d0970c469b2da90f0e0c76e399aa8b0361d1b9698f65235084ff5c488098a
stringcommandhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-3659d912b17843cbefbd2be7d47c4798e44e321e0ae0a971ddc8fe2d7d432739
stringregexhandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-2e4def251a039852920bac5d77fc56f54f1c295a231de87c5c8e872390e7c348
typehandler.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-80e95aeaa45675b8fa20675d25e92f2871c6c48f20e9a2c5096432ccfe815ddd
telegram/ext/basepersistence.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/cf9448509b9da83fd4df1350cff0105c5804401e/telegram/ext/basepersistence.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
telegram/ext/callbackqueryhandler.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-fcd0121353e8adc4932824742154029ea466dbe2eeefb011d2922a67d2c2bfd9
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/cf9448509b9da83fd4df1350cff0105c5804401e/telegram/ext/callbackqueryhandler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-fcd0121353e8adc4932824742154029ea466dbe2eeefb011d2922a67d2c2bfd9
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-fcd0121353e8adc4932824742154029ea466dbe2eeefb011d2922a67d2c2bfd9
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-fcd0121353e8adc4932824742154029ea466dbe2eeefb011d2922a67d2c2bfd9
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-fcd0121353e8adc4932824742154029ea466dbe2eeefb011d2922a67d2c2bfd9
telegram/ext/choseninlineresulthandler.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-b9b2b3979b2f94c6a992fbfd59df9e5fae154c29832beb89664688452ef38fe8
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/cf9448509b9da83fd4df1350cff0105c5804401e/telegram/ext/choseninlineresulthandler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-b9b2b3979b2f94c6a992fbfd59df9e5fae154c29832beb89664688452ef38fe8
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-b9b2b3979b2f94c6a992fbfd59df9e5fae154c29832beb89664688452ef38fe8
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-b9b2b3979b2f94c6a992fbfd59df9e5fae154c29832beb89664688452ef38fe8
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-b9b2b3979b2f94c6a992fbfd59df9e5fae154c29832beb89664688452ef38fe8
telegram/ext/commandhandler.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-71a298b187835b428f86d4f7bb5adceb489ed900036a4b9bebf7495a6e7975ca
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/cf9448509b9da83fd4df1350cff0105c5804401e/telegram/ext/commandhandler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-71a298b187835b428f86d4f7bb5adceb489ed900036a4b9bebf7495a6e7975ca
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-71a298b187835b428f86d4f7bb5adceb489ed900036a4b9bebf7495a6e7975ca
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-71a298b187835b428f86d4f7bb5adceb489ed900036a4b9bebf7495a6e7975ca
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-71a298b187835b428f86d4f7bb5adceb489ed900036a4b9bebf7495a6e7975ca
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-71a298b187835b428f86d4f7bb5adceb489ed900036a4b9bebf7495a6e7975ca
telegram/ext/dictpersistence.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/cf9448509b9da83fd4df1350cff0105c5804401e/telegram/ext/dictpersistence.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1322/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.