René's URL Explorer Experiment


Title: Fix and enhance PicklePersistence: deepcopy by Bibo-Joshi · Pull Request #1301 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Fix and enhance PicklePersistence: deepcopy by Bibo-Joshi · Pull Request #1301 · python-telegram-bot/python-telegram-bot

X Title: Fix and enhance PicklePersistence: deepcopy by Bibo-Joshi · Pull Request #1301 · python-telegram-bot/python-telegram-bot

Description: As reported in #1297, the use of shallow copies in PicklePersistence leads to data not being persisted. Same holds for DictPersistence A fix would be the use of copy.deepcopy, which however may become time consuming for large data sets. I therefore implemented an additional argument on_update for Pickle/DictPersistence that let's you choose wether to check for updates before dumping or not. If on_update = False, checking is obmitted and one can skip time consuming deepcopies (i.e. just pass the actual data). If on_update = True, deepcopies are used.

Open Graph Description: As reported in #1297, the use of shallow copies in PicklePersistence leads to data not being persisted. Same holds for DictPersistence A fix would be the use of copy.deepcopy, which however may bec...

X Description: As reported in #1297, the use of shallow copies in PicklePersistence leads to data not being persisted. Same holds for DictPersistence A fix would be the use of copy.deepcopy, which however may bec...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/pull/1301

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:66303a0d-4f23-71fd-4b35-d8f1650497e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8002:BB75:297BEEC:3691918:6B0278AD
html-safe-noncecccb73a664be1f9819a9164e1b98eb008ad1219ebfdbd0f8768edf0362df0d36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDAyOkJCNzU6Mjk3QkVFQzozNjkxOTE4OjZCMDI3OEFEIiwidmlzaXRvcl9pZCI6IjY0NTU5Njc0MDExNDkzNjQzOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7058f2f39c70ad409a504e879e03747ee1bd90bfdcbaa5c71a9231a90136ba15
hovercard-subject-tagpull_request:233372982
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
twitter:imagehttps://avatars.githubusercontent.com/u/22366557?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22366557?s=400&v=4
og:image:altAs reported in #1297, the use of shallow copies in PicklePersistence leads to data not being persisted. Same holds for DictPersistence A fix would be the use of copy.deepcopy, which however may bec...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F1301%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fpull%2F1301%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2Fnew%2Fchoose
Bibo-Joshihttps://github.com/Bibo-Joshi
python-telegram-bot:masterhttps://github.com/python-telegram-bot/python-telegram-bot/tree/master
Conversation 4 https://github.com/python-telegram-bot/python-telegram-bot/pull/1301
Commits 5 https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/commits
Checks 0 https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/checks
Files changed https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
Fix and enhance PicklePersistence: deepcopy https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#top
Show all changes 5 commits https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
b7d10f7 Fix and enhance PicklePersistence: deepcopy Nov 22, 2018 https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/commits/b7d10f7f6231826a330ff8ba8141303fc12db9d7
62db914 Fix and enhance DictPersistence: deepcopy Jan 13, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/commits/62db91443e6ed4a893ac51ba4e14bda8a74251ef
be20c27 Adjust test_persistence.py Jan 13, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/commits/be20c274bb370c4d2d13e4db8bbbff3bd4fde308
caeb3b3 Merge branch 'master' into pp-deep-copy Bibo-Joshi Jan 13, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/commits/caeb3b316ff75f944621b90cb3db3feaebf411a2
b5a6b73 Fix Codacy issues Jan 13, 2019 https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/commits/b5a6b73da6c8086a084115b50dd86c68c4a8592e
Clear filters https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
Please reload this pagehttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files
basepersistence.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
dictpersistence.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
picklepersistence.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
test_persistence.py https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
telegram/ext/basepersistence.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/b5a6b73da6c8086a084115b50dd86c68c4a8592e/telegram/ext/basepersistence.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-66273af16d9dbb58e6758351318d8629d075979b82d8f6e0ad0f3f33f213f58d
telegram/ext/dictpersistence.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/b5a6b73da6c8086a084115b50dd86c68c4a8592e/telegram/ext/dictpersistence.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-685fbb03e9542afcfaa368fcd606e194d684d8dab9c38265102bbed89e5f0b7c
telegram/ext/picklepersistence.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/b5a6b73da6c8086a084115b50dd86c68c4a8592e/telegram/ext/picklepersistence.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-69b5504b9c00565b26b73f0fc6c026108c0eaf1dab90a570986388e2d4c96f4c
tests/test_persistence.pyhttps://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
View file https://github.com/python-telegram-bot/python-telegram-bot/blob/b5a6b73da6c8086a084115b50dd86c68c4a8592e/tests/test_persistence.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/{{ revealButtonHref }}
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com/python-telegram-bot/python-telegram-bot/pull/1301/files#diff-d04e4aa4ef583d9618a01bafa941f0cd1046a525cb2018673ec9b34e78a5d07e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.