Title: Error handlers not working with @run_async · Issue #682 · python-telegram-bot/python-telegram-bot · GitHub
Open Graph Title: Error handlers not working with @run_async · Issue #682 · python-telegram-bot/python-telegram-bot
X Title: Error handlers not working with @run_async · Issue #682 · python-telegram-bot/python-telegram-bot
Description: Steps to reproduce Register any handler, for ex: CommandHandler; Write some code to get TelegramException (ex: invalid Markdown/HTML); Register error handler; Run it. Example code: import logging from telegram import Update, Bot, ParseMo...
Open Graph Description: Steps to reproduce Register any handler, for ex: CommandHandler; Write some code to get TelegramException (ex: invalid Markdown/HTML); Register error handler; Run it. Example code: import logging f...
X Description: Steps to reproduce Register any handler, for ex: CommandHandler; Write some code to get TelegramException (ex: invalid Markdown/HTML); Register error handler; Run it. Example code: import logging f...
Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/682
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Error handlers not working with @run_async","articleBody":"### Steps to reproduce\r\n1. Register any handler, for ex: `CommandHandler`;\r\n2. Write some code to get `TelegramException` (ex: invalid Markdown/HTML);\r\n3. Register error handler;\r\n4. Run it.\r\n\r\nExample code:\r\n\r\n```python\r\nimport logging\r\n\r\nfrom telegram import Update, Bot, ParseMode\r\nfrom telegram.ext import Updater, CommandHandler\r\nfrom telegram.ext.dispatcher import run_async\r\n\r\nupdater = Updater('\u003ctelegram_token>')\r\n\r\nlogging.basicConfig(\r\n format='%(asctime)s - %(name)s - %(levelname)s - %(message)s',\r\n level=logging.INFO\r\n)\r\nlogger = logging.getLogger(__name__)\r\n\r\ndispatcher = updater.dispatcher\r\n\r\nmsg = \"\u003cinvalid_tag>Bold line\"\r\n\r\n\r\ndef action_start(bot: Bot, update: Update):\r\n logger.info('/start')\r\n update.message.reply_text(msg, parse_mode=ParseMode.HTML)\r\n\r\n\r\n@run_async\r\ndef action_async_start(bot: Bot, update: Update):\r\n logger.info('/async_start')\r\n update.message.reply_text(msg, parse_mode=ParseMode.HTML)\r\n\r\n\r\ndef _error(bot: Bot, update: Update, e: BaseException):\r\n logger.error(\"Boom!\")\r\n\r\n\r\ndp = updater.dispatcher\r\n\r\ndp.add_handler(CommandHandler('start', action_start))\r\ndp.add_handler(CommandHandler('async_start', action_async_start))\r\n\r\ndp.add_error_handler(_error)\r\n\r\nupdater.start_polling()\r\nupdater.idle()\r\n\r\n```\r\n\r\n\r\n### Expected behavior\r\nError handler will catch `TelegramException`, so handler could manage it.\r\n\r\n### Actual behavior\r\nError handler is not called.\r\n\r\n### Configuration\r\n**Version of Python, python-telegram-bot & dependencies:**\r\n```\r\npython-telegram-bot 6.0.2\r\nurllib3 1.21.1\r\ncertifi 2017.04.17\r\nfuture 0.16.0\r\nPython 3.5.2 (v3.5.2:4def2a2901a5, Jun 26 2016, 10:47:25) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)]\r\n```\r\n\r\n### Logs\r\nCommands to send:\r\n```\r\n/start\r\n/async_start\r\n```\r\n\r\nOutput:\r\n```\r\n\u003cproject_path>/venv/bin/python \u003cproject_path>/issue.py\r\n2017-06-20 23:24:11,743 - __main__ - INFO - /start\r\n2017-06-20 23:24:11,906 - telegram.ext.dispatcher - WARNING - A TelegramError was raised while processing the Update.\r\n2017-06-20 23:24:11,907 - __main__ - ERROR - Boom!\r\n2017-06-20 23:24:11,907 - __main__ - INFO - /async_start\r\n2017-06-20 23:24:12,188 - telegram.utils.promise - ERROR - An uncaught error was raised while running the promise\r\nTraceback (most recent call last):\r\n File \"\u003cproject_path>/venv/src/python-telegram-bot/telegram/utils/promise.py\", line 42, in run\r\n self._result = self.pooled_function(*self.args, **self.kwargs)\r\n File \"\u003cproject_path>/issue.py\", line 25, in action_async_start\r\n update.message.reply_text(msg, parse_mode=ParseMode.HTML)\r\n File \"\u003cproject_path>/venv/src/python-telegram-bot/telegram/message.py\", line 340, in reply_text\r\n return self.bot.send_message(self.chat_id, *args, **kwargs)\r\n File \"\u003cproject_path>/venv/src/python-telegram-bot/telegram/bot.py\", line 125, in decorator\r\n result = func(self, *args, **kwargs)\r\n File \"\u003cproject_path>/venv/src/python-telegram-bot/telegram/bot.py\", line 158, in decorator\r\n return Bot._message_wrapper(self, url, data, *args, **kwargs)\r\n File \"\u003cproject_path>/venv/src/python-telegram-bot/telegram/bot.py\", line 146, in _message_wrapper\r\n result = self._request.post(url, data, timeout=kwargs.get('timeout'))\r\n File \"\u003cproject_path>/venv/src/python-telegram-bot/telegram/utils/request.py\", line 252, in post\r\n **urlopen_kwargs)\r\n File \"\u003cproject_path>/venv/src/python-telegram-bot/telegram/utils/request.py\", line 194, in _request_wrapper\r\n raise BadRequest(message)\r\ntelegram.error.BadRequest: Can't parse entities in message text: unsupported start tag \"invalid_tag\" at byte offset 0\r\n\r\nProcess finished with exit code 0\r\n```\r\n\r\nI suppose, `dispatcher.dispatch_error` should be called in the same thread with async handler.","author":{"url":"https://github.com/s-chizhik","@type":"Person","name":"s-chizhik"},"datePublished":"2017-06-20T20:42:12Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/682"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e14dac46-b26a-dc98-daa9-19142f393bc4 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CEA0:395CE9:31A55:3DB0C:6B028C69 |
| html-safe-nonce | a82c6fda105e8a6fa4d1d8d888b9c4968189f7284490ccebed3a124934df005f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUEwOjM5NUNFOTozMUE1NTozREIwQzo2QjAyOEM2OSIsInZpc2l0b3JfaWQiOiI1MzE3Nzg0NTY2NDQ1MDE4MjE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ae5cb9b383b18417e4e68d96d2bd8845fcc39ffb6edbb42a259515b9603b2688 |
| hovercard-subject-tag | issue:237339001 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/682/issue_layout |
| twitter:image | https://opengraph.githubassets.com/eefbc120cdbd696d56b60eb2a10cbce2cc121b10000ae86198c54d825199339f/python-telegram-bot/python-telegram-bot/issues/682 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eefbc120cdbd696d56b60eb2a10cbce2cc121b10000ae86198c54d825199339f/python-telegram-bot/python-telegram-bot/issues/682 |
| og:image:alt | Steps to reproduce Register any handler, for ex: CommandHandler; Write some code to get TelegramException (ex: invalid Markdown/HTML); Register error handler; Run it. Example code: import logging f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | s-chizhik |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git |
| octolytics-dimension-user_id | 16178365 |
| octolytics-dimension-user_login | python-telegram-bot |
| octolytics-dimension-repository_id | 38696925 |
| octolytics-dimension-repository_nwo | python-telegram-bot/python-telegram-bot |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38696925 |
| octolytics-dimension-repository_network_root_nwo | python-telegram-bot/python-telegram-bot |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width