René's URL Explorer Experiment


Title: Centralize all `de_json`'s into `TelegramObject` · Issue #5189 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Centralize all `de_json`'s into `TelegramObject` · Issue #5189 · python-telegram-bot/python-telegram-bot

X Title: Centralize all `de_json`'s into `TelegramObject` · Issue #5189 · python-telegram-bot/python-telegram-bot

Description: What kind of feature are you missing? Where do you notice a shortcoming of PTB? Something I've wanted to do for a while is reduce duplication of de_json throughout the library. As of today, de_json is typically doing 4 things: Converting...

Open Graph Description: What kind of feature are you missing? Where do you notice a shortcoming of PTB? Something I've wanted to do for a while is reduce duplication of de_json throughout the library. As of today, de_json...

X Description: What kind of feature are you missing? Where do you notice a shortcoming of PTB? Something I've wanted to do for a while is reduce duplication of de_json throughout the library. As of today, de_...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/5189

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Centralize all `de_json`'s into `TelegramObject`","articleBody":"### What kind of feature are you missing? Where do you notice a shortcoming of PTB?\n\nSomething I've wanted to do for a while is reduce duplication of `de_json` throughout the library. As of today, `de_json` is typically doing 4 things:\n\n- Converting unix timestamps to datetimes\n- Converting dict -> TelegramObject's obviously\n- Handling Sequence inputs with `TO.de_list`\n- Decide which class would be created depending on a field like `type` (i.e. `ChatMember` classes and the like). I'll hereby refer to these kinds as _`_de_json` delegators_.\n\n### Describe the solution you'd like\n\nI propose handling `de_json` by doing type introspection of classes. With that, one can know what kind of _transformation_ (i.e. lambdas) to apply for every field. \n\nType inspection, however, is an expensive operation on every `de_json` call. But if you combine that with per class caching, there would be ~no runtime cost of this approach compared to what we have today.\n\n## Implementation details\n\n### The primary cache\n\nThe basic idea is to introduce a class variable, `__DE_JSON_PLAN__`, which is going to be the per-class dict cache of field names -> transformations. This will be populated on the _first_ call to `de_json` for that particular class. `de_json` will then simply iterate through the data and apply the transformation if it's needed.\n\n### Handling `de_json` delegators\n\nFor these classes, we'll still have to manually define a mapping as another class variable (`__DE_JSON_DISPATCH__`). This would be telling `de_json` what field name to delegate on, e.g. `status` or `type`, and the mapping of that value -> class. On every `de_json` call, this mapping is used to decide which class is going to be instantiated.\n\n### Supporting deprecated fields from the API\n\n`de_json` currently also removes a few deprecated fields like `can_send_media_messages` and places them into `api_kwargs`. With this implementation, a subclass can simply define another class variable, `__REMOVED_API_FIELDS__`, which will hold that information. `de_json` will move the data to `api_kwargs`.\n\n### Describe alternatives you've considered\n\nUsing another (de)serialization library like mentioned in #2698. Adding another third party dependency however is not very appealing, specially in this day and age.\n\n### Additional context\n\nI have a draft PoC up at #5186. Initial performance benchmarks show -15% to a +20% performance gain. See that PR description for details on that benchmark\n\nAny thoughts / alternative approaches are welcome!","author":{"url":"https://github.com/harshil21","@type":"Person","name":"harshil21"},"datePublished":"2026-03-31T10:29:22Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/5189"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9d42f071-ccd8-4e97-f0ce-b177af499f17
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBED6:13B36F:421A0D:52A4E4:6B02A22E
html-safe-noncebf90a6a62e14b77c9e22b75bd0bf9feb01036029194daa97532ab6bf996c8cf9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUQ2OjEzQjM2Rjo0MjFBMEQ6NTJBNEU0OjZCMDJBMjJFIiwidmlzaXRvcl9pZCI6IjM0NjI5NTA5MzYyMDM0MDM4MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfbdf3191e7ffa58dd32784b6eba0186c9423bd0a8e2d66cf89fec646b6be3a60
hovercard-subject-tagissue:4177981660
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/5189/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bbd1190159761568cbcf721f07865a3574564dbca84fa580904df6df7cc9899c/python-telegram-bot/python-telegram-bot/issues/5189
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bbd1190159761568cbcf721f07865a3574564dbca84fa580904df6df7cc9899c/python-telegram-bot/python-telegram-bot/issues/5189
og:image:altWhat kind of feature are you missing? Where do you notice a shortcoming of PTB? Something I've wanted to do for a while is reduce duplication of de_json throughout the library. As of today, de_json...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameharshil21
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/5189#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F5189
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F5189
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/5189
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/5189
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/5189
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/5189
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/5189
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
#5186https://github.com/python-telegram-bot/python-telegram-bot/pull/5186
Centralize all de_json's into TelegramObjecthttps://github.com/python-telegram-bot/python-telegram-bot/issues/5189#top
#5186https://github.com/python-telegram-bot/python-telegram-bot/pull/5186
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
v23https://github.com/python-telegram-bot/python-telegram-bot/milestone/53
https://github.com/harshil21
harshil21https://github.com/harshil21
on Mar 31, 2026https://github.com/python-telegram-bot/python-telegram-bot/issues/5189#issue-4177981660
#2698https://github.com/python-telegram-bot/python-telegram-bot/issues/2698
#5186https://github.com/python-telegram-bot/python-telegram-bot/pull/5186
harshil21https://github.com/harshil21
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
on Mar 31, 2026https://github.com/python-telegram-bot/python-telegram-bot/issues/5189#event-24069723979
harshil21https://github.com/harshil21
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
on Mar 31, 2026https://github.com/python-telegram-bot/python-telegram-bot/issues/5189#event-24069724082
harshil21https://github.com/harshil21
Lowhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=field.Priority%3A%22Low%22
Highhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=field.Effort%3A%22High%22
on May 20, 2026https://github.com/python-telegram-bot/python-telegram-bot/issues/5189#event-25779701812
harshil21https://github.com/harshil21
v23https://github.com/python-telegram-bot/python-telegram-bot/milestone/53
on May 29, 2026https://github.com/python-telegram-bot/python-telegram-bot/issues/5189#event-26105172767
harshil21https://github.com/harshil21
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#5186https://github.com/python-telegram-bot/python-telegram-bot/pull/5186
on Jul 30, 2026https://github.com/python-telegram-bot/python-telegram-bot/issues/5189#event-28737484898
github-actionshttps://github.com/apps/github-actions
on Aug 7, 2026https://github.com/python-telegram-bot/python-telegram-bot/issues/5189#event-29099618886
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/5189
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/5189
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
v23https://github.com/python-telegram-bot/python-telegram-bot/milestone/53
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.