René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Use `datetime.timedelta` to Represent Time Periods","articleBody":"### What kind of feature are you missing? Where do you notice a shortcoming of PTB?\n\nSeveral Telegram Objects and methods currently contain fields/parameters with names `\\w+_period`, wherer the integer value represents a time span in seconds.\nWorking with plain seconds is not very pythonic, just like working with posix timestamps isn't. \n\n### Describe the solution you'd like\n\nIn the long run, we should convert the attributes to `timedelta` objects and make the parameters accept timedelta objects.\n\n#### Methods Parameters\n\nThis is realtively easy, simply accept `timedelta` as well as integers and pass `totalseconds()` to TG. Converting `dtm.timedelta` to `int` can probably be done in the internals of `Bot` or requests so that it doesn't have to happen in each bot method.\n\n#### Classes\n\n* Both attributes and arguments should *only* accept timedeltas in the long run.\n* Since this is a breaking change, we should issue a warning for now about this changing in the future and encouraging users to harden their code against the change\n* For making the `timedelta` support available early, I have two ideas, ~both optional~\n  * ~We can provide a temporary property that returns the timedelta object (e.g. `xy_period_timedelta`). This would need to issue a warning stating that it will be removed once `timedelta` is natively supported. Not overly clean …~\n  * We anyways need to make the `*_period` attributes properties to issue the deprecation warning. We could use this and look for an environment variable, say `PTB_TIMEDELTA`. If set, we return the timedelta object, otherwise the `int`. → let's do this\n\n### Describe alternatives you've considered\n\n_No response_\n\n### Additional context\n\nAdding support for method parameters can be done independently of handling classes.","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2024-11-24T21:13:20.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/4575/python-telegram-bot/issues/4575"}