René's URL Explorer Experiment


Title: [FEATURE] Have per-conversation data (or at least an identifier) in ConversationHandler · Issue #4136 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: [FEATURE] Have per-conversation data (or at least an identifier) in ConversationHandler · Issue #4136 · python-telegram-bot/python-telegram-bot

X Title: [FEATURE] Have per-conversation data (or at least an identifier) in ConversationHandler · Issue #4136 · python-telegram-bot/python-telegram-bot

Description: What kind of feature are you missing? Where do you notice a shortcoming of PTB? When first learning about PTB and particularly about ConversationHandler, it felt quite natural to me that there should be a per-conversation data store, or ...

Open Graph Description: What kind of feature are you missing? Where do you notice a shortcoming of PTB? When first learning about PTB and particularly about ConversationHandler, it felt quite natural to me that there shou...

X Description: What kind of feature are you missing? Where do you notice a shortcoming of PTB? When first learning about PTB and particularly about ConversationHandler, it felt quite natural to me that there shou...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/4136

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[FEATURE] Have per-conversation data (or at least an identifier) in ConversationHandler","articleBody":"### What kind of feature are you missing? Where do you notice a shortcoming of PTB?\r\n\r\nWhen first learning about PTB and particularly about ConversationHandler, it felt quite natural to me that there should be a per-conversation data store, or at least some kind of identifier to univocally identify each conversation.\r\n\r\n### Describe the solution you'd like\r\n\r\nI would like to to have a per-conversation data store, available in callbacks called from a ConversationHandler, e.g.\r\n\r\n```\r\nasync def some_conversation_callback(update, context) -> int:\r\n    context.conversation_data['some_key'] = update.message.text\r\n    return WHATEVER\r\n```\r\n\r\nThis would be cleaned up after a conversation has ended (following all the usual `per_*` semantics).\r\n\r\nAlternatively, a conversation identifier would be a viable alternative:\r\n\r\n```\r\nasync def some_conversation_callback(update, context) -> int:\r\n    conv_id = context.conversation_id\r\n    context.bot_data[conv_id] = {}\r\n    context.bot_data[conv_id]['some_key'] = update.message.text\r\n    return WHATEVER\r\n```\r\n\r\nHowever it must be noted that this alternative has the downside that it requires manual cleanup in all final states (currently END and TIMEOUT), making this bearable but somewhat error-prone.\r\n\r\n### Describe alternatives you've considered\r\n\r\nI have considered subclassing ConversationHandler and monkey-patching it by overriding all the relevant methods to associate a dictionary to each new conversation and destroying it when reaching a final state; and by subclassing CallbackContext to have an additional property to point to this dictionary. I have made a mock-up of this idea which works fine, but this is difficult to support because it relies on manually reviewing the internals of ConversationHandler after each library upgrade.\r\n\r\nDuplicating the entire ConversationHandler implementation also achieves a similar result, while having the milder but still relevant downside that I won't get features and bugfixes automatically :)\r\n\r\nI have also considered manually managing this per-conversation data storage manually in the handler functions of each conversation. However, as described above, the lack of a reliable way to get a per-conversation identifier makes this also somewhat difficult to support, because it requires at the very least to keep this per-conversation data login manually synchronized to the identity semantics of the chosen `per_*` parameters. The internal conversation key would be a suitable identifier, as by definition only one conversation at a time can ever exist at once for each conversation key. A UUID or serial number might be more useful for some user applications (albeit not mine!).\r\n\r\n### Additional context\r\n\r\nSomewhat related to #2331","author":{"url":"https://github.com/vmsh0","@type":"Person","name":"vmsh0"},"datePublished":"2024-02-25T21:46:28Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/4136"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a2ae2809-ec55-f704-8bfd-1162163d9eed
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBF50:1D86C4:526636E:6854519:6B027D93
html-safe-nonce18ef42b7a32094e95c2449501d888cd5dd5e74fe07fc8f30a8d903c7ade03e63
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjUwOjFEODZDNDo1MjY2MzZFOjY4NTQ1MTk6NkIwMjdEOTMiLCJ2aXNpdG9yX2lkIjoiNTE0NDIxMDg4OTE3NTYyOTIwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6aa15c3d97b4c907bcce795226f20b5b6df11067e7d2dd78dc84662904b43f73
hovercard-subject-tagissue:2152955203
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/4136/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e081b146ebc3f2fe3520b877549cfba36c014a56d5bcb1c66e56382040b6a8b8/python-telegram-bot/python-telegram-bot/issues/4136
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e081b146ebc3f2fe3520b877549cfba36c014a56d5bcb1c66e56382040b6a8b8/python-telegram-bot/python-telegram-bot/issues/4136
og:image:altWhat kind of feature are you missing? Where do you notice a shortcoming of PTB? When first learning about PTB and particularly about ConversationHandler, it felt quite natural to me that there shou...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevmsh0
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/4136#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F4136
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F4136
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/4136
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/4136
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/4136
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/4136
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/4136
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
[FEATURE] Have per-conversation data (or at least an identifier) in ConversationHandlerhttps://github.com/python-telegram-bot/python-telegram-bot/issues/4136#top
https://github.com/vmsh0
vmsh0https://github.com/vmsh0
on Feb 25, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/4136#issue-2152955203
#2331https://github.com/python-telegram-bot/python-telegram-bot/issues/2331
vmsh0https://github.com/vmsh0
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Feb 25, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/4136#event-11913935356
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Feb 25, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/4136#issuecomment-1963074621
#2770https://github.com/python-telegram-bot/python-telegram-bot/issues/2770
#2770https://github.com/python-telegram-bot/python-telegram-bot/issues/2770
Bibo-Joshihttps://github.com/Bibo-Joshi
not plannedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Feb 25, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/4136#event-11913957617
github-actionshttps://github.com/apps/github-actions
on Mar 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/4136#event-11993083507
Bibo-Joshihttps://github.com/Bibo-Joshi
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Nov 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/4136#event-15107816245
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/4136
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/4136
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.