René's URL Explorer Experiment


Title: [REFACTOR] Split test classes into two: `TestXXXNoRequest` & `TestXXXRequest` · Issue #3407 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: [REFACTOR] Split test classes into two: `TestXXXNoRequest` & `TestXXXRequest` · Issue #3407 · python-telegram-bot/python-telegram-bot

X Title: [REFACTOR] Split test classes into two: `TestXXXNoRequest` & `TestXXXRequest` · Issue #3407 · python-telegram-bot/python-telegram-bot

Description: Currently each of our test files has about one TestClass, which tests everything about the class together. This is not optimal because: Some tests in the class make actual requests to Telegram, thus slowing down development if you've mad...

Open Graph Description: Currently each of our test files has about one TestClass, which tests everything about the class together. This is not optimal because: Some tests in the class make actual requests to Telegram, thu...

X Description: Currently each of our test files has about one TestClass, which tests everything about the class together. This is not optimal because: Some tests in the class make actual requests to Telegram, thu...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/3407

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[REFACTOR] Split test classes into two: `TestXXXNoRequest` & `TestXXXRequest`","articleBody":"Currently each of our test files has about one TestClass, which tests everything about the class together. This is not optimal because:\r\n\r\n1. Some tests in the class make actual requests to Telegram, thus slowing down development if you've made substantial changes to the class, but don't actually want to test the request part yet.\r\n2. It makes the tests slightly more readable, bearable and just a bit more organized.\r\n\r\n### Implementation\r\n\r\nFor example, `test_sticker.py` should now look like:\r\n\r\n``` python\r\nclass StickerSpace:  # namespace class\r\n     emoji = \"💪🏽 \"\r\n     ...\r\n\r\n@pytest.mark.no_req   # for faster development cycle\r\nclass TestStickerNoRequest:\r\n    def test_de_json(...):\r\n        ...\r\n    def test_a_mock_request(...):\r\n        ...\r\n\r\n@pytest.mark.req  # don't think we need this, but let me know if you'd like this\r\n@pytest.mark.flaky(3, 1)\r\nclass TestStickerRequest:\r\n    def test_custom_emoji(...):\r\n        await bot.get_sticker_set(...)\r\n\r\n```\r\n\r\nAlong with this change, I'll also try to simplify/shorten some tests, if possible.\r\n","author":{"url":"https://github.com/harshil21","@type":"Person","name":"harshil21"},"datePublished":"2022-12-03T21:16:05Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/3407"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e214dfd1-b163-ae16-0c58-b9c20686f74e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8A26:19E4BB:44CB6E3:5790E50:6B023C97
html-safe-nonce00f7ed08eace7b698199d1df5728953e8d23c8aca4805502005ec86e8d2928a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTI2OjE5RTRCQjo0NENCNkUzOjU3OTBFNTA6NkIwMjNDOTciLCJ2aXNpdG9yX2lkIjoiMzA2NTg2NjI5NzU2MTcyNjEwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a04f2c0f14d29f92852e699f6052d9e214428eb13d6ffbc3ca9ad1946d6930e
hovercard-subject-tagissue:1474238286
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/3407/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9e92118532c7ed2c7ef4512d47798e2abffcf5765454a4604b8864fc937d3c25/python-telegram-bot/python-telegram-bot/issues/3407
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9e92118532c7ed2c7ef4512d47798e2abffcf5765454a4604b8864fc937d3c25/python-telegram-bot/python-telegram-bot/issues/3407
og:image:altCurrently each of our test files has about one TestClass, which tests everything about the class together. This is not optimal because: Some tests in the class make actual requests to Telegram, thu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameharshil21
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/3407#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F3407
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F3407
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/3407
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/3407
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/3407
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/3407
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/3407
#3426https://github.com/python-telegram-bot/python-telegram-bot/pull/3426
[REFACTOR] Split test classes into two: TestXXXNoRequest & TestXXXRequesthttps://github.com/python-telegram-bot/python-telegram-bot/issues/3407#top
#3426https://github.com/python-telegram-bot/python-telegram-bot/pull/3426
https://github.com/harshil21
⚙️ testsaffected functionality: testshttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%E2%9A%99%EF%B8%8F%20tests%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
https://github.com/harshil21
harshil21https://github.com/harshil21
on Dec 3, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issue-1474238286
harshil21https://github.com/harshil21
⚙️ testsaffected functionality: testshttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%E2%9A%99%EF%B8%8F%20tests%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
on Dec 3, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#event-7947076861
harshil21https://github.com/harshil21
on Dec 3, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#event-7947077024
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Dec 3, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issuecomment-1336261094
#3249https://github.com/python-telegram-bot/python-telegram-bot/pull/3249
https://github.com/harshil21
harshil21https://github.com/harshil21
on Dec 3, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issuecomment-1336264083
#3249https://github.com/python-telegram-bot/python-telegram-bot/pull/3249
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Dec 4, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issuecomment-1336386870
https://github.com/harshil21
harshil21https://github.com/harshil21
on Dec 4, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issuecomment-1336401184
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Dec 4, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issuecomment-1336511502
https://github.com/harshil21
harshil21https://github.com/harshil21
on Dec 4, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issuecomment-1336516077
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on Dec 5, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issuecomment-1337444221
https://github.com/lemontree210
lemontree210https://github.com/lemontree210
on Dec 6, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#issuecomment-1339696680
Bibo-Joshihttps://github.com/Bibo-Joshi
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#3426https://github.com/python-telegram-bot/python-telegram-bot/pull/3426
on Feb 11, 2023https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#event-8496101829
github-actionshttps://github.com/apps/github-actions
on Feb 19, 2023https://github.com/python-telegram-bot/python-telegram-bot/issues/3407#event-8554724928
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/3407
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/3407
harshil21https://github.com/harshil21
⚙️ testsaffected functionality: testshttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%E2%9A%99%EF%B8%8F%20tests%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.