René's URL Explorer Experiment


Title: [BUG] Application gets stuck while manually stopping in async environment · Issue #3397 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: [BUG] Application gets stuck while manually stopping in async environment · Issue #3397 · python-telegram-bot/python-telegram-bot

X Title: [BUG] Application gets stuck while manually stopping in async environment · Issue #3397 · python-telegram-bot/python-telegram-bot

Description: Steps to Reproduce Create an async environment with signal handling and task cancellation to run the Telegram bot in. Working code example: import asyncio import logging import signal import telegram.ext import telegram.ext.filters loggi...

Open Graph Description: Steps to Reproduce Create an async environment with signal handling and task cancellation to run the Telegram bot in. Working code example: import asyncio import logging import signal import telegr...

X Description: Steps to Reproduce Create an async environment with signal handling and task cancellation to run the Telegram bot in. Working code example: import asyncio import logging import signal import telegr...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/3397

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG] Application gets stuck while manually stopping in async environment","articleBody":"### Steps to Reproduce\n\n1. Create an async environment with signal handling and task cancellation to run the Telegram bot in. Working code example:\r\n```python\r\nimport asyncio\r\nimport logging\r\nimport signal\r\nimport telegram.ext\r\nimport telegram.ext.filters\r\n\r\nlogging.basicConfig(level=logging.DEBUG)\r\nlog = logging.getLogger(\"custom\")\r\napp = telegram.ext.ApplicationBuilder().token(\"\u003ctoken here>\").build()\r\n\r\nasync def main():\r\n    loop = asyncio.get_event_loop()\r\n    loop.add_signal_handler(signal.SIGTERM, lambda: asyncio.create_task(shutdown(loop)))\r\n\r\n    await app.initialize()\r\n    await app.start()\r\n    await app.updater.start_polling()\r\n    try:\r\n        while True:\r\n            log.info(\"Now running in main loop...\")\r\n            await asyncio.sleep(10000)\r\n    except asyncio.CancelledError:\r\n        log.warning(\"Telegram wait loop got cancelled, stopping...\")\r\n        await app.updater.stop()\r\n        await app.stop()\r\n        await app.shutdown()\r\n\r\nasync def shutdown(loop):\r\n    log.warning(\"Received SIGTERM, shutting down...\")\r\n    tasks = [task for task in asyncio.all_tasks() if task is not asyncio.current_task()]\r\n    [task.cancel() for task in tasks]\r\n    log.warning(\"Waiting for async tasks to be cancelled...\")\r\n    await asyncio.gather(*tasks)\r\n\r\nasyncio.run(main())\r\n```\r\n2. Send a SIGTERM to the process: `kill -s SIGTERM \u003cpid>`\n\n### Expected behaviour\n\nApplication stops correctly.\n\n### Actual behaviour\n\nApplication gets stuck while stopping and never stops, see logs. After the last log line, nothing happens, no matter how long I'm waiting. I have to manually kill the process with another signal like SIGKILL to stop it (ungracefully).\n\n### Operating System\n\nLinux (tested on Fedora 37, Ubuntu 22.04 and within a Debian docker container)\n\n### Version of Python, python-telegram-bot & dependencies\n\n```shell\npython-telegram-bot 20.0a6\r\nBot API 6.3\r\nPython 3.11.0 (main, Oct 24 2022, 00:00:00) [GCC 12.2.1 20220819 (Red Hat 12.2.1-2)]\n```\n\n\n### Relevant log output\n\n```python\n[...]\r\nINFO:custom:Now running in main loop...\r\nDEBUG:telegram.ext._updater:Start network loop retry getting Updates\r\nDEBUG:telegram._bot:Entering: get_updates\r\nWARNING:custom:Received SIGTERM, shutting down...\r\nWARNING:custom:Waiting for async tasks to be cancelled...\r\nWARNING:custom:Telegram wait loop got cancelled, stopping...\r\nDEBUG:telegram.ext._updater:Stopping Updater\r\nDEBUG:telegram.ext._updater:Waiting background polling task to finish up.\r\nDEBUG:telegram.ext._updater:Network loop retry getting Updates was cancelled\r\nDEBUG:telegram.ext._updater:Updater.stop() is complete\r\nINFO:telegram.ext._application:Application is stopping. This might take a moment.\r\nDEBUG:telegram.ext._application:Waiting for update_queue to join\n```\n\n\n### Additional Context\n\nI noticed that my Docker containers with Telegram bots always take ~10 seconds to get stopped which is a sign that SIGTERM doesn't suffice for stopping the container and a SIGKILL is needed. That's when I started digging deeper and found out about this.\r\n\r\nI have other applications \"embedded\" in the same asyncio termination signal handling and they're stopped as expected.\r\n\r\n**Without the signal handling and task cancelling, this issue doesn't seem to appear. So it seems to be related to either the application getting the SIGTERM or the asyncio tasks getting cancelled.**\r\n\r\nI'm not 100% sure that I'm doing asyncio task cancelling correctly but since it works for other applications, it seems weird to me that it doesn't work for PTB in such a weird way.**\r\n\r\nCode example that **isn't** affected by this issue:\r\n```python\r\nimport asyncio\r\nimport logging\r\nimport telegram.ext\r\nimport telegram.ext.filters\r\n\r\nlogging.basicConfig(level=logging.DEBUG)\r\nlog = logging.getLogger(\"custom\")\r\napp = telegram.ext.ApplicationBuilder().token(\"\u003ctoken here>\").build()\r\n\r\nasync def main():\r\n    await app.initialize()\r\n    await app.start()\r\n    await app.updater.start_polling()\r\n    log.info(\"Now running for 5 seconds...\")\r\n    await asyncio.sleep(5)\r\n    log.warning(\"Trying to stop now...\")\r\n    await app.updater.stop()\r\n    await app.stop()\r\n    await app.shutdown()\r\n\r\nasyncio.run(main())\r\n```","author":{"url":"https://github.com/0x4c47","@type":"Person","name":"0x4c47"},"datePublished":"2022-11-28T21:15:28Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/3397"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:873c9fee-6598-31cd-b321-f2e909faef39
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9610:1728CB:45495B:5AB59E:6B025BDB
html-safe-nonce01d388f306e296b8d39d327ea58a7ddb473faeac551b2833e87a3ab4b08b8dcd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjEwOjE3MjhDQjo0NTQ5NUI6NUFCNTlFOjZCMDI1QkRCIiwidmlzaXRvcl9pZCI6IjY0ODAyMzU5MTYyODY5MDk0MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdcad6af0f10287f4e9f0933c4157c8a5f759a0867120e6207d88aa87ad4ec1f5
hovercard-subject-tagissue:1467103993
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/3397/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e34fada694a0da05da88303d37a20efd0b710fa0e5713830d2581b963a0a0332/python-telegram-bot/python-telegram-bot/issues/3397
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e34fada694a0da05da88303d37a20efd0b710fa0e5713830d2581b963a0a0332/python-telegram-bot/python-telegram-bot/issues/3397
og:image:altSteps to Reproduce Create an async environment with signal handling and task cancellation to run the Telegram bot in. Working code example: import asyncio import logging import signal import telegr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:username0x4c47
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/3397#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F3397
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F3397
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/3397
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/3397
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/3397
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/3397
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/3397
🐛 bughttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"🐛 bug"
[BUG] Application gets stuck while manually stopping in async environmenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/3397#top
https://github.com/0x4c47
0x4c47https://github.com/0x4c47
on Nov 28, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#issue-1467103993
0x4c47https://github.com/0x4c47
bug 🐛https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
on Nov 28, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#event-7906904467
https://github.com/0x4c47
0x4c47https://github.com/0x4c47
on Nov 28, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#issuecomment-1329796021
https://www.roguelynn.com/words/asyncio-graceful-shutdowns/https://www.roguelynn.com/words/asyncio-graceful-shutdowns/
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Nov 29, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#issuecomment-1330604217
https://www.roguelynn.com/words/asyncio-graceful-shutdowns/https://www.roguelynn.com/words/asyncio-graceful-shutdowns/
asyncio.gatherhttps://docs.python.org/3/library/asyncio-task.html#asyncio.gather
https://github.com/0x4c47
0x4c47https://github.com/0x4c47
on Nov 29, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#issuecomment-1331074887
herehttps://docs.python-telegram-bot.org/en/v20.0a6/telegram.ext.application.html#telegram.ext.Application.run_polling
#3230https://github.com/python-telegram-bot/python-telegram-bot/issues/3230
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Nov 30, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#issuecomment-1332158254
herehttps://docs.python-telegram-bot.org/en/v20.0a6/telegram.ext.application.html#telegram.ext.Application.run_polling
#3230https://github.com/python-telegram-bot/python-telegram-bot/issues/3230
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Nov 30, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#issuecomment-1332169717
#3401https://github.com/python-telegram-bot/python-telegram-bot/issues/3401
Bibo-Joshihttps://github.com/Bibo-Joshi
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 30, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#event-7922203633
github-actionshttps://github.com/apps/github-actions
on Dec 7, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#event-7980404955
Bibo-Joshihttps://github.com/Bibo-Joshi
bug 🐛https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
on Nov 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/3397#event-15107766192
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/3397
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/3397
🐛 bughttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"🐛 bug"
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.