René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bot is responding to commands for other bots in group chats when privacy option is turned off","articleBody":"\u003c!--\nThanks for reporting issues of python-telegram-bot!\nTo make it easier for us to help you please enter detailed information below.\n--\u003e\n### Steps to reproduce\n1. Get a bot, turn off privacy option in `@botfather`, and drag it in a group with other bots (which should respond to `/start` command in a group).\n2. Set up the bot with the following code:\n\n``` python\nimport telegram, telegram.ext\ntb = telegram.ext.Updater(\"TOKEN\")\ndef a(bot, update):\n    bot.sendMessage(update.message.chat_id, \"responding to /start cmd\")\n\ntb.dispatcher.add_handler(telegram.ext.CommandHandler(\"start\", b))\ntb.start_polling()\n```\n1. Send command `/start@some_other_bot` to the group, and your bot will respond to it.\n2. Send command `/start` to the group and your bot (and in fact many other bots) will respond to it too.\n### Expected behaviour\n\nBot should not respond to cmds not pointing to it, and better give an option not to respond to cmd with no target in a group.\n### Configuration\n\n**Operating System:**\nMac OS X El Capitan\n\n**Version of Python:**\n\n`$ python3 -V`\n\n`Python 3.5.1`\n\n**Version of python-telegram-bot:**\n\n`$ python3 -c 'import telegram; print(telegram.__version__)'`\n\n`4.1.1`\n### Logs\n\nInsert logs here (if necessary)\n### Where the issue happens\n\n``` python\nupdate.message.text[1:].split(' ')[0].split('@')[0] == self.command\n```\n\non line 45 of `telegram/ext/commandhandler.py`\nIt is not checking for the target of command issued by user.\n### Suggested changes\n1. [ ] Check for commands with `@` for whether it's pointed to the bot.\n2. [ ] Add a parameter to `CommandHandler`: toggle whether if the bot should respond to simple commands (command without `@name_of_the_bot`) in a group, and default it to True. (for backward compatibility, and behaviour consistancy)\n","author":{"url":"https://github.com/blueset","@type":"Person","name":"blueset"},"datePublished":"2016-06-01T10:35:32.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":15},"url":"https://github.com/319/python-telegram-bot/issues/319"}