René's URL Explorer Experiment


Title: Handling of defaults for bot methods · Issue #2900 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Handling of defaults for bot methods · Issue #2900 · python-telegram-bot/python-telegram-bot

X Title: Handling of defaults for bot methods · Issue #2900 · python-telegram-bot/python-telegram-bot

Description: Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in send_poll: python-telegram-bot/telegram/bot.p...

Open Graph Description: Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in send_...

X Description: Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in send_...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2900

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Handling of defaults for bot methods","articleBody":"Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in `send_poll`:\r\n\r\nhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/bot.py#L5141-L5147\r\n\r\nand in `ReplyKeyboardMarkup`:\r\n\r\nhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/replykeyboardmarkup.py#L87-L92\r\n\r\nMore importantly, we pass those values to TG. This isn't really necessary, since we'd get the same behavior when not passing those parameters. This has two effects:\r\n\r\n1. More params are getting passed -> more traffic than strictly necessary. admittedly, probably barely noticable, but still.\r\n2. In case TG changes some defaults, the change will not be reflected in PTB until we change the signature.\r\n\r\nWhile the first one is clearly a downside, one *might* argue that the second one does have some advantages in terms of stability. Personally, I'd rather comply with the current state of the bot API, but I'm open to discussing this.\r\n\r\nIn any case, I think we should do this uniformly, i.e. either reflect the default value in the signature everywhere or nowhere & try to unit test this in `test_official`. E.g. Currently e.g. the `emoji` parameter of `send_dice` has `None` as default value instead of `'🎲'`:\r\n\r\nhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/bot.py#L5315-L5326\r\n\r\nIn case we go for removing the default values, some bot methods internals may be simplified.\r\nEither change would be non-breaking since the current defaults in the signatures are up to date with the defaults documented in the API.","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2022-02-15T19:57:42Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2900"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c49715f8-7742-b283-8def-3e69c0a84ab1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id80F6:21BD98:47A2D06:5A86A07:6B0279BE
html-safe-noncea3da31c73b6c3111496888541ea398a56ed5f8efbf72fad9601018d292e7424d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEY2OjIxQkQ5ODo0N0EyRDA2OjVBODZBMDc6NkIwMjc5QkUiLCJ2aXNpdG9yX2lkIjoiODQ2OTg1NDg5MzExMTQwOTA4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd3cab04b2e1ada7e705f2dd14a17205aa57117a497e09d40656cef4f2a8e2397
hovercard-subject-tagissue:1139154592
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2900/issue_layout
twitter:imagehttps://opengraph.githubassets.com/245441add0c21aaa10a43afdd5c2bdd49f1c1a7a89c38c3bb1697fa1bf7963e1/python-telegram-bot/python-telegram-bot/issues/2900
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/245441add0c21aaa10a43afdd5c2bdd49f1c1a7a89c38c3bb1697fa1bf7963e1/python-telegram-bot/python-telegram-bot/issues/2900
og:image:altCurrently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in send_...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBibo-Joshi
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/2900#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2900
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2900
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2900
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2900
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2900
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2900
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2900
#2978https://github.com/python-telegram-bot/python-telegram-bot/pull/2978
Handling of defaults for bot methodshttps://github.com/python-telegram-bot/python-telegram-bot/issues/2900#top
#2978https://github.com/python-telegram-bot/python-telegram-bot/pull/2978
https://github.com/harshil21
⚙️ bot-apiaffected functionality: bot-apihttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%E2%9A%99%EF%B8%8F%20bot-api%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
v20.0a0https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Feb 15, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2900#issue-1139154592
python-telegram-bot/telegram/bot.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/bot.py#L5141-L5147
92cb6f3https://github.com/python-telegram-bot/python-telegram-bot/commit/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95
python-telegram-bot/telegram/replykeyboardmarkup.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/replykeyboardmarkup.py#L87-L92
92cb6f3https://github.com/python-telegram-bot/python-telegram-bot/commit/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95
python-telegram-bot/telegram/bot.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/bot.py#L5315-L5326
92cb6f3https://github.com/python-telegram-bot/python-telegram-bot/commit/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95
Bibo-Joshihttps://github.com/Bibo-Joshi
⚙️ bot-apiaffected functionality: bot-apihttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%E2%9A%99%EF%B8%8F%20bot-api%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
on Feb 15, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2900#event-6077888582
Bibo-Joshihttps://github.com/Bibo-Joshi
v14https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
on Feb 15, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2900#event-6077888618
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on Feb 16, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2900#issuecomment-1041356145
harshil21https://github.com/harshil21
on Mar 11, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2900#event-6226899934
Bibo-Joshihttps://github.com/Bibo-Joshi
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#2978https://github.com/python-telegram-bot/python-telegram-bot/pull/2978
on May 9, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2900#event-6575013090
github-actionshttps://github.com/apps/github-actions
on May 16, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2900#event-6618227844
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2900
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2900
harshil21https://github.com/harshil21
⚙️ bot-apiaffected functionality: bot-apihttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%E2%9A%99%EF%B8%8F%20bot-api%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
v20.0a0https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.