Title: Handling of defaults for bot methods · Issue #2900 · python-telegram-bot/python-telegram-bot · GitHub
Open Graph Title: Handling of defaults for bot methods · Issue #2900 · python-telegram-bot/python-telegram-bot
X Title: Handling of defaults for bot methods · Issue #2900 · python-telegram-bot/python-telegram-bot
Description: Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in send_poll: python-telegram-bot/telegram/bot.p...
Open Graph Description: Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in send_...
X Description: Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in send_...
Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2900
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Handling of defaults for bot methods","articleBody":"Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in `send_poll`:\r\n\r\nhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/bot.py#L5141-L5147\r\n\r\nand in `ReplyKeyboardMarkup`:\r\n\r\nhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/replykeyboardmarkup.py#L87-L92\r\n\r\nMore importantly, we pass those values to TG. This isn't really necessary, since we'd get the same behavior when not passing those parameters. This has two effects:\r\n\r\n1. More params are getting passed -> more traffic than strictly necessary. admittedly, probably barely noticable, but still.\r\n2. In case TG changes some defaults, the change will not be reflected in PTB until we change the signature.\r\n\r\nWhile the first one is clearly a downside, one *might* argue that the second one does have some advantages in terms of stability. Personally, I'd rather comply with the current state of the bot API, but I'm open to discussing this.\r\n\r\nIn any case, I think we should do this uniformly, i.e. either reflect the default value in the signature everywhere or nowhere & try to unit test this in `test_official`. E.g. Currently e.g. the `emoji` parameter of `send_dice` has `None` as default value instead of `'🎲'`:\r\n\r\nhttps://github.com/python-telegram-bot/python-telegram-bot/blob/92cb6f3ae8d5c3e49b9019a9348d4408135ffc95/telegram/bot.py#L5315-L5326\r\n\r\nIn case we go for removing the default values, some bot methods internals may be simplified.\r\nEither change would be non-breaking since the current defaults in the signatures are up to date with the defaults documented in the API.","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2022-02-15T19:57:42Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2900"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c49715f8-7742-b283-8def-3e69c0a84ab1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 80F6:21BD98:47A2D06:5A86A07:6B0279BE |
| html-safe-nonce | a3da31c73b6c3111496888541ea398a56ed5f8efbf72fad9601018d292e7424d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEY2OjIxQkQ5ODo0N0EyRDA2OjVBODZBMDc6NkIwMjc5QkUiLCJ2aXNpdG9yX2lkIjoiODQ2OTg1NDg5MzExMTQwOTA4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d3cab04b2e1ada7e705f2dd14a17205aa57117a497e09d40656cef4f2a8e2397 |
| hovercard-subject-tag | issue:1139154592 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2900/issue_layout |
| twitter:image | https://opengraph.githubassets.com/245441add0c21aaa10a43afdd5c2bdd49f1c1a7a89c38c3bb1697fa1bf7963e1/python-telegram-bot/python-telegram-bot/issues/2900 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/245441add0c21aaa10a43afdd5c2bdd49f1c1a7a89c38c3bb1697fa1bf7963e1/python-telegram-bot/python-telegram-bot/issues/2900 |
| og:image:alt | Currently we have a few places, where the default value in the signature specifies the default value specified by Telegram. This is both the case for bot methods and Telegram classes. E.g. in send_... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Bibo-Joshi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git |
| octolytics-dimension-user_id | 16178365 |
| octolytics-dimension-user_login | python-telegram-bot |
| octolytics-dimension-repository_id | 38696925 |
| octolytics-dimension-repository_nwo | python-telegram-bot/python-telegram-bot |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38696925 |
| octolytics-dimension-repository_network_root_nwo | python-telegram-bot/python-telegram-bot |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width