René's URL Explorer Experiment


Title: [FEATURE] Automatic dismiss repeated callbackquery updates · Issue #2539 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: [FEATURE] Automatic dismiss repeated callbackquery updates · Issue #2539 · python-telegram-bot/python-telegram-bot

X Title: [FEATURE] Automatic dismiss repeated callbackquery updates · Issue #2539 · python-telegram-bot/python-telegram-bot

Description: Is your feature request related to a problem? Please describe. Clients allow users to spam button presses. This leads to race conditions where the code edited the reply_markup and then tries to edit again even though it was already edite...

Open Graph Description: Is your feature request related to a problem? Please describe. Clients allow users to spam button presses. This leads to race conditions where the code edited the reply_markup and then tries to edi...

X Description: Is your feature request related to a problem? Please describe. Clients allow users to spam button presses. This leads to race conditions where the code edited the reply_markup and then tries to edi...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2539

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[FEATURE] Automatic dismiss repeated callbackquery updates","articleBody":"#### Is your feature request related to a problem? Please describe.\r\nClients allow users to spam button presses. This leads to race conditions where the code edited the reply_markup and then tries to edit again even though it was already edited because several updates resulted from the same button.\r\n\r\n#### Describe the solution you'd like\r\nI would like to have the library handle these race conditions with some simple code checks and not propagate these repeated updates to the handlers.\r\n\r\nDoing this for non async handlers is very easy. All this library needs to store is the callback_data from the first inline button send/edit_message request, and then the callback_data from the next one or a deleted flag if the reply_markup is removed; all this valued to a unique key from chat+message_id or inline_message_id. If then an update happens which has the first callback_data even though the next one is expected, or another callbackquery update happens when the delete flag is set, the query should be answered (for this, maybe the answer value should be stored as well) and then the update dismissed.\r\n\r\nI am not sure how to handle this for async handlers, but I think we could try and apply the same logic, and warn in the docs that it can just happen that two Updates slip through. I hope someone here can think of a better way to handle this. One alternative would be to not handle a multiple update with the same callback_data from the unique key. But that could lead to an issue where something else in the code breaks temporarily, and a user isn't able to try hitting the button again after some time when that issue is resolved. Maybe we can work with try expect for that? \r\n\r\n#### Describe alternatives you've considered\r\n\r\nThis can be easily implemented client side, and with minimal coding effort with a decorator. I vote against this for two reasons: I would need to do this for every callbackqueryhandler manually, and I mostly think beginners will overlook this issue. Then they are facing errors they cant understand because no one thinks about spamming a button that fast.","author":{"url":"https://github.com/Poolitzer","@type":"Person","name":"Poolitzer"},"datePublished":"2021-05-29T10:07:51Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2539"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ff2ed0e9-3fe2-fd40-5a79-9e6abb73acef
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDE6E:38EE04:29468B3:3626874:6B026E65
html-safe-nonceaef1ea949c1dda7ba8bb2e2e8c9393fa72dd8cbb51710f0fe122fe39eae90f90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTZFOjM4RUUwNDoyOTQ2OEIzOjM2MjY4NzQ6NkIwMjZFNjUiLCJ2aXNpdG9yX2lkIjoiMzE3NjI1NDMyNzIzMjgxODc4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac237e9552f4f6121110414838c69f0532db35c88aa10a91193b6cedd5f23de704
hovercard-subject-tagissue:906435133
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2539/issue_layout
twitter:imagehttps://opengraph.githubassets.com/12e56b5c476ac5847ff7a56065f8e159abe23e53d7e7cd3f46d1c48a48abf82d/python-telegram-bot/python-telegram-bot/issues/2539
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/12e56b5c476ac5847ff7a56065f8e159abe23e53d7e7cd3f46d1c48a48abf82d/python-telegram-bot/python-telegram-bot/issues/2539
og:image:altIs your feature request related to a problem? Please describe. Clients allow users to spam button presses. This leads to race conditions where the code edited the reply_markup and then tries to edi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamePoolitzer
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/2539#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2539
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2539
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2539
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2539
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2539
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2539
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2539
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
[FEATURE] Automatic dismiss repeated callbackquery updateshttps://github.com/python-telegram-bot/python-telegram-bot/issues/2539#top
https://github.com/Poolitzer
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on May 29, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issue-906435133
Poolitzerhttps://github.com/Poolitzer
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on May 29, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#event-4815874325
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on May 29, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-850840827
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on May 29, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-850843306
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on May 30, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-850994168
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on May 31, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-851581715
@Bibo-Joshihttps://github.com/Bibo-Joshi
Arbitrary callback data #1844https://github.com/python-telegram-bot/python-telegram-bot/pull/1844
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jun 6, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-855402598
python-telegram-bot/examples/arbitrarycallbackdatabot.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/e982a5a5674b77d191f8a1f5de345064ab39946a/examples/arbitrarycallbackdatabot.py#L56-L73
e982a5ahttps://github.com/python-telegram-bot/python-telegram-bot/commit/e982a5a5674b77d191f8a1f5de345064ab39946a
Poolitzerhttps://github.com/Poolitzer
on Oct 29, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#event-5542395393
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Oct 30, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-955180528
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jun 2, 2023https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-1574362860
#3654https://github.com/python-telegram-bot/python-telegram-bot/pull/3654
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jul 16, 2023https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-1637056472
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Oct 21, 2023https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#issuecomment-1773883020
Bibo-Joshihttps://github.com/Bibo-Joshi
not plannedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Oct 21, 2023https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#event-10731874325
github-actionshttps://github.com/apps/github-actions
on Oct 29, 2023https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#event-10799051178
Bibo-Joshihttps://github.com/Bibo-Joshi
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Nov 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/2539#event-15107708115
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2539
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2539
Poolitzerhttps://github.com/Poolitzer
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.