René's URL Explorer Experiment


Title: Overhaul of warnings · Issue #2467 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Overhaul of warnings · Issue #2467 · python-telegram-bot/python-telegram-bot

X Title: Overhaul of warnings · Issue #2467 · python-telegram-bot/python-telegram-bot

Description: While reviewing #2464 I noticed that we're not very consistend on whether we use logger.warning or warnings.warn to issue warnings to users and I think we should try to overhaul that in v14. Here are a few things that came to my mind and...

Open Graph Description: While reviewing #2464 I noticed that we're not very consistend on whether we use logger.warning or warnings.warn to issue warnings to users and I think we should try to overhaul that in v14. Here a...

X Description: While reviewing #2464 I noticed that we're not very consistend on whether we use logger.warning or warnings.warn to issue warnings to users and I think we should try to overhaul that in v14. He...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2467

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Overhaul of warnings","articleBody":"While reviewing #2464 I noticed that we're not very consistend on whether we use `logger.warning` or `warnings.warn` to issue warnings to users and I think we should try to overhaul that in v14. Here are a few things that came to my mind and that I'd like to discuss & tackle:\r\n\r\n* We should add a subclass of `UserWarning` named `TelegramUserWarning` or similar. That way users can filter for those explicitly, if they want to.\r\n* `TelegramDeprecationWarning` should then become a subclass of that new class\r\n* Both should be properly included in the documentation. They exist so that users can use them in filtering, so users should be above to find them in the docs. To this end, they should probably also be easier importable, i.e. via `telegram.utils.TGWarning` or `telegram.deprecation.TGWarning`, maybe even `telegram.TGWarning` (see also #2468)\r\n* Regarding when to use what: Citing the [python docs on logging](https://docs.python.org/3/howto/logging.html#when-to-use-logging):\r\n\r\n  > **Issue a warning regarding a particular runtime event:**\r\n  > warnings.warn() in library code if the issue is avoidable and the client application should be modified to eliminate the warning\r\n  >\r\n  > logging.warning() if there is nothing the client application can do about the situation, but the event should still be noted\r\n\r\n  The way I understand this, this would mean in particular that we should use `warnings.warn()` whenever\r\n\r\n  * the user passes some non-reasonable value on initialization on classes that are usually set up manually (e.g. `Updater` and `Handlers`, in contrast to the TG types)\r\n  * the way the users tries to use stuff does not correspond to how they set up the bot (thinking of e.g. [~this~](https://github.com/python-telegram-bot/python-telegram-bot/blob/conv-timeout/telegram/ext/conversationhandler.py#L625) [this](https://github.com/python-telegram-bot/python-telegram-bot/blob/bcec6f03cb1797d31039926f0c8c0f2306dcdf5a/telegram/ext/conversationhandler.py#L648-L651))\r\n  * the users misuses something, the example that I have in mind is equality comparison for objects that have no `_id_attrs`\r\n\r\n* We should make a wiki page on logging and warnings. We can then delete the logging section from the readme. the wiki page should also contain some basic info about how to catch warnings in the logger and how to filter warnings/logging entries made by PTB.\r\n* **edit:** for warnings, it would be good to double check that the `stacklevel` is set appropriately \r\n\r\nAs changing warnings \u003c-> logs is somewhat breaking at least for people who filter those things, I'm putting this on the v14 milestone.","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2021-04-13T15:53:22Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2467"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a3acb063-472d-cea0-1b0a-73566ffd5d93
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBC6E:2E7DFB:84D60A:ADE8F5:6B0255C1
html-safe-nonce618685f9670eee42b3e04afe13a574d3cb6d6583a2541cc02b89a51c5ce66f9a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzZFOjJFN0RGQjo4NEQ2MEE6QURFOEY1OjZCMDI1NUMxIiwidmlzaXRvcl9pZCI6IjE2MjkwMDU2OTA0MjcyOTkyNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac790d669f2ce0811676609a030636e3af15d4aef775e72bbdffc050e38ff101db
hovercard-subject-tagissue:857100445
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2467/issue_layout
twitter:imagehttps://opengraph.githubassets.com/103748f637c8c12d47cfbf2d3f11362fbec2e5a5c96c6dc561a49e7b8c6eef13/python-telegram-bot/python-telegram-bot/issues/2467
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/103748f637c8c12d47cfbf2d3f11362fbec2e5a5c96c6dc561a49e7b8c6eef13/python-telegram-bot/python-telegram-bot/issues/2467
og:image:altWhile reviewing #2464 I noticed that we're not very consistend on whether we use logger.warning or warnings.warn to issue warnings to users and I think we should try to overhaul that in v14. Here a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBibo-Joshi
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/2467#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2467
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2467
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2467
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2467
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2467
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2467
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2467
Overhaul of warningshttps://github.com/python-telegram-bot/python-telegram-bot/issues/2467#top
https://github.com/harshil21
🛠 breakingchange type: breakinghttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20breaking%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
v20.0a0https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Apr 13, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#issue-857100445
#2464https://github.com/python-telegram-bot/python-telegram-bot/pull/2464
Clear up imports policy #2468https://github.com/python-telegram-bot/python-telegram-bot/issues/2468
python docs on logginghttps://docs.python.org/3/howto/logging.html#when-to-use-logging
thishttps://github.com/python-telegram-bot/python-telegram-bot/blob/conv-timeout/telegram/ext/conversationhandler.py#L625
thishttps://github.com/python-telegram-bot/python-telegram-bot/blob/bcec6f03cb1797d31039926f0c8c0f2306dcdf5a/telegram/ext/conversationhandler.py#L648-L651
Bibo-Joshihttps://github.com/Bibo-Joshi
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
🛠 breakingchange type: breakinghttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20breaking%22
on Apr 13, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#event-4588931433
Bibo-Joshihttps://github.com/Bibo-Joshi
v14https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
on Apr 13, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#event-4588931441
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on Apr 13, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#issuecomment-818858949
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on Jul 20, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#issuecomment-883605967
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jul 21, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#issuecomment-883926239
python-telegram-bot/telegram/ext/conversationhandler.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/bcec6f03cb1797d31039926f0c8c0f2306dcdf5a/telegram/ext/conversationhandler.py#L648-L651
bcec6f0https://github.com/python-telegram-bot/python-telegram-bot/commit/bcec6f03cb1797d31039926f0c8c0f2306dcdf5a
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on Aug 4, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#issuecomment-892546585
#2615https://github.com/python-telegram-bot/python-telegram-bot/issues/2615
harshil21https://github.com/harshil21
on Sep 15, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#event-5305922152
Bibo-Joshihttps://github.com/Bibo-Joshi
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 20, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#event-5326244490
github-actionshttps://github.com/apps/github-actions
on Sep 21, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2467#event-5337509052
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2467
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2467
harshil21https://github.com/harshil21
🛠 breakingchange type: breakinghttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20breaking%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
v20.0a0https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.