René's URL Explorer Experiment


Title: Check promise states in conversation timeout callback | timeouts & nested conversations · Issue #2407 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Check promise states in conversation timeout callback | timeouts & nested conversations · Issue #2407 · python-telegram-bot/python-telegram-bot

X Title: Check promise states in conversation timeout callback | timeouts & nested conversations · Issue #2407 · python-telegram-bot/python-telegram-bot

Description: When using ConversationHandler with async handler callbacks and timeout, the timeout may trigger falsely. This is the case, when the callback returns CH.END, which currently the timeout callback doesn't know. This can be solved by making...

Open Graph Description: When using ConversationHandler with async handler callbacks and timeout, the timeout may trigger falsely. This is the case, when the callback returns CH.END, which currently the timeout callback do...

X Description: When using ConversationHandler with async handler callbacks and timeout, the timeout may trigger falsely. This is the case, when the callback returns CH.END, which currently the timeout callback do...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2407

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Check promise states in conversation timeout callback | timeouts & nested conversations","articleBody":"When using `ConversationHandler` with async handler callbacks and timeout, the timeout may trigger falsely. This is the case, when the callback returns `CH.END`, which currently the timeout callback doesn't know.\r\n\r\nThis can be solved by making `CH._trigger_timeout` check if the current conversations state as follows:\r\n\r\n```python\r\nif isinstance(state, Promise):\r\n    if state.done and state.result() == CH.END:\r\n        return\r\n```\r\n\r\nThis will still fail, if the promise is not yet done, when the timeout triggers but\r\n\r\n1. it's a best effort solution\r\n2. if a promise takes longer to run than the timeout is, then there are probably some other issues in the users code\r\n\r\nAlso when looking at the code I noticed that we don't handle nested conversations in `CH._trigger_timeout`, so that's a good opportunity to fix that …","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2021-03-01T16:19:36Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2407"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:83888886-5a6b-2991-de16-da8ecbe8193d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C82:386611:ADE757:E3DB82:6B0266CF
html-safe-nonceceadb350405f04ea6418602f2472b4a80d0859f29beb85a10ebd8716ad5c33ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzgyOjM4NjYxMTpBREU3NTc6RTNEQjgyOjZCMDI2NkNGIiwidmlzaXRvcl9pZCI6IjMxMzQxNDgzMzUxNTE2MTI5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1f7b48306830f17b856a958b505adc91c683cdc91e563227700c7d83547891eb
hovercard-subject-tagissue:819026953
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2407/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5faf1c794d5dfb78e75b274b71d54a0396c435fbafad2ba5f1d770ac1ffc088c/python-telegram-bot/python-telegram-bot/issues/2407
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5faf1c794d5dfb78e75b274b71d54a0396c435fbafad2ba5f1d770ac1ffc088c/python-telegram-bot/python-telegram-bot/issues/2407
og:image:altWhen using ConversationHandler with async handler callbacks and timeout, the timeout may trigger falsely. This is the case, when the callback returns CH.END, which currently the timeout callback do...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBibo-Joshi
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/2407#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2407
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2407
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2407
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2407
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2407
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2407
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2407
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
#2417https://github.com/python-telegram-bot/python-telegram-bot/pull/2417
Check promise states in conversation timeout callback | timeouts & nested conversationshttps://github.com/python-telegram-bot/python-telegram-bot/issues/2407#top
#2417https://github.com/python-telegram-bot/python-telegram-bot/pull/2417
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Mar 1, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2407#issue-819026953
Bibo-Joshihttps://github.com/Bibo-Joshi
bug 🐛https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Mar 1, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2407#event-4390548672
Bibo-Joshihttps://github.com/Bibo-Joshi
v13.4https://github.com/python-telegram-bot/python-telegram-bot/milestone/26
on Mar 1, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2407#event-4390548679
Bibo-Joshihttps://github.com/Bibo-Joshi
v13.4https://github.com/python-telegram-bot/python-telegram-bot/milestone/26
13.5https://github.com/python-telegram-bot/python-telegram-bot/milestone/27
on Mar 11, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2407#event-4446797143
Bibo-Joshihttps://github.com/Bibo-Joshi
v13.5https://github.com/python-telegram-bot/python-telegram-bot/milestone/27
on Mar 28, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2407#event-4517965813
Bibo-Joshihttps://github.com/Bibo-Joshi
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#2417https://github.com/python-telegram-bot/python-telegram-bot/pull/2417
on Apr 30, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2407#event-4667821000
github-actionshttps://github.com/apps/github-actions
on May 1, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2407#event-4673866820
Bibo-Joshihttps://github.com/Bibo-Joshi
bug 🐛https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Nov 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/2407#event-15107697556
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2407
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2407
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.