René's URL Explorer Experiment


Title: [FEATURE] ConversationHandler: Allow special handlers/callbacks for entering states · Issue #2390 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: [FEATURE] ConversationHandler: Allow special handlers/callbacks for entering states · Issue #2390 · python-telegram-bot/python-telegram-bot

X Title: [FEATURE] ConversationHandler: Allow special handlers/callbacks for entering states · Issue #2390 · python-telegram-bot/python-telegram-bot

Description: Originally proposed in #2388, rewriting here to summarize. Motivation ConversationHandler currently reacts to updates that happen while in a state. This means that a callback needs to "prepare" everything that the next state expects to h...

Open Graph Description: Originally proposed in #2388, rewriting here to summarize. Motivation ConversationHandler currently reacts to updates that happen while in a state. This means that a callback needs to "prepare" eve...

X Description: Originally proposed in #2388, rewriting here to summarize. Motivation ConversationHandler currently reacts to updates that happen while in a state. This means that a callback needs to "prepare...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2390

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[FEATURE] ConversationHandler: Allow special handlers/callbacks for entering states","articleBody":"Originally proposed in #2388, rewriting here to summarize.\r\n\r\n## Motivation\r\n\r\n`ConversationHandler` currently reacts to updates that happen __while__ in a state. This means that a callback needs to \"prepare\" everything that the next state expects to have happend (e.g. send a message the user needs to react to). This can sometimes make it a bit hard to follow the logic of \"what needs to be done where\" and can also lead to code duplication in the cases where\r\n\r\n* multiple states lead to the same next state, thus they all need to do the same preparations\r\n* nested conversations are used that lead back to a parents state thats also reached directly by parent states. Here the child conversation needs to do the same preparations as the parent conversation.\r\n\r\nIn the setting of nested conversations this also leads to the parent conversation and the child conversation being dependent on each other, making child conversations less reusable for different parents.\r\n\r\n## Proposed feature\r\n\r\nAllow to run code when \"entering\" a state. This could be either a simple `callback(update, context)` or (which I would prefer) a list of handlers, just like currently for `states`. The logic would then be something along the lines:\r\n\r\n```python\r\ndef handle_update(self, update):\r\n    ...\r\n    new_state = selected_handler(update, context)\r\n    if for handler in self.state_entries.get(new_state, []):\r\n        if handler.check_update(update):\r\n            handler.handle_update(update, context)\r\n            break\r\n```\r\nThe entry handlers could be specified via a `entries` keyword (or whatever naming) that accepts a dictionary just like `states` does. \r\n\r\nOf course it should be purely optional, because a) backwards compatibility and b) simple conversations will still do fine without it.\r\n\r\n## Integration with `run_async`\r\n\r\nWhen a state-handler runs asynchronously, we only get a promise and hence don't know the next state. what we could do is add a method `add_done_callback` to `ext.utils.Promise` that makes sure the corresponding callback is run when `Promise.run` is done.\r\nThis is exactly what's provided by [`asyncio.Task/Future`](https://docs.python.org/3/library/asyncio-task.html#asyncio.Task.add_done_callback), so this has a high chance of not being an issue in the context of #2288.\r\n\r\n## Current alternatives\r\n\r\nWhat one can currently do to reduce code duplication is ofc to extract the duplicated code to a standalone function and call that wherever needed. In the setting of child conversations that should be reusable by different parents, one can use a factory pattern, i.e. have a method\r\n\r\n```python\r\ndef build_child_conversation(extracted_function_1, extracted_function_2, …) -> ConversationHandler:\r\n    …\r\n```\r\nthat inserts the passed functions into the logic of the child conversation. This allows for the highest level of encapsulation. If that's not needed, one can also just directly use the corresponding functions of the parent conversation directly.\r\n\r\nWhile those soltions a viable, they require some manual work and still lead to some extend of code duplication.\r\n\r\n## Summary & Things to consider\r\n\r\nOne can surely argue that `ConversationHandler` is already complex enough and that the added benefit is rather small and mostly interesting for very advanced users who like to design their code as clean as possible. On the other hand I can imagine that this can help some users follow the logic of `ConversationHandler` more easily and promoting clean code structure is nothing to be ashamed of.\r\n\r\nBasically I think this is a reasonable feature to have, but would not be opposed to disregarding it in favor of maintainability.\r\n\r\nRagarding the integration with `run_async`, it may be worth to just wait for v14 to be out, before tackling this (if we decide to do so).","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2021-02-16T17:17:57Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2390"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:59418f18-efb9-1922-63a0-7a43896d57e5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE914:1F92:33007C:405790:6B027DA0
html-safe-nonce23454624d9c87697b4b9bcbaee9882b39ce5ddc3f449f95189e0d64ba827ef88
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTE0OjFGOTI6MzMwMDdDOjQwNTc5MDo2QjAyN0RBMCIsInZpc2l0b3JfaWQiOiI0NDAxMzA1ODg2MjcwODQ4NDE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace32f21e143708f189348d5c56040d52d5bb8407acf77ad046b727726c0bb5b7e
hovercard-subject-tagissue:809501263
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2390/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3384ef368b287312e653f007dc5ffb7001bc418cedc40f2a1ab30b4619b8d22e/python-telegram-bot/python-telegram-bot/issues/2390
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3384ef368b287312e653f007dc5ffb7001bc418cedc40f2a1ab30b4619b8d22e/python-telegram-bot/python-telegram-bot/issues/2390
og:image:altOriginally proposed in #2388, rewriting here to summarize. Motivation ConversationHandler currently reacts to updates that happen while in a state. This means that a callback needs to "prepare" eve...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBibo-Joshi
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/2390#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2390
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2390
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2390
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2390
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2390
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2390
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2390
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
[FEATURE] ConversationHandler: Allow special handlers/callbacks for entering stateshttps://github.com/python-telegram-bot/python-telegram-bot/issues/2390#top
v20.0https://github.com/python-telegram-bot/python-telegram-bot/milestone/34
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Feb 16, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#issue-809501263
#2388https://github.com/python-telegram-bot/python-telegram-bot/issues/2388
asyncio.Task/Futurehttps://docs.python.org/3/library/asyncio-task.html#asyncio.Task.add_done_callback
#2288https://github.com/python-telegram-bot/python-telegram-bot/issues/2288
Bibo-Joshihttps://github.com/Bibo-Joshi
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Feb 16, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#event-4337367733
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Feb 18, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#issuecomment-781489431
thishttps://t.me/pythontelegrambotgroup/436961
https://github.com/perseoGI
perseoGIhttps://github.com/perseoGI
on Feb 18, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#issuecomment-781498661
thishttps://t.me/pythontelegrambotgroup/436961
@Bibo-Joshihttps://github.com/Bibo-Joshi
harshil21https://github.com/harshil21
v14https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
on Oct 8, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#event-5433224560
harshil21https://github.com/harshil21
v20https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
v20.0a1https://github.com/python-telegram-bot/python-telegram-bot/milestone/33
on May 12, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#event-6599369307
Bibo-Joshihttps://github.com/Bibo-Joshi
v20.0a1https://github.com/python-telegram-bot/python-telegram-bot/milestone/33
v20.0https://github.com/python-telegram-bot/python-telegram-bot/milestone/34
on May 21, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#event-6654888433
https://github.com/Plataformaalgoritmica
Plataformaalgoritmicahttps://github.com/Plataformaalgoritmica
on Jun 5, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#issuecomment-1146782811
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Nov 18, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#issuecomment-1320024427
#2770https://github.com/python-telegram-bot/python-telegram-bot/issues/2770
#2770https://github.com/python-telegram-bot/python-telegram-bot/issues/2770
Bibo-Joshihttps://github.com/Bibo-Joshi
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 18, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#event-7844015195
github-actionshttps://github.com/apps/github-actions
on Nov 25, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#event-7894591219
Bibo-Joshihttps://github.com/Bibo-Joshi
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Nov 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/2390#event-15107696269
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2390
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2390
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
v20.0https://github.com/python-telegram-bot/python-telegram-bot/milestone/34
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.