Title: Switch to asyncio · Issue #2288 · python-telegram-bot/python-telegram-bot · GitHub
Open Graph Title: Switch to asyncio · Issue #2288 · python-telegram-bot/python-telegram-bot
X Title: Switch to asyncio · Issue #2288 · python-telegram-bot/python-telegram-bot
Description: After some internal discussion we decided that it's time to make the switch to asyncio and we will do so in the next major release (v14). This is not due in the forseable future and this issue just summarizes some notes on that. As this ...
Open Graph Description: After some internal discussion we decided that it's time to make the switch to asyncio and we will do so in the next major release (v14). This is not due in the forseable future and this issue just...
X Description: After some internal discussion we decided that it's time to make the switch to asyncio and we will do so in the next major release (v14). This is not due in the forseable future and this issue ...
Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2288
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Switch to asyncio","articleBody":"After some internal discussion we decided that it's time to make the switch to `asyncio` and we will do so in the next major release (v14). This is not due in the forseable future and this issue just summarizes some notes on that.\r\n\r\n------------------------------------------\r\n\r\nAs this is a major breaking change, the community should be involved. What we do is:\r\n\r\n* Make an announcement way ahead of release time & pin this issue\r\n* Maintaining backward compatibility will probably be a lot of work and we already made the experience with `use_context` that this gives trouble. Therefore we will not offer a compatibility layer\r\n* However, we should give the commutiy the chance to do so on their own. This will be achieved by making an announcement when the asyncio-branch is ready and giving the community some time to prepare before we actually release\r\n\r\n------------------------------------------\r\n\r\nCurrently updates are handled one after the other by default and changing that would mean major breaking changes. Especially `ConversationHandler` usually relies on updates being processed one after the other. Noam sketched something how we could make dispatcher handle some updates asyncio and some sync. We should use that idea to make `run_async` basically work the same after the switch. We already have `Defaults.run_async` in place, so it's easy to make everything completely asynico if wanted.\r\n\r\nAnother rough thought in this direction: One could want updates to pass through the groups __synchronously__, while still processing multiple updates at the same time. We could add a setting for that and in `Dispatcher` do something like\r\n```python\r\nif self.process_async:\r\n run_but_dont_await(self.process_update(update))\r\nelse:\r\n await self.process_update(update)\r\n```\r\nSee [here](https://t.me/pythontelegrambottalk/163580) for some discussion.\r\n\r\n------------------------------------------\r\n\r\nSwitching to `asyncio` will probably be a good time to switch to another lib for making requests. We can choose that work better with `asyncio` and doesn't need to be vendored. Candidates include\r\n\r\n* httpx\r\n* tornado+pycurl with the benefit that `curl` is the defacto standard (though latter would be a hassle for windows users)\r\n* aiohttp. open question: does it support connection reusal? upside would be that users wouldn't have to install another lib for making requests, if they need that.\r\n\r\nRequirements for a requests-lib to fulfill:\r\n\r\n* connection reusal\r\n* working behind proxies: http, socks5 + dns resolution over the proxy\r\n* Would be great if it supports Google App Engine as urllib3 currently does\r\n\r\n--------------------------------------------\r\n\r\nFirst feedback on the announcement included Flask not supporting asyncio natively. As Flask is one of the more common setups PTB is used in, we could provide an example on how to use asycnio PTB with flask.\r\n\r\nEdit: We should probably still suggest to use a framework that supports asyncio natively, e.g. Quart\r\n\r\n--------------------------------------------\r\n\r\nCheck #2351 for more community feedback","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2021-01-03T09:43:00Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2288"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f63d4691-3199-fe68-9706-3accdc8b8860 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C7BE:A71F9:44BE523:56C0759:6B026AC9 |
| html-safe-nonce | 8c0fe4be418b7713f89ac921f0854d012fe7ef4bb1e716611f6b451fa9955b30 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0JFOkE3MUY5OjQ0QkU1MjM6NTZDMDc1OTo2QjAyNkFDOSIsInZpc2l0b3JfaWQiOiIxNjEwMjcyNTg0OTc1NDExOTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 74d590b9dd01287e70c7bfd8b6e62229ef582823a765ff8c66ea8fd1bf6f4eb6 |
| hovercard-subject-tag | issue:777605192 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2288/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c713c6fc01315ce9258c217cd20ba9972496766785c936cbd92823a684358fd9/python-telegram-bot/python-telegram-bot/issues/2288 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c713c6fc01315ce9258c217cd20ba9972496766785c936cbd92823a684358fd9/python-telegram-bot/python-telegram-bot/issues/2288 |
| og:image:alt | After some internal discussion we decided that it's time to make the switch to asyncio and we will do so in the next major release (v14). This is not due in the forseable future and this issue just... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Bibo-Joshi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git |
| octolytics-dimension-user_id | 16178365 |
| octolytics-dimension-user_login | python-telegram-bot |
| octolytics-dimension-repository_id | 38696925 |
| octolytics-dimension-repository_nwo | python-telegram-bot/python-telegram-bot |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38696925 |
| octolytics-dimension-repository_network_root_nwo | python-telegram-bot/python-telegram-bot |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width