René's URL Explorer Experiment


Title: Refactor Filters · Issue #2178 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Refactor Filters · Issue #2178 · python-telegram-bot/python-telegram-bot

X Title: Refactor Filters · Issue #2178 · python-telegram-bot/python-telegram-bot

Description: Currently filters check updates via the __call__ method. When switching from function-based filters to class-based filters, this was mainly done to maintain backwards compatibility with filter(update). However with some of the new filter...

Open Graph Description: Currently filters check updates via the __call__ method. When switching from function-based filters to class-based filters, this was mainly done to maintain backwards compatibility with filter(upda...

X Description: Currently filters check updates via the __call__ method. When switching from function-based filters to class-based filters, this was mainly done to maintain backwards compatibility with filter(upda...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2178

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor Filters","articleBody":"Currently filters check updates via the `__call__` method. When switching from function-based filters to class-based filters, this was mainly done to maintain backwards compatibility with `filter(update)`. However with some of the new filters functionalities, this leads to ugly workarounds like\r\n\r\nhttps://github.com/python-telegram-bot/python-telegram-bot/blob/8e7c0d6976055f970cd16bab9a1fcea5da7135cd/telegram/ext/filters.py#L329-L350\r\n\r\nI therefore propose to refactor to something along the lines of\r\n\r\n```python\r\nclass BaseFilter:\r\n    def __call__(self, *args, **kwargs):\r\n        return self.__class__(*args, **kwargs)\r\n\r\n    @abstractmethod\r\n    def check_update(update/method):\r\n        ...\r\n```\r\n\r\nThis matches the `Handler.check_update` interface and allows for filters having a custom `__init__`, wich can still be called through instances of those filters.\r\n\r\nHowever, this is somewhat breaking: While `BaseFilter.__call__` is undocumented, people might still have `Filters.existing_filter(update)` somewhere within their custom filters. So *maybe* this is better suited for a major release. ","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2020-11-03T20:54:39Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2178"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5270e0ed-ba76-4bf3-d6bd-f67c7fc94ea1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD1C4:3B07B3:18EC019:1F3FC14:6B026CB2
html-safe-nonce86e2d52723f712e18d813318b0732e0f7f0128085e35d0cdb6287aa88a8172ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUM0OjNCMDdCMzoxOEVDMDE5OjFGM0ZDMTQ6NkIwMjZDQjIiLCJ2aXNpdG9yX2lkIjoiOTA4Mjg1MjY2MTYxODk2MTU4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfe159ef31f44efee2eb7c58154b5935e3b3f5de6a51078ebdf4ac54d5937a7a0
hovercard-subject-tagissue:735628537
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2178/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bb071d663b8b42bd94e9226bfd25b4d5398f1d312cd1838e63bd5160087505f1/python-telegram-bot/python-telegram-bot/issues/2178
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bb071d663b8b42bd94e9226bfd25b4d5398f1d312cd1838e63bd5160087505f1/python-telegram-bot/python-telegram-bot/issues/2178
og:image:altCurrently filters check updates via the __call__ method. When switching from function-based filters to class-based filters, this was mainly done to maintain backwards compatibility with filter(upda...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBibo-Joshi
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/2178#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2178
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2178
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2178
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2178
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2178
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2178
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2178
#2759https://github.com/python-telegram-bot/python-telegram-bot/pull/2759
Refactor Filtershttps://github.com/python-telegram-bot/python-telegram-bot/issues/2178#top
#2759https://github.com/python-telegram-bot/python-telegram-bot/pull/2759
https://github.com/harshil21
🛠 breakingchange type: breakinghttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20breaking%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
v20.0a0https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Nov 3, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issue-735628537
python-telegram-bot/telegram/ext/filters.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/8e7c0d6976055f970cd16bab9a1fcea5da7135cd/telegram/ext/filters.py#L329-L350
8e7c0d6https://github.com/python-telegram-bot/python-telegram-bot/commit/8e7c0d6976055f970cd16bab9a1fcea5da7135cd
Bibo-Joshihttps://github.com/Bibo-Joshi
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
on Nov 3, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#event-3954760100
Bibo-Joshihttps://github.com/Bibo-Joshi
v14https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
on Nov 4, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#event-3959562033
Bibo-Joshihttps://github.com/Bibo-Joshi
🛠 breakingchange type: breakinghttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20breaking%22
on Dec 17, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#event-4126483012
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jul 22, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#event-5056537307
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jul 22, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-885044631
python-telegram-bot/telegram/ext/messagehandler.pyhttps://github.com/python-telegram-bot/python-telegram-bot/blob/2c2aaea3c11db5c0a052a66cb99e7eff6edf07cf/telegram/ext/messagehandler.py#L26-L30
2c2aaeahttps://github.com/python-telegram-bot/python-telegram-bot/commit/2c2aaea3c11db5c0a052a66cb99e7eff6edf07cf
SO questionhttps://stackoverflow.com/questions/47444780
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Oct 10, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-939483019
https://github.com/jeffsieu
jeffsieuhttps://github.com/jeffsieu
on Oct 11, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-939653667
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Oct 11, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-939701223
@Poolitzerhttps://github.com/Poolitzer
@starry69https://github.com/starry69
@harshil21https://github.com/harshil21
https://github.com/harshil21
harshil21https://github.com/harshil21
on Oct 11, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-940173140
https://github.com/jeffsieu
jeffsieuhttps://github.com/jeffsieu
on Oct 13, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-942075621
@Poolitzerhttps://github.com/Poolitzer
@starry69https://github.com/starry69
@harshil21https://github.com/harshil21
https://github.com/Poolitzer
Poolitzerhttps://github.com/Poolitzer
on Oct 15, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-944159933
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Oct 15, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-944399261
@jeffsieuhttps://github.com/jeffsieu
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Oct 26, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#issuecomment-951597289
harshil21https://github.com/harshil21
on Oct 28, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#event-5532592001
harshil21https://github.com/harshil21
Overhaul of Filters #2759https://github.com/python-telegram-bot/python-telegram-bot/pull/2759
on Oct 30, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#event-5544542920
harshil21https://github.com/harshil21
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 20, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#event-5648800393
github-actionshttps://github.com/apps/github-actions
on Nov 27, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2178#event-5680353791
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2178
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2178
harshil21https://github.com/harshil21
🛠 breakingchange type: breakinghttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20breaking%22
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
v20.0a0https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.