René's URL Explorer Experiment


Title: Refactor MessageQueue · Issue #2139 · python-telegram-bot/python-telegram-bot · GitHub

Open Graph Title: Refactor MessageQueue · Issue #2139 · python-telegram-bot/python-telegram-bot

X Title: Refactor MessageQueue · Issue #2139 · python-telegram-bot/python-telegram-bot

Description: TL;DR: Known bugs are Defaults not working #2015 Hanging when using ctrl + c #2012 Context manager for opening file broken #2035 Shortcuts lost their *args and **kwargs #2392 Errors are being hidden #3201 Long version: Using MessageQueue...

Open Graph Description: TL;DR: Known bugs are Defaults not working #2015 Hanging when using ctrl + c #2012 Context manager for opening file broken #2035 Shortcuts lost their *args and **kwargs #2392 Errors are being hidde...

X Description: TL;DR: Known bugs are Defaults not working #2015 Hanging when using ctrl + c #2012 Context manager for opening file broken #2035 Shortcuts lost their *args and **kwargs #2392 Errors are being hidde...

Opengraph URL: https://github.com/python-telegram-bot/python-telegram-bot/issues/2139

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor MessageQueue","articleBody":"# TL;DR:\r\n\r\nKnown bugs are \r\n\r\n- Defaults not working #2015\r\n- Hanging when using ctrl + c #2012 \r\n- Context manager for opening file broken #2035 \r\n- Shortcuts lost their *args and **kwargs  #2392\r\n- Errors are being hidden #3201\r\n\r\n# Long version:\r\n\r\nUsing `MessageQueue` currently requires quite some manual work and there also the aformentioned bugs. Time to live up to the wikis statement\r\n\r\n> We plan to tightly couple it with telegram.Bot so that it could be used more conveniently (and even implicitly unless other specified).\r\n\r\nSo here is what my idea for a refactoring is. I'd be happy for feedback before getting started :)\r\n\r\n## Refactoring of `MessageQueue` and `DelayQueue`\r\n\r\n* `DQ.exc_route`: I'd like to rename to `error_handler` in accordance with `Dispatcher.add_error_handler`.\r\n* If a `Dispatcher` is used, it would make sense to have the execution of the promises to behave like the refactored `Dipsatcher._pooled`, which also includes proper error handling. That can be easily achieved by passing the `Dispatcher` to either the `Bot` or the `MessageQueue`. Not sure yet, what makes more sense …\r\n* I think I'd like to repace the `__call__` methods with `process` or whatever. That's more explicit and easier to read in the code.\r\n* Add `MQ.add/remove_delay_queue` so that users can add custom delay queues in addition to the default & the group one. One should be able to specify a parent (defaulting to the default DQ) for `new_dq`, such that everything going throguh  `new_dq` will also go through the parent. `MQ.add_remove_delay_queue` sohuld also start/stop the `DQ` in case we're adding them at runtime. Edit: This will in fact close #1369 , as I just notice\r\n* Add constants for the default & the group DQ\r\n* Handle the stopping of `MQ` correctly, some hints are already given in #2012\r\n\r\n## Integration into Bot\r\n\r\nAdd a `MessageQueue` to `Bot` by default and rebuild all methods in the fashion\r\n\r\n```python\r\n\r\ndef badly_sketched_messagequeue_wrapper(func, *args, **kwargs):\r\n    delay_queue = kwargs.pop('delay_queue')\r\n    if delay_queue == self.message_queue.DEFAULT_DQ and int(kwargs.get('chat_id')) \u003c 0: \r\n        return self.message_queue.process(func, self.message_queue.GROUP_DQ)\r\n    elif delay_queue:\r\n        return self.message_queue.process(func, delay_queue)\r\n    return func(*args, **kwargs)\r\n\r\n@badly_sketched_messagequeue_wrapper\r\ndef send_message(…, delay_queue=None):\r\n    ...\r\n```\r\n\r\nsuch that `delay_queue` allows to select the delay queue the method is passed through, replacing the current `queue` and `isgroup` kwargs\r\n\r\n* Together with the changes to `Bot.__new__` as in discussed #2015 , this should resolve #2015 \r\n* for cases where one only needs `Bot`, without `Dispatcher` or `Updater`, one could do something like\r\n\r\n```\r\ndef badly_sketched_messagequeue_wrapper(func, *args, **kwargs):\r\n    if self.message_queue.is_running:\r\n        # see above\r\n    return func(*args, **kwargs)\r\n```\r\nso users can easily opt-into `MessageQueue` with `bot.mq.start/stop()`\r\n\r\n## Integration with `Defaults`\r\n\r\nAdd `Defaults.delay_queue` defaulting to `None` (I'm not in favor of implicitly always using the `MessageQueue`)\r\n\r\n## Handling context managers\r\n\r\nI think the approach detailed in #2035 is feasible (build `InputFiles` already in `Promise.__init__`). I can't think of any use case, where a context manager would be used for anything else that we'd to handle …\r\n\r\nEdit: Now I can. See #2160 \r\n\r\n## Backwards compatibility\r\n\r\nAll of above changes should be doable without breaking changes.\r\nHower, given that `MessageQueue` is essentially still in the same quite rough state as when introduced in #537 3.5 years ago, IMHO it would be okay to removethe current usage pattern (i.e. the `@queuedmessage` decorator) in the next major release (which probably will be mostly a \"delete all the stuff\" release anyway …)","author":{"url":"https://github.com/Bibo-Joshi","@type":"Person","name":"Bibo-Joshi"},"datePublished":"2020-10-12T17:27:04Z","url":"https://github.com/python-telegram-bot/python-telegram-bot/issues/2139"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:432acc32-b87f-cf6b-3277-ea4c5e27594c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB984:DB09F:48323A3:5BECFEF:6B025926
html-safe-nonce7cf3f61fd3a773e141d7c6af222af00a59d585d27ba1e0aaeb4a8bc24037a524
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTg0OkRCMDlGOjQ4MzIzQTM6NUJFQ0ZFRjo2QjAyNTkyNiIsInZpc2l0b3JfaWQiOiI0MTA1MjMzNDM2NzA3NTQzMzM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5445b057e7584fe7bd8278c9954cebbdfaeff3fa4e3bdc7b24669bb75d2a8209
hovercard-subject-tagissue:719540005
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-telegram-bot/python-telegram-bot/2139/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e4488586dbe9440be62d400a3553bd1493810ae1b4c826b7eede4d66328f4e81/python-telegram-bot/python-telegram-bot/issues/2139
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e4488586dbe9440be62d400a3553bd1493810ae1b4c826b7eede4d66328f4e81/python-telegram-bot/python-telegram-bot/issues/2139
og:image:altTL;DR: Known bugs are Defaults not working #2015 Hanging when using ctrl + c #2012 Context manager for opening file broken #2035 Shortcuts lost their *args and **kwargs #2392 Errors are being hidde...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBibo-Joshi
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python-telegram-bot/python-telegram-bot git https://github.com/python-telegram-bot/python-telegram-bot.git
octolytics-dimension-user_id16178365
octolytics-dimension-user_loginpython-telegram-bot
octolytics-dimension-repository_id38696925
octolytics-dimension-repository_nwopython-telegram-bot/python-telegram-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38696925
octolytics-dimension-repository_network_root_nwopython-telegram-bot/python-telegram-bot
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python-telegram-bot/python-telegram-bot/issues/2139#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2139
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-telegram-bot%2Fpython-telegram-bot%2Fissues%2F2139
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python-telegram-bot%2Fpython-telegram-bot
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2139
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2139
Reloadhttps://github.com/python-telegram-bot/python-telegram-bot/issues/2139
python-telegram-bothttps://github.com/python-telegram-bot
python-telegram-bothttps://github.com/python-telegram-bot/python-telegram-bot
Codehttps://github.com/python-telegram-bot/python-telegram-bot
Issues23 (23)https://github.com/python-telegram-bot/python-telegram-bot/issues
Pull requests19 (19)https://github.com/python-telegram-bot/python-telegram-bot/pulls
Discussionshttps://github.com/python-telegram-bot/python-telegram-bot/discussions
Actionshttps://github.com/python-telegram-bot/python-telegram-bot/actions
Projectshttps://github.com/python-telegram-bot/python-telegram-bot/projects
Wikihttps://github.com/python-telegram-bot/python-telegram-bot/wiki
Security and qualityhttps://github.com/python-telegram-bot/python-telegram-bot/security
Insightshttps://github.com/python-telegram-bot/python-telegram-bot/insights
https://github.com/python-telegram-bot/python-telegram-bot
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2139
New issuehttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2139
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
Refactor MessageQueuehttps://github.com/python-telegram-bot/python-telegram-bot/issues/2139#top
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
v20.0a0https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Oct 12, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#issue-719540005
[BUG] Defaults not working with MessageQueue #2015https://github.com/python-telegram-bot/python-telegram-bot/issues/2015
[BUG] Bot hangs when using ctrl + c and MessageQueue #2012https://github.com/python-telegram-bot/python-telegram-bot/issues/2012
[BUG] Context manager not working with MessageQueue #2035https://github.com/python-telegram-bot/python-telegram-bot/issues/2035
[BUG] Shortcuts lost their *args and **kwargs, resulting messagequeue isgroup= and other broke #2392https://github.com/python-telegram-bot/python-telegram-bot/issues/2392
[BUG] Promise ignores exceptions #3201https://github.com/python-telegram-bot/python-telegram-bot/issues/3201
Multiple message queues for a bot #1369https://github.com/python-telegram-bot/python-telegram-bot/issues/1369
[BUG] Bot hangs when using ctrl + c and MessageQueue #2012https://github.com/python-telegram-bot/python-telegram-bot/issues/2012
[BUG] Defaults not working with MessageQueue #2015https://github.com/python-telegram-bot/python-telegram-bot/issues/2015
[BUG] Defaults not working with MessageQueue #2015https://github.com/python-telegram-bot/python-telegram-bot/issues/2015
#2035https://github.com/python-telegram-bot/python-telegram-bot/issues/2035
#2160https://github.com/python-telegram-bot/python-telegram-bot/pull/2160
#537https://github.com/python-telegram-bot/python-telegram-bot/pull/537
Bibo-Joshihttps://github.com/Bibo-Joshi
bug 🐛https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Oct 12, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#event-3867624507
Bibo-Joshihttps://github.com/Bibo-Joshi
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
on Nov 26, 2020https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#event-4043595435
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Jan 2, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#issuecomment-753496322
#1369https://github.com/python-telegram-bot/python-telegram-bot/issues/1369
#2265https://github.com/python-telegram-bot/python-telegram-bot/discussions/2265
Bibo-Joshihttps://github.com/Bibo-Joshi
v14https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
on Jan 2, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#event-4161821427
https://github.com/jagub2
jagub2https://github.com/jagub2
on Feb 23, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#issuecomment-784109645
https://github.com/python-telegram-bot/python-telegram-bot/wiki/Avoiding-flood-limits#using-mq-with-queuedmessage-decoratorhttps://github.com/python-telegram-bot/python-telegram-bot/wiki/Avoiding-flood-limits#using-mq-with-queuedmessage-decorator
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on Feb 23, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#issuecomment-784111664
two bighttps://github.com/python-telegram-bot/python-telegram-bot/wiki/Avoiding-flood-limits#current-status
noteshttps://github.com/python-telegram-bot/python-telegram-bot/wiki/Avoiding-flood-limits#deprecation-notice
https://github.com/jagub2
jagub2https://github.com/jagub2
on Feb 23, 2021https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#issuecomment-784116142
https://github.com/Bibo-Joshi
Bibo-Joshihttps://github.com/Bibo-Joshi
on May 9, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#issuecomment-1121464823
#3018https://github.com/python-telegram-bot/python-telegram-bot/issues/3018
Bibo-Joshihttps://github.com/Bibo-Joshi
completedhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 9, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#event-6575557419
github-actionshttps://github.com/apps/github-actions
on May 17, 2022https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#event-6620990432
Bibo-Joshihttps://github.com/Bibo-Joshi
bug 🐛https://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
enhancementhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Nov 4, 2024https://github.com/python-telegram-bot/python-telegram-bot/issues/2139#event-15107677417
Sign up for freehttps://github.com/signup?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2139
Sign in to commenthttps://github.com/login?return_to=https://github.com/python-telegram-bot/python-telegram-bot/issues/2139
🛠 refactorchange type: refactorhttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=state%3Aopen%20label%3A%22%F0%9F%9B%A0%20refactor%22
💡 featurehttps://github.com/python-telegram-bot/python-telegram-bot/issues?q=type:"💡 feature"
v20.0a0https://github.com/python-telegram-bot/python-telegram-bot/milestone/22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.